From: "Ludovic Courtès" <ludo@gnu.org>
To: Guix Devel <guix-devel@gnu.org>
Subject: Phases and snippets no longer returning a Boolean
Date: Wed, 25 Nov 2020 00:17:41 +0100 [thread overview]
Message-ID: <87sg8ycpka.fsf@inria.fr> (raw)
Hello Guix!
As a followup to our recent discussion¹, I pushed the following commits
to ‘core-updates’:
16111ad11c gnu: gcc: Phases no longer return a Boolean.
3504e39a5d gnu: base, gcc: Removing trailing #t from snippets.
325d00e619 packages: Ignore return value of origin snippets.
4cebe82fa6 build-system/texlive: Phases no longer return a Boolean.
49eadd270c build-system/minify: Phases no longer return a Boolean.
112982526f gnu: base, commencement: Remove trailing #t from build phases.
04baa011e9 build-system/gnu: Ignore the result of phase procedures.
With these changes, the return value of origin snippets and build phases
is now ignored. It had been deprecated, with a warning emitted at build
time, since March 2018 (notably commit
daac9c77b9ed25a3c0edf843fdfe5e209ebef58f). The introduction of ‘invoke’
(commit 3f65c190d23296e7e718c3deff413e8beb61d8ba), which would raise an
error when a program exits with non-zero, was also an enabler. Because
of that I’m quite confident that breakage is unlikely, but we’ll keep an
eye on it.
I only removed trailing #t in a couple of files unlikely to result in
merge conflicts down the road, as Marius rightfully suggested on IRC.
That’s it! Thoughts? Comments?
#t!
Ludo’.
¹ https://lists.gnu.org/archive/html/guix-devel/2020-10/msg00332.html
next reply other threads:[~2020-11-24 23:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 23:17 Ludovic Courtès [this message]
2020-11-25 10:53 ` Phases and snippets no longer returning a Boolean 宋文武
2020-11-25 13:27 ` Danny Milosavljevic
2020-11-25 14:02 ` zimoun
2020-11-25 17:53 ` Leo Famulari
2020-11-27 10:59 ` Ludovic Courtès
2020-11-29 19:30 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg8ycpka.fsf@inria.fr \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.