all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Carlo Zancanaro <carlo@zancanaro.id.au>
Cc: 38769-done@debbugs.gnu.org
Subject: bug#38769: [PATCH] import: Add importer for MELPA packages.
Date: Fri, 18 Dec 2020 12:40:26 +0000	[thread overview]
Message-ID: <87sg831e4l.fsf@cbaines.net> (raw)
In-Reply-To: <87zh2b2wle.fsf@zancanaro.id.au>

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]


Carlo Zancanaro <carlo@zancanaro.id.au> writes:

> Hi Chris!
>
> On Fri, Dec 18 2020, Christopher Baines wrote:
>> Looking at the code, elpa-package->sexp is a little awkward, the
>> code would probably be clearer if the (or ...) bits in the
>> package sexp were moved out in to functions that deal with
>> generating that part of the package.
>
> I agree with you. The "quasiquote, unquote, quasiquote, unquote" is a
> bit awkward, but I don't think it's unreasonable. I'm not that
> interested in revising the patch right now, but feel free to extract
> that logic before merging if you think it's necessary.
>
>> It seems to work though, so I'm happy to push this. Is this patch
>> still relevant?
>
> Yep, as far as I know this is still relevant.

Cool, I've gone ahead and pushed this as
b129b43475442b1da43d8209914fee215f98aa29. Hopefully it'll be helpful.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      reply	other threads:[~2020-12-18 12:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-28  1:59 [bug#38769] [PATCH] import: Add importer for MELPA packages Carlo Zancanaro
2020-01-07 19:39 ` Brett Gilio
2020-03-18  2:54   ` Carlo Zancanaro
2020-05-30 14:26     ` Carlo Zancanaro
2020-07-25  1:49       ` Brett Gilio
2020-12-18 10:32     ` Christopher Baines
2020-12-18 11:16       ` Carlo Zancanaro
2020-12-18 12:40         ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg831e4l.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=38769-done@debbugs.gnu.org \
    --cc=carlo@zancanaro.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.