From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YLSoJME8NmCwTwAA0tVLHw (envelope-from ) for ; Wed, 24 Feb 2021 11:47:13 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4FqGIME8NmBTdQAAB5/wlQ (envelope-from ) for ; Wed, 24 Feb 2021 11:47:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id BB4012610F for ; Wed, 24 Feb 2021 12:47:12 +0100 (CET) Received: from localhost ([::1]:56562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEsdL-0005Nv-TW for larch@yhetil.org; Wed, 24 Feb 2021 06:47:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEsdC-0005Nh-1u for guix-patches@gnu.org; Wed, 24 Feb 2021 06:47:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50441) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEsdB-0001O8-Qp for guix-patches@gnu.org; Wed, 24 Feb 2021 06:47:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lEsdB-0005hQ-PF for guix-patches@gnu.org; Wed, 24 Feb 2021 06:47:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44492] [PATCH 01/52] gnu: Add rust-ruma-identifiers-validation-0.1. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Feb 2021 11:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44492 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo To: Leo Prikler Cc: 44492@debbugs.gnu.org Received: via spool by 44492-submit@debbugs.gnu.org id=B44492.161416721921900 (code B ref 44492); Wed, 24 Feb 2021 11:47:01 +0000 Received: (at 44492) by debbugs.gnu.org; 24 Feb 2021 11:46:59 +0000 Received: from localhost ([127.0.0.1]:33754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEsd8-0005hA-QX for submit@debbugs.gnu.org; Wed, 24 Feb 2021 06:46:59 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:42297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEsd6-0005go-EQ for 44492@debbugs.gnu.org; Wed, 24 Feb 2021 06:46:57 -0500 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 75A9F240008; Wed, 24 Feb 2021 11:46:49 +0000 (UTC) From: Nicolas Goaziou References: <87tuu2p37n.fsf@cbaines.net> <20210224111135.28883-1-leo.prikler@student.tugraz.at> Date: Wed, 24 Feb 2021 12:46:47 +0100 In-Reply-To: <20210224111135.28883-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Wed, 24 Feb 2021 12:10:44 +0100") Message-ID: <87sg5lhemw.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.37 Authentication-Results: aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BB4012610F X-Spam-Score: -2.37 X-Migadu-Scanner: scn1.migadu.com X-TUID: BkrG1exH4DJT Hello, Leo Prikler writes: > * gnu/packages/crates-io.scm (rust-ruma-identifiers-validation-0.1): New > variable. Thank you! I have a few general comments about the patch set. Nitpicks: some synopses end with a full stop, and most descriptions are not full sentences. If you introduce a new version of an existing package, the old package should inherit from the new one. More generally, I still think intermediate packages should use #:skip-build #t. Building them brings very little information, if any: - A crate failing to build, for various reasons, is still correct as an input to another crate - Even if all intermediate crates have "#:skip-build #t", building the top-level crate locates accurately any missing Cargo input in the dependency graph. Not using #:skip-build, OTOH, costs a lot of resources and time for the CI, for users and developers. Of course, this last remark is not specific to your patch set. I wish we can converge towards common Rust packaging guidelines. Regards, -- Nicolas Goaziou