all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: qblade <qblade@protonmail.com>
Cc: 46686@debbugs.gnu.org
Subject: [bug#46686] [PATCH] gnu: add libucl
Date: Sat, 06 Mar 2021 11:32:51 +0100	[thread overview]
Message-ID: <87sg58incc.fsf@gnu.org> (raw)
In-Reply-To: <h7NfSSBWXKgCk4KXIid6eBO4hUAtZfaVRlalkRTyiBp6dUlwxLm3xJMj3rWtGQEPu7jyU6g3X5EL9eJNNp32LHvOX-GDBiJPik7vDgJqzXI=@protonmail.com> (qblade@protonmail.com's message of "Sun, 21 Feb 2021 07:21:15 +0000")

Hi,

qblade <qblade@protonmail.com> skribis:

> From aae95593f1cfd48c50578bec83927c870afc6bce Mon Sep 17 00:00:00 2001
> From: qblade <qblade@protonmail.com>
> Date: Sun, 21 Feb 2021 06:48:18 +0000
> Subject: [PATCH] gnu: add libucl
>
> * gnu/packages/config-lang.scm (libucl): New variable.

Thanks for the patch!  It looks good to me, modulo the minor issues
below.

>  gnu/packages/config-lang.scm | 54 ++++++++++++++++++++++++++++++++++++

Could you perhaps find another file to add it to, so we don’t have a
module for a single package?  That said, I don’t have a good suggestion,
since ‘iniparser’ for instance is in samba.scm.

> +    (synopsis "Universal configuration language")
> +    (description "Universal configuration language.
> +fully compatible with JSON format and is able to parse json files")

Could you reword the description with full sentences, along the lines of:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

Make sure to capitalize acronyms like JSON.

TIA,
Ludo’.




  reply	other threads:[~2021-03-06 10:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-21  7:21 [bug#46686] [PATCH] gnu: add libucl qblade via Guix-patches via
2021-03-06 10:32 ` Ludovic Courtès [this message]
2021-03-07  3:08   ` [bug#46686] 回复: Re: bug#46686: " qblade via Guix-patches via
2021-03-17 21:24     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg58incc.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=46686@debbugs.gnu.org \
    --cc=qblade@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.