all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Nicolò Balzarotti" <anothersms@gmail.com>
To: zimoun <zimon.toutoune@gmail.com>, 47350@debbugs.gnu.org
Cc: ludo@gnu.org
Subject: [bug#47350] [PATCH 00/29] Add Zygote (piece for Machine Learning with Julia)
Date: Wed, 24 Mar 2021 09:15:36 +0100	[thread overview]
Message-ID: <87sg4ldl1z.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <86tup1iifm.fsf@gmail.com>

zimoun <zimon.toutoune@gmail.com> writes:

> If you want to review, then it would help. :-)

Here you go:

Patch applies and everything builds fine.  I also checked the
licenses and they seems fine.  I run some example on the Zygote tutorial
and it worked

Some notes:

julia-macrotools:
> +that let you do deep transformations of code..")
two dots

julia-colors:
Instead of removing the tests, calling julia with --depwarn=yes
should do the trick.
I changed the (check) function in julia-build-system adding
replacing invoke "julia" with invoke "julia" "--depwarn=yes", removed
your phase from julia-colors and everything went well (built zygote and
HTTP, which should cover all packages we have).  Would you mind
fixing the build system directly?  As I guess other packages will fail
the same way


julia-compilersupportlibraries-jll:
julia-openspecfun-jll:
I'd change package description, as it's the default and shared between
all jll packages

julia-constructionbase:
typo: lightwight -> lightweight

julia-irtool:
typo: simpe -> simple

julia-macrotools:
typo: Jlia -> Julia

julia-specialfuntions:
> Most of these functions were formerly part of Base in early versions of Julia.
I'd remove this from the description

julia-forwarddiff:
synopsis seems wrong

julia-zygoterules:
extra space at the end of synopsis

Thanks, Nicolò




  reply	other threads:[~2021-03-24  8:17 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 19:42 [bug#47350] [PATCH 00/29] Add Zygote (piece for Machine Learning with Julia) zimoun
2021-03-23 19:45 ` [bug#47350] [PATCH 01/29] gnu: Add julia-constructionbase zimoun
2021-03-23 19:45   ` [bug#47350] [PATCH 02/29] gnu: Add julia-macrotools zimoun
2021-03-23 19:45   ` [bug#47350] [PATCH 03/29] gnu: Add julia-nanmath zimoun
2021-03-23 19:45   ` [bug#47350] [PATCH 04/29] gnu: Add julia-reexport zimoun
2021-03-23 19:45   ` [bug#47350] [PATCH 05/29] gnu: Add julia-irtools zimoun
2021-03-23 19:45   ` [bug#47350] [PATCH 06/29] gnu: Add julia-staticarrays zimoun
2021-03-23 19:45   ` [bug#47350] [PATCH 07/29] gnu: Add julia-unitful zimoun
2021-03-23 19:45   ` [bug#47350] [PATCH 08/29] gnu: Add julia-abstractffts zimoun
2021-03-23 19:45   ` [bug#47350] [PATCH 09/29] gnu: Add julia-colortypes zimoun
2021-03-23 19:46 ` [bug#47350] [PATCH 10/29] gnu: Add julia-colors zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 11/29] gnu: Add julia-example zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 12/29] gnu: Add julia-requires zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 13/29] gnu: Add julia-chainrulescore zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 14/29] gnu: Add julia-richardson zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 15/29] gnu: Add julia-finitedifferences zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 16/29] gnu: Add julia-chainrulestestutils zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 17/29] gnu: Add julia-fillarrays zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 18/29] gnu: Add julia-commonsubexpressions zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 19/29] gnu: Add julia-calculus zimoun
2021-03-23 19:46 ` [bug#47350] [PATCH 20/29] gnu: Add julia-diffresults zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 21/29] gnu: Add julia-difftests zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 22/29] gnu: Add julia-compilersupportlibraries-jll zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 23/29] gnu: Add julia-openspecfun-jll zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 24/29] gnu: Add julia-specialfunctions zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 25/29] gnu: Add julia-diffrules zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 26/29] gnu: Add julia-chainrules zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 27/29] gnu: Add julia-forwarddiff zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 28/29] gnu: Add julia-zygoterules zimoun
2021-03-23 19:46   ` [bug#47350] [PATCH 29/29] gnu: Add julia-zygote zimoun
2021-03-23 22:48 ` [bug#47350] [PATCH 00/29] Add Zygote (piece for Machine Learning with Julia) Nicolò Balzarotti
2021-03-23 23:01   ` zimoun
2021-03-24  8:15     ` Nicolò Balzarotti [this message]
2021-03-24  9:35       ` zimoun
2021-03-25  0:58         ` zimoun
2021-03-25  9:47           ` Nicolò Balzarotti
2021-03-25 11:32             ` zimoun
2021-03-27 21:01             ` Nicolò Balzarotti
2021-03-27 21:24               ` zimoun
2021-03-27 21:41                 ` Nicolò Balzarotti
2021-03-27 22:08                   ` zimoun
2021-03-29 14:50                     ` bug#47350: " Ludovic Courtès
2021-03-29 15:10                       ` [bug#47350] " zimoun
2021-03-25  1:04 ` [bug#47350] [PATCH v2 01/30] build: julia-build-system: Turn on depreciation warnings zimoun
2021-03-25  1:04   ` [bug#47350] [PATCH v2 02/30] gnu: Add julia-constructionbase zimoun
2021-03-25  1:04   ` [bug#47350] [PATCH v2 03/30] gnu: Add julia-macrotools zimoun
2021-03-25  1:04   ` [bug#47350] [PATCH v2 04/30] gnu: Add julia-nanmath zimoun
2021-03-25  1:04   ` [bug#47350] [PATCH v2 05/30] gnu: Add julia-reexport zimoun
2021-03-25  1:04   ` [bug#47350] [PATCH v2 06/30] gnu: Add julia-irtools zimoun
2021-03-25  1:04   ` [bug#47350] [PATCH v2 07/30] gnu: Add julia-staticarrays zimoun
2021-03-25  1:04   ` [bug#47350] [PATCH v2 08/30] gnu: Add julia-unitful zimoun
2021-03-25  1:04   ` [bug#47350] [PATCH v2 09/30] gnu: Add julia-abstractffts zimoun
2021-03-25  1:04   ` [bug#47350] [PATCH v2 11/30] gnu: Add julia-colors zimoun
2021-03-25  1:04   ` [bug#47350] [PATCH v2 12/30] gnu: Add julia-example zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 13/30] gnu: Add julia-requires zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 14/30] gnu: Add julia-chainrulescore zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 15/30] gnu: Add julia-richardson zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 16/30] gnu: Add julia-finitedifferences zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 17/30] gnu: Add julia-chainrulestestutils zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 18/30] gnu: Add julia-fillarrays zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 19/30] gnu: Add julia-commonsubexpressions zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 21/30] gnu: Add julia-diffresults zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 22/30] gnu: Add julia-difftests zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 23/30] gnu: Add julia-compilersupportlibraries-jll zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 24/30] gnu: Add julia-openspecfun-jll zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 25/30] gnu: Add julia-specialfunctions zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 26/30] gnu: Add julia-diffrules zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 27/30] gnu: Add julia-chainrules zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 28/30] gnu: Add julia-forwarddiff zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 29/30] gnu: Add julia-zygoterules zimoun
2021-03-25  1:05   ` [bug#47350] [PATCH v2 30/30] gnu: Add julia-zygote zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg4ldl1z.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me \
    --to=anothersms@gmail.com \
    --cc=47350@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.