From: Chris Marusich <cmmarusich@gmail.com>
To: 47615@debbugs.gnu.org
Cc: guix-devel@gnu.org
Subject: Re: bug#47615: [PATCH 3/9] gnu: binutils: Adjust test suite on powerpc-linux.
Date: Wed, 21 Apr 2021 22:11:48 -0700 [thread overview]
Message-ID: <87sg3izywb.fsf_-_@gmail.com> (raw)
In-Reply-To: <YHv6jDimnNGP3c2o@3900XT> (Efraim Flashner's message of "Sun, 18 Apr 2021 12:23:24 +0300")
[-- Attachment #1: Type: text/plain, Size: 2305 bytes --]
Efraim Flashner <efraim@flashner.co.il> writes:
>> If it's a test failure, has the issue been reported upstream?
>
> I'll check to see if I can find something upstream. If not I'll report
> it. FWIW Debian disables the test suite for powerpc.
> https://sources.debian.org/src/binutils/2.36.1-6/debian/rules/#L537
How significant is the failure, anyway? Are we likely to encounter
trouble down the line on powerpc if we don't resolve this? I have no
idea, honestly, so I'm asking because I just don't know.
I looked at the rules file you linked. Are you sure it disables the
test for powerpc? It reads:
with_check := yes
ifneq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
# override buildd admins to run the testsuite anyway ...
ifeq (,$(filter $(DEB_HOST_ARCH), m68k powerpc sh4 sparc64))
with_check := disabled through DEB_BUILD_OPTIONS
endif
endif
#with_check := disabled for this upload
I'm not sure what the values for DEB_HOST_ARCH or DEB_BUILD_OPTIONS
would be here. However, it seems to be setting with_check to disabled
if and only if (1) nocheck shows up in DEB_BUILD_OPTIONS and (2)
DEB_HOST_ARCH is not one of m68k, powerpc, sh4, or sparc64. In other
words, it seems to enable the tests unless nocheck is in
DEB_BUILD_OPTIONS, in which case it STILL enables the tests provided
that DEB_HOST_ARCH is one of m68k, powerpc, sh4, or sparc64.
I'm not very familiar with Debian rules files, so perhaps I'm mistaken.
However, I think this means that when DEB_BUILD_OPTIONS doesn't contain
"nocheck" (presumably it doesn't usually?), the tests will be run for
every platform.
In any case, reporting this upstream seems like the right thing to do.
> I like the way you've done it (and the comment). The fewer places with
> copy/pasted code the better. I'm building it again now to see about the
> tests. With your changes I only need to add the phase in (gnu packages
> base).
I think the comment is honestly more than necessary, but if you find it
helpful, perhaps someone in the future might, too. It describes a
possibly surprising behavior of substitute-keyword-arguments that can
happen any time you invoke it. I just wanted to call it out
specifically for the purpose of this patch review.
--
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-04-22 5:12 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 12:24 [bug#47615] [PATCH 0/9] Add 32-bit powerpc support Efraim Flashner
2021-04-06 12:32 ` [bug#47615] [PATCH 1/9] gnu: bootstrap: Add support for powerpc-linux Efraim Flashner
2021-04-14 3:51 ` bug#47615: " Chris Marusich
2021-04-14 7:36 ` Vincent Legoll
2021-04-14 13:56 ` [bug#47615] " Efraim Flashner
2021-05-05 1:52 ` bug#47615: " Chris Marusich
2021-05-05 8:51 ` Efraim Flashner
2021-05-06 16:35 ` Ludovic Courtès
2021-04-06 12:32 ` [bug#47615] [PATCH 2/9] gnu: guile-3.0: Fix building on powerpc-linux Efraim Flashner
2021-04-14 4:00 ` bug#47615: " Chris Marusich
2021-04-14 14:00 ` Efraim Flashner
2021-04-06 12:32 ` [bug#47615] [PATCH 3/9] gnu: binutils: Adjust test suite " Efraim Flashner
2021-04-17 19:51 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Chris Marusich
2021-04-17 20:02 ` bug#47615: [PATCH 3/9] gnu: binutils: Adjust test suite on powerpc-linux Chris Marusich
2021-04-18 9:23 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Efraim Flashner
2021-04-22 5:11 ` Chris Marusich [this message]
2021-04-27 7:01 ` [bug#47615] [PATCH 3/9] gnu: binutils: Adjust test suite on powerpc-linux Efraim Flashner
2021-04-06 12:32 ` [bug#47615] [PATCH 4/9] gnu: mesa: Add support for powerpc-linux Efraim Flashner
2021-04-06 19:29 ` Efraim Flashner
2021-04-06 12:32 ` [PATCH 5/9] gnu: Add mac-fdisk Efraim Flashner
2021-04-06 12:32 ` [bug#47615] [PATCH 6/9] gnu: american-fuzzy-lop: Add support for powerpc-linux Efraim Flashner
2021-04-14 3:25 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Chris Marusich
2021-04-06 12:32 ` [bug#47615] [PATCH 7/9] build: qemu-command: Add support for powerpc Efraim Flashner
2021-04-06 17:02 ` Vincent Legoll
2021-04-06 19:17 ` Efraim Flashner
2021-04-06 22:27 ` Vincent Legoll
2021-04-06 12:32 ` [PATCH 8/9] gnu: mercurial: Skip tests on powerpc-linux Efraim Flashner
2021-04-06 12:32 ` [bug#47615] [PATCH 9/9] gnu: nss: " Efraim Flashner
2021-04-06 17:00 ` Vincent Legoll
2021-04-06 19:18 ` Efraim Flashner
2021-04-06 22:31 ` Vincent Legoll
2021-04-07 20:33 ` [PATCH 0/9] Add 32-bit powerpc support Vincent Legoll
2021-04-08 7:00 ` Efraim Flashner
2021-04-17 16:04 ` Ludovic Courtès
2021-04-17 16:51 ` Vincent Legoll
2021-04-17 19:42 ` Efraim Flashner
2021-04-17 20:07 ` Vincent Legoll
2021-05-06 14:38 ` bug#47615: " Ludovic Courtès
2021-05-10 8:20 ` Efraim Flashner
2021-05-11 20:24 ` Ludovic Courtès
2021-05-24 9:51 ` Efraim Flashner
2021-05-26 14:09 ` Ludovic Courtès
2021-05-31 10:23 ` Tobias Platen
2021-04-22 7:59 ` [bug#47615] [PATCH v2 00/12] " Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 01/12] gnu: bootstrap: Add support for powerpc-linux Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 02/12] gnu: guile-3.0: Fix building on powerpc-linux Efraim Flashner
2021-05-06 14:45 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Ludovic Courtès
2021-05-10 8:01 ` Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 03/12] gnu: gcc-boot0: Use 128-bit long-double on powerpc-linux Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 04/12] gnu: binutils: Fix bug in test suite in libiberty Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 05/12] gnu: mesa: Add support for powerpc-linux Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 06/12] gnu: Add mac-fdisk Efraim Flashner
2021-05-06 14:48 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Ludovic Courtès
2021-05-06 15:48 ` [bug#47615] " Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 07/12] gnu: american-fuzzy-lop: Add support for powerpc-linux Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 08/12] build: qemu-command: Add support for powerpc Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 09/12] gnu: mercurial: Skip tests on powerpc-linux Efraim Flashner
2021-04-22 16:41 ` [bug#47615] " Maxime Devos
2021-05-06 14:51 ` bug#47615: [PATCH 0/9] Add 32-bit powerpc support Ludovic Courtès
2021-04-22 7:59 ` [PATCH v2 10/12] gnu: nss: Skip tests on powerpc-linux Efraim Flashner
2021-04-22 7:59 ` [PATCH v2 11/12] gnu: zstd: Adjust test suite for 32-bit architectures Efraim Flashner
2021-04-22 7:59 ` [bug#47615] [PATCH v2 12/12] gnu: glib: Disable failing test Efraim Flashner
2021-05-04 15:50 ` [PATCH v2 00/12] Add 32-bit powerpc support Efraim Flashner
2021-05-24 9:54 ` bug#47615: [PATCH 0/9] " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg3izywb.fsf_-_@gmail.com \
--to=cmmarusich@gmail.com \
--cc=47615@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.