From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iA5+O0lUsWALjgAAgWs5BA (envelope-from ) for ; Fri, 28 May 2021 22:36:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qKziNklUsWBzYQAAB5/wlQ (envelope-from ) for ; Fri, 28 May 2021 20:36:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C1FD11701 for ; Fri, 28 May 2021 22:36:25 +0200 (CEST) Received: from localhost ([::1]:60278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmjDT-0003kn-T6 for larch@yhetil.org; Fri, 28 May 2021 16:36:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmjD8-0003kY-EB for guix-patches@gnu.org; Fri, 28 May 2021 16:36:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43907) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmjD8-0005PO-2C for guix-patches@gnu.org; Fri, 28 May 2021 16:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lmjD7-00035I-VM for guix-patches@gnu.org; Fri, 28 May 2021 16:36:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48679] Acknowledgement (add seafile-client package providing seafile-applet) Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 28 May 2021 20:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48679 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Gabriel Wicki , 48679@debbugs.gnu.org Received: via spool by 48679-submit@debbugs.gnu.org id=B48679.162223413211818 (code B ref 48679); Fri, 28 May 2021 20:36:01 +0000 Received: (at 48679) by debbugs.gnu.org; 28 May 2021 20:35:32 +0000 Received: from localhost ([127.0.0.1]:55453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmjCd-00034X-Lh for submit@debbugs.gnu.org; Fri, 28 May 2021 16:35:32 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:37660 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmjCb-00034I-5i for 48679@debbugs.gnu.org; Fri, 28 May 2021 16:35:30 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1622234121; bh=1OW12JuQFVfbdyJy0Wxa8i7pKb4PjbwUwYibnngOOeo=; h=From:To:Subject:In-Reply-To:References:Date; b=d8UtKNirbPSvCvLZgkpQcZAnASSKxfv2KJIK1D1GqiCtxOK/y/KuU2CdtiPjQBf1A +ek+A05EnzG2q248GLs7rmPEh0BhQJoAApNOAw6Ih+L22/nCoyEdyTHQ678LoNWG+e MqRpVR8oinAhq70zYSSwv34zac3lHUor0kIIaztE= In-Reply-To: <20210527191944.zzzv34ruxfky65ll@silver> References: <20210526174751.ynfblmx64ppdl2is@silver> <20210527191944.zzzv34ruxfky65ll@silver> Date: Fri, 28 May 2021 22:35:20 +0200 Message-ID: <87sg26ppfb.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622234185; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=SZpOisMELtJubnO6RhFxeI8oqfVOaPMFsG968T43rOY=; b=kAFA/POys+NgI0agLimCv943hwlbzNPdz/VgCj5O7GVm3gM7ypV741AlEzqxzdyKdCkFMF xXzc3hPvsfxXS4xkzxJEElY+QqO+ADGNhH4mloCfEVlDlb9bimCce04xH8Qq3zlvNQEU07 JeLPdGo6Zwra0E09i7pPSM/Jv7YqRGEgkRzuOpio0c9zoSicm70JrWe6J1PRFFL7Y5q0j3 KyhzteoDQPdtPblZLTDKhyFePfEL7ou4nACGNz7rvfH1dVv0d2lYjFSsfI/tAfkba5Rqx/ EQ0YDzE1TJjozwC8WI2674nV5461AbkE1bSyfKJ/NmrwQS3hr4XipyeB2vL0FQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622234185; a=rsa-sha256; cv=none; b=P/RsL7tVpFc3x3Jpa1G9ZV6Ui39grOZtOm8n7u8KSRd8tadNdsfHOgEcpzchGA7mbnSSSz PiZ90PXXAJRPI2pnXR2YotN1+z4YRl4uwvdGoLwKujyyMaSDgnkpjZdW7oVHIQQ2Rsx6MZ 9TIQMEWmdCS5yaCg8IWg9211VW+vLQVamkxxHA1veygpvDIAfHjaQxGpP6lPwEtqEvuPLI eAqEMQGMojciLTGepl/tpgHr20PbyMPNseS7DyFtUhnQ9AUJFAl/T/N7UzAZydjS+6bsPs wa3t+yLpPsBRxq3Ck8qer5mB1z+4bhYaS+sAfVds/joJxjI5eUvgV3HPKI81GQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=d8UtKNir; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=d8UtKNir; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0C1FD11701 X-Spam-Score: -3.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: mKXxM7kuREz9 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, May 27 2021, Gabriel Wicki wrote: > From 60b4f30f4d75505dc3c2cd86c986fda582147b2d Mon Sep 17 00:00:00 2001 > From: Gabriel Wicki > Date: Wed, 26 May 2021 19:39:39 +0200 > Subject: [PATCH] add package seafile-client > > * gnu/packages/seafile.scm (seafile-client): New file. > --- > gnu/packages/seafile.scm | 103 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 103 insertions(+) > create mode 100644 gnu/packages/seafile.scm This patch should be split into three separate patches, each containing one new package. Since Seafile is related to cloud storage I think it might make sense to put the packages in (gnu packages sync), anyone else who wants to comment on this? > +(define-public seafile-client > + (package > + (name "seafile-client") > + (version "8.0.2") > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/haiwen/seafile-client") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "19z6lz34j62gazi9pd1y570jlp181cmb31rld4lfxznhkh9y2j= fc")))) > + (build-system cmake-build-system) > + (arguments `(#:tests? #f)) ; there are no tests > + (native-inputs `(("pkg-config" ,pkg-config) > + ("qtlinguist" ,qttools))) Why is the label not the same as the package name? The inputs list should preferrably be on a new line, this applied to =E2=80=98native-inputs=E2=80=99, =E2=80=98inputs=E2=80=99, and =E2=80=98pro= pagated-inputs=E2=80=99. > + (inputs `(("glib" ,glib) > + ("qtbase" ,qtbase) > + ("seafile" ,seafile))) > + (synopsis "Desktop client for cloud file storage system Seafile") > + (description "seafile-client is a desktop client for your seafile ser= ver.") > + (home-page "https://www.seafile.com") > + (license license:gpl2))) The LICENSE says Apache 2.0[1]. > +(define seafile=20 > + (package > + (name "seafile") > + (version "8.0.2") > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/haiwen/seafile") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1kizf9ifcwb3scyvimv76p0lqd69hw7l48as1xk6i3m5mv2d7j= 4p")))) > + (build-system gnu-build-system) > + (native-inputs `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool) > + ("pkg-config" ,pkg-config))) > + (propagated-inputs `(("libsearpc" ,libsearpc) > + ("libevent" ,libevent) Libraries are usually =E2=80=98inputs=E2=80=99 or =E2=80=98native-inputs=E2= =80=99, what=E2=80=99s the reason for propagating them? > + ("openssl" ,openssl) > + ("sqlite" ,sqlite))) These two packages are also usually =E2=80=98inputs=E2=80=99, would it be p= ossible to move them to =E2=80=98inputs=E2=80=99? > + (inputs `(("curl" ,curl) > + ("python" ,python) > + ("vala" ,vala))) > + (synopsis "Cloud storage system with privacy protection and teamwork = features") > + (description "Seafile is a high performance file syncing and sharing,= with > +Markdown WYSIWYG editing, Wiki, file label and other knowledge management > +features.") > + (home-page "https://www.seafile.com") > + (license license:gpl2))) LICENSE.txt says[2] This program is released under GPLv2, with the following addition permission to link with OpenSSL library. This should probably be mentioned as a comment. > +(define libsearpc > + (package > + (name "libsearpc") > + (version "8.0") I am not seeing version 8.0 on their repo[3]. > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/haiwen/libsearpc/") This repo is a fork of another repo, we usually use the upstream one if possible. > + (commit version))) Again, I don=E2=80=99t see a tag named =E2=80=988.0=E2=80=99. > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0wbx0c64xyn22rzqpl1jmdps53zjb1a0760435znsg6j88h4k7= yp")))) > + (build-system gnu-build-system) > + (propagated-inputs `(("jansson" ,jansson))) > + (native-inputs `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool) > + ("pkg-config" ,pkg-config))) > + (inputs `(("glib" ,glib) > + ("python" ,python-wrapper))) > + (synopsis "Simple C language RPC framework based on GObject system") > + (description "libsearpc (from \"library\", \"Seafile\" and \"RPC\") h= andles the > +serialization/deserialization part of RPC, the transport part is left to= users.") > + (home-page "https://www.seafile.com") > + (license license:gpl2))) LICENSE.txt says Apache 2.0[4]. Could you send a v2 patchset? [1]: https://github.com/haiwen/seafile-client/blob/master/LICENSE [2]: https://github.com/haiwen/seafile/blob/master/LICENSE.txt [3]: https://github.com/haiwen/libsearpc/tags [4]: https://github.com/haiwen/libsearpc/blob/master/LICENSE.txt =20=20=20=20 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmCxVAgVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5OJUQAJkpICj6enHuZ8FvB/EjtJvSDqqa jxZzmalwnuh1kyiZml45tZ2usI+w2w/tr+nd1dfva8uR7VdwZ/egDMpCX+R0UYsZ Mwz77SzNRZhwviDHxzhe7TUHSl7pLJF3JDGl0nSR6jjuiFbOR8Pljx0IQempCdBB ASarlRi7ZKu9DmJjKpGnFWhL+vgMGQ5mHOr9OUqQrKzIWtJPDW7S352JTiz/JW36 9pto2Jq2u2UKICbt1Z5Wjdcjd2uGVnNaa65PS/mn+qoZowlgBSaIvcWJxUSmGQvx yPsSHkMQftDzcaPxGmFxxOg1koS+U4QqXdxWxmKP0x8WBN2RhPGqSl5Xm9jkhF7F yhBSNLliKeWi9aIpDZONEGKnhmgaCUb6gleEly++rthAmr70stNkXtMdbp20Ch75 svopXlC1CG5YZiNcVMn9XsqEr4Ut2rP7/QylUZKzyTDmVwMsvaEp6vWnpsnPtNqF /EWGipS3Wn4cFRNX2TJs4SI3rVr7FLx4Cw4coSzaYGWA8Mly01n32Wj7cONX06OU pOWcn2H255BzeUsg3gnqCgQgLYh+MsmK5dhpnSmb4AO10/d38gGmQdW6TAjzwPNR FG3CsjouK3BKkDxRA+j50YqrqTD8sICx9f/5L/IukCeGoWhxeZy4iu6vJyh7Wmbx A64g/NKWR9SmOUQk =E5PY -----END PGP SIGNATURE----- --=-=-=--