From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uIN0E2zT32AFDwEAgWs5BA (envelope-from ) for ; Sat, 03 Jul 2021 05:03:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8KIrD2zT32C0DAAA1q6Kng (envelope-from ) for ; Sat, 03 Jul 2021 03:03:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 027A515AD2 for ; Sat, 3 Jul 2021 05:03:08 +0200 (CEST) Received: from localhost ([::1]:60666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzVvv-00037I-1j for larch@yhetil.org; Fri, 02 Jul 2021 23:03:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzVvq-00036l-Lf for guix-patches@gnu.org; Fri, 02 Jul 2021 23:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54229) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lzVvq-0006cc-D5 for guix-patches@gnu.org; Fri, 02 Jul 2021 23:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lzVvq-0001sg-6D for guix-patches@gnu.org; Fri, 02 Jul 2021 23:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48729] [PATCH v7 24/25] gnu: Add bitmask. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Jul 2021 03:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48729 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan Cc: jgart@dismail.de, 48729@debbugs.gnu.org X-Debbugs-Original-Cc: jgart@dismail.de, guix-patches@gnu.org, 48729@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16252813567198 (code B ref -1); Sat, 03 Jul 2021 03:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jul 2021 03:02:36 +0000 Received: from localhost ([127.0.0.1]:37542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzVvP-0001s1-Hx for submit@debbugs.gnu.org; Fri, 02 Jul 2021 23:02:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:48170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzVvN-0001rt-B7 for submit@debbugs.gnu.org; Fri, 02 Jul 2021 23:02:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzVvN-00034o-1Y for guix-patches@gnu.org; Fri, 02 Jul 2021 23:02:33 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:58576) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzVvK-0006BW-V7 for guix-patches@gnu.org; Fri, 02 Jul 2021 23:02:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=a2U5wWi2RuHOz s8Enl2EDe84ctacYl0HIgf0J4WXw9U=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=M4bvrrcBTK6grBSNrc7WiEspqiCe+qQ5O2orcf se1mHPbzTYnuWTeSdAspn0cdD3pdPySG1TB/uj5o39TPTqvo/y7gfyn7ZocOcaHgqyfknR iFMlc8bXZDYA5Mhbj/BuO82Zas7sO4HTs67JzFLwmDz3ubhlJrU0njY/x6Q7ThOYRsSe3R Ooszkfg91o6VZW9QzFz3y94mYE7aTw/PckZkIGs+mFktMWhzPOgo/GaO1xOGHpxS3C3Bfj FXlLTSPaHPvx1YEbh2GCtNeqIXHQEB1Eks1On0hXqqbOn6Y9evkQfeke5RtfnwXGNDBIA9 la5uZ0nCQNc4gDxt1a2Ye8ig== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 1bf0f477 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 3 Jul 2021 03:02:24 +0000 (UTC) References: <20210701045728.7293-21-rg@raghavgururajan.name> <20210701045728.7293-24-rg@raghavgururajan.name> Date: Sat, 03 Jul 2021 04:42:00 +0200 In-reply-to: <20210701045728.7293-24-rg@raghavgururajan.name> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87sg0wrtfi.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, TVD_IP_HEX=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 027A515AD2 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: AGMuiIqel6sS --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Thanks for this series, jgart and Rhagav! I'd hoped to do more than mere proofreading no the next two=20 patches, but my Guix refuses to build bitmask complaining about no=20 code for module (guix build qt-utils). I'm rebuilding my checkout but will have to leave before it=20 completes. Sorry: more surface level readings for now. Raghav Gururajan via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > + ;; To remove bundled thirdparty sources. > + (delete-file-recursively "branding/thirdparty") > + ;; To generate version.go file. > + (call-with-output-file=20 > "pkg/config/version/version.go" Your code is sufficiently clear not to need these comments. > + ;; For some reason this package is left out. > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((shapeshifter > + (assoc-ref inputs=20 > "go-0xacab-org-leap-shapeshifter")) > + (shapeshifter-src (string-append=20 > shapeshifter "/src"))) > + (copy-recursively shapeshifter-src "src")))) That's interesting. Did you see any upstream acknowledgment of=20 this? > + (add-after 'install 'install-continued > + (lambda args > + (apply (assoc-ref copy:%standard-phases 'install) > + #:install-plan > + ;; To install bitmask program. > +=20 > '(("src/0xacab.org/leap/bitmask-vpn/release" > + "bin" > + #:include ("bitmask")) > + ;; To install bitmask-root script. > +=20 > ("src/0xacab.org/leap/bitmask-vpn/helpers" > + "sbin" > + #:include ("bitmask-root")) > + ;; To install polkit policy. > +=20 > ("src/0xacab.org/leap/bitmask-vpn/helpers" > + "share/polkit-1/actions" > + #:include ("se.leap.bitmask.policy"))) > + args))) OK, good exercise :-) > + ;; To make bitmask-root script executable. > + (chmod bitmask-root #o776)))) Just write #o777. > + (synopsis "White-label VPN client by LEAP") I read your explanation, but I still agree with Maxime: > I'd drop "White-label" from the synopsis. It's not that it's *wrong*, but there are less metaphorical ways=20 to say the same thing, for example =E2=80=98VPN client that supports=20 multiple providers=E2=80=99. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYN/TQg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15NOQBAKg5Tccg3V92c/WK7UPWzZfQRsOw+N6EQGDjtFQj mgecAQDnVeTU/ukJmdDyOGGB5gLwZ1VBXAFzJPwGIPGsHsqkAw== =dGdk -----END PGP SIGNATURE----- --=-=-=--