[bug#48729] [PATCH v7 24/25] gnu: Add bitmask.

[Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 2497 bytes --]

Thanks for this series, jgart and Rhagav!

I'd hoped to do more than mere proofreading no the next two 
patches, but my Guix refuses to build bitmask complaining about no 
code for module (guix build qt-utils).

I'm rebuilding my checkout but will have to leave before it 
completes.  Sorry: more surface level readings for now.

Raghav Gururajan via Guix-patches via 写道：
> +           ;; To remove bundled thirdparty sources.
> +           (delete-file-recursively "branding/thirdparty")
> +           ;; To generate version.go file.
> +           (call-with-output-file 
> "pkg/config/version/version.go"

Your code is sufficiently clear not to need these comments.

> +           ;; For some reason this package is left out.
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let* ((shapeshifter
> +                     (assoc-ref inputs 
> "go-0xacab-org-leap-shapeshifter"))
> +                    (shapeshifter-src (string-append 
> shapeshifter "/src")))
> +               (copy-recursively shapeshifter-src "src"))))

That's interesting.  Did you see any upstream acknowledgment of 
this?

> +         (add-after 'install 'install-continued
> +           (lambda args
> +             (apply (assoc-ref copy:%standard-phases 'install)
> +                    #:install-plan
> +                    ;; To install bitmask program.
> + 
> '(("src/0xacab.org/leap/bitmask-vpn/release"
> +                       "bin"
> +                       #:include ("bitmask"))
> +                      ;; To install bitmask-root script.
> + 
> ("src/0xacab.org/leap/bitmask-vpn/helpers"
> +                       "sbin"
> +                       #:include ("bitmask-root"))
> +                      ;; To install polkit policy.
> + 
> ("src/0xacab.org/leap/bitmask-vpn/helpers"
> +                       "share/polkit-1/actions"
> +                       #:include ("se.leap.bitmask.policy")))
> +                    args)))

OK, good exercise :-)

> +               ;; To make bitmask-root script executable.
> +               (chmod bitmask-root #o776))))

Just write #o777.

> +    (synopsis "White-label VPN client by LEAP")

I read your explanation, but I still agree with Maxime:

> I'd drop "White-label" from the synopsis.

It's not that it's *wrong*, but there are less metaphorical ways 
to say the same thing, for example ‘VPN client that supports 
multiple providers’.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]