From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4owABoCX+GAaBwAAgWs5BA (envelope-from ) for ; Wed, 21 Jul 2021 23:54:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CEURAYCX+GD/TgAAbx9fmQ (envelope-from ) for ; Wed, 21 Jul 2021 21:54:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B7F98B094 for ; Wed, 21 Jul 2021 23:54:07 +0200 (CEST) Received: from localhost ([::1]:41976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6KAI-0005tz-Q3 for larch@yhetil.org; Wed, 21 Jul 2021 17:54:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6KAD-0005nt-VQ for guix-patches@gnu.org; Wed, 21 Jul 2021 17:54:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6KAD-0007yI-N7 for guix-patches@gnu.org; Wed, 21 Jul 2021 17:54:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6KAD-0003kl-Ii for guix-patches@gnu.org; Wed, 21 Jul 2021 17:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49610] [PATCH 0/2] Add channels field to guix-configuration Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Jul 2021 21:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49610 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 49610@debbugs.gnu.org Received: via spool by 49610-submit@debbugs.gnu.org id=B49610.162690442414401 (code B ref 49610); Wed, 21 Jul 2021 21:54:01 +0000 Received: (at 49610) by debbugs.gnu.org; 21 Jul 2021 21:53:44 +0000 Received: from localhost ([127.0.0.1]:38833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6K9w-0003kC-Cv for submit@debbugs.gnu.org; Wed, 21 Jul 2021 17:53:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6K9v-0003k1-7p for 49610@debbugs.gnu.org; Wed, 21 Jul 2021 17:53:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35572) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6K9p-0007fi-IP; Wed, 21 Jul 2021 17:53:37 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45282 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6K9p-0000Qj-Ai; Wed, 21 Jul 2021 17:53:37 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210717205819.380-1-brice@waegenei.re> <20210717210424.1921-2-brice@waegenei.re> Date: Wed, 21 Jul 2021 23:53:36 +0200 In-Reply-To: <20210717210424.1921-2-brice@waegenei.re> (Brice Waegeneire's message of "Sat, 17 Jul 2021 23:04:24 +0200") Message-ID: <87sg07e3kv.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626904447; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=AKnVqnGvYSY8xDOKryS3bgfo0LIZvWQV0IRqUf07YZU=; b=YRVmQPbS5KNMBA6PFLL+IEI1HvmTeekOo5A9od8iqUopAJE+aWDWO8YHReCf5X2Yiv5VqO wE2gazrMdd2NSwrNJlZ9RNlqBOsOmRXMzPnz36CW5TO7nwK9jmlzeqmgHmLYR+5i3rLkwH JB68mb0HKKJz5toBfCyVLJ8FhsZ3PZB6awE9czqebCkkDxtIOfB/BXbq+lBbVJfPH/PTiY HEBTGEYIplzukuF17kCzUuxaYVkB/FJX2fDajmfwbMRqtbgr28n+cbR8BSw9Vj78y7yxEC 541hBiMCgSSeti2NML57aI0KXVQ75TVXI5rXVn3BoK42qLCviFFrnkIg5YCPng== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626904447; a=rsa-sha256; cv=none; b=nSUZOY3tBiCoVbszKtNreTpq/ZEEMgSEwT2O1/JjUm6l1BkJXAuKmgvwqaUjepNqhuGX2F 7Z6I5nhIQggrCoDj/zlrhVpzKLRJpswWoq05GeXICq9xn9xgJlfnhNB3JrmrywhOcrspBV LeVQyMUOONJKtzp8QPBmhFuJ3Z5s0tFPObAJ7VSXFJrclz+h/EQblh2uR3NRnfjQec54eR gkPJfPobRIpaJrt+1c6OGUpY8xgjHicdi26RoazN9b4dlaOJsh9gWp5Ism1tqHvgbPnET6 Bj+0WIb1XCo1qzmAenaubF6c49sT9kFrb1Pf2fWNhfYMW5+ujSG4GDE/7GYV2A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B7F98B094 X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: nBzmR31vRhKu Brice Waegeneire skribis: > * doc/guix.texi (Channels): Specify that '/etc/guix/channels.scm' > contains channels configuration. > (Base Services): Document 'guix-configuration-channels' field. > * gnu/services/base.scm (setup-channels): New procedure. > (guix-configuration): Add channels field. > (guix-activation): Use 'setup-channels' procedure. [...] > +@item @code{channels} (default: @code{'()}) > +List of system channels to use, it populates > +@file{/etc/guix/channels.scm}. What about: List of channels to be used by @command{guix pull}, by default. Channels listed here are written to @file{/etc/guix/channels.scm}. ? > +;; FIXME Does this gexp should be build before boot, such as > +;; substitute-key-authorization does? There=E2=80=99s a grammatical issue :-), but also I=E2=80=99m not sure: wha= t are you worried about? > +(define (setup-channels channels) > + "Return a gexp with code to setup CHANNELS, a list of channels" Missing period. For the name, how about =E2=80=98install-channels-file=E2= =80=99 instead? > + (channels guix-configuration-channels ;list of channels > + (default '())) I wonder if it should default to =E2=80=98%default-channels=E2=80=99, for c= onsistency and least-surprise. In practice, it means we=E2=80=99d always end up creat= ing /etc/guix/channels.scm, but that=E2=80=99s probably OK. (The downside is i= f we, Guix devs, choose to change =E2=80=98%default-channels=E2=80=99 at some poi= nt: users would be stuck with the value that got written to /etc. That=E2=80=99s a v= ery hypothetical situation though.) WDYT? > + #$(if (not (null? channels)) > + (setup-channels channels) > #~#f)))) In that case, we could remove the (null? channels) special case. Thanks, Ludo=E2=80=99.