[bug#50657] [PATCH] gnu: Add vpn-slice.

[bug#50657] [PATCH] gnu: Add vpn-slice.

[phodina via Guix-patches via]

* gnu/packages/vpn.scm (vpn-slice): New variable.

diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
index 330a3271b4..4d49597564 100644
--- a/gnu/packages/vpn.scm
+++ b/gnu/packages/vpn.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2021 Domagoj Stolfa <ds815@gmx.com>
 ;;; Copyright © 2021 Raghav Gururajan <rg@raghavgururajan.name>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
+;;; Copyright © 2021 Petr Hodina  <phodina@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -432,6 +433,31 @@ file for more details.")
            ;; src/libstrongswan/plugins/des/des_crypter.c
            license:bsd-4))))

+(define-public vpn-slice
+  (package
+    (name "vpn-slice")
+    (version "0.15")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "vpn-slice" version))
+        (sha256
+          (base32
+            "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))
+    (build-system python-build-system)
+    (native-inputs `(("python-pytest" ,python-pytest)))
+    (propagated-inputs
+      `(("python-dnspython" ,python-dnspython)
+        ("python-setproctitle" ,python-setproctitle)))
+    (home-page
+      "https://github.com/dlenski/vpn-slice")
+    (synopsis
+      "Easy and secure split-tunnel VPN setup")
+    (description
+      "Minimize your contact with an intrusive VPN - split your traffic
+between the VPN tunnel and your normal network interfaces")
+    (license license:gpl3)))
+
 (define-public vpnc
   (package
    (name "vpnc")
--
2.32.0

[bug#50657] [PATCH] gnu: Add vpn-slice.

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 2124 bytes --]

On Sat, Sep 18 2021, phodina via Guix-patches via wrote:

> * gnu/packages/vpn.scm (vpn-slice): New variable.
>
> diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
> index 330a3271b4..4d49597564 100644
> --- a/gnu/packages/vpn.scm
> +++ b/gnu/packages/vpn.scm
> @@ -18,6 +18,7 @@
>  ;;; Copyright © 2021 Domagoj Stolfa <ds815@gmx.com>
>  ;;; Copyright © 2021 Raghav Gururajan <rg@raghavgururajan.name>
>  ;;; Copyright © 2021 jgart <jgart@dismail.de>
> +;;; Copyright © 2021 Petr Hodina  <phodina@protonmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -432,6 +433,31 @@ file for more details.")
>             ;; src/libstrongswan/plugins/des/des_crypter.c
>             license:bsd-4))))
>
> +(define-public vpn-slice
> +  (package
> +    (name "vpn-slice")
> +    (version "0.15")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "vpn-slice" version))
> +        (sha256
> +          (base32
> +            "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))
> +    (build-system python-build-system)
> +    (native-inputs `(("python-pytest" ,python-pytest)))
> +    (propagated-inputs
> +      `(("python-dnspython" ,python-dnspython)
> +        ("python-setproctitle" ,python-setproctitle)))
> +    (home-page
> +      "https://github.com/dlenski/vpn-slice")

Please avoid unnecessary newlines.

> +    (synopsis
> +      "Easy and secure split-tunnel VPN setup")

Likewise.

> +    (description
> +      "Minimize your contact with an intrusive VPN - split your traffic
> +between the VPN tunnel and your normal network interfaces")

The sentence lacks a subject and a period, and the single “-” should be
replaced by “---”, which is the proper Texinfo syntax.

I noticed that the README says

  It automatically looks up named hosts, using the VPN's DNS servers,
  and adds entries for them to your /etc/hosts

I don’t know about Guix System, but on NixOS /etc/hosts is read-only, so
this wouldn’t work.

> +    (license license:gpl3)))

‘LICENSE.txt’ says gpl3+.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[bug#50657] [PATCH v2] gnu: Add vpn-slice.

[phodina via Guix-patches via]

Hi Xinglu,

I checked the /etc/hosts and seems that on Guix System there aren't symlink to the /gnu/store.

$ readlink -f /etc/hostname
/etc/hostname

--8<---------------cut here---------------start------------->8---

* gnu/packages/vpn.scm (vpn-slice): New variable.

diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
index 330a3271b4..cf79bc07f8 100644
--- a/gnu/packages/vpn.scm
+++ b/gnu/packages/vpn.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2021 Domagoj Stolfa <ds815@gmx.com>
 ;;; Copyright © 2021 Raghav Gururajan <rg@raghavgururajan.name>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
+;;; Copyright © 2021 Petr Hodina  <phodina@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -432,6 +433,29 @@ file for more details.")
            ;; src/libstrongswan/plugins/des/des_crypter.c
            license:bsd-4))))

+(define-public vpn-slice
+  (package
+    (name "vpn-slice")
+    (version "0.15")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "vpn-slice" version))
+        (sha256
+          (base32
+            "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))
+    (build-system python-build-system)
+    (native-inputs `(("python-pytest" ,python-pytest)))
+    (propagated-inputs
+      `(("python-dnspython" ,python-dnspython)
+        ("python-setproctitle" ,python-setproctitle)))
+    (home-page "https://github.com/dlenski/vpn-slice")
+    (synopsis "Easy and secure split-tunnel VPN setup")
+    (description "This package allows you to minimize your contact with
+an intrusive VPN --- split your traffic between the VPN tunnel and your normal
+network interfaces")
+    (license license:gpl3)))
+
 (define-public vpnc
   (package
    (name "vpnc")
--
2.32.0

[bug#50657] [PATCH v2] gnu: Add vpn-slice.

[phodina via Guix-patches via]

ping

[bug#50657] [PATCH v2] gnu: Add vpn-slice.

[Nicolas Goaziou]

Hello,

phodina via Guix-patches via <guix-patches@gnu.org> writes:

> I checked the /etc/hosts and seems that on Guix System there aren't symlink to the /gnu/store.
>
> $ readlink -f /etc/hostname
> /etc/hostname

But it is read-only, isn't it? If so, how can the program do its stuff,
since it is supposed to modify the file?

> +        (sha256
> +          (base32
> +            "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))

Nitpick: Hash string should be on the same line as base32

> +    (description "This package allows you to minimize your contact with
> +an intrusive VPN --- split your traffic between the VPN tunnel and your normal
> +network interfaces")

Nitpick: I think English does not add spaces between "---".

> +    (license license:gpl3)))

You forgot to change the license, as suggested by Xinglu Chen.

Regards,
-- 
Nicolas Goaziou

[bug#50657] [PATCH] gnu: Add vpn-slice.

[Allan Adair]

Any progress on approving or denying this patch? Just a user wanting to
use this package ☺

bug#50657: [PATCH] gnu: Add vpn-slice.

[Vagrant Cascadian]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

On 2021-09-18, phodina wrote:
> +(define-public vpn-slice
> +  (package
> +    (name "vpn-slice")
> +    (version "0.15")

vpn-slice 0.16.1 was added in commit
79415548f7acc3afd8a79fb8ca5d103ad065a2bf.

Marking as done.

live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]