From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 7cgQJV6jamGjdQEAgWs5BA (envelope-from ) for ; Sat, 16 Oct 2021 12:03:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oCIiIF6jamHMOAAAB5/wlQ (envelope-from ) for ; Sat, 16 Oct 2021 10:03:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 91164A33B for ; Sat, 16 Oct 2021 12:03:08 +0200 (CEST) Received: from localhost ([::1]:35396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbgWx-0007R7-KQ for larch@yhetil.org; Sat, 16 Oct 2021 06:03:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbgWs-0007Qz-4h for guix-patches@gnu.org; Sat, 16 Oct 2021 06:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbgWr-00052E-SB for guix-patches@gnu.org; Sat, 16 Oct 2021 06:03:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mbgWr-0001sA-MZ for guix-patches@gnu.org; Sat, 16 Oct 2021 06:03:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49469] [PATCH] gnu: Add python-pysox. In-Reply-To: <0e7aba9bd4b403707a06597219700743@dismail.de> Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Oct 2021 10:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49469 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart Cc: 49469@debbugs.gnu.org Received: via spool by 49469-submit@debbugs.gnu.org id=B49469.16343785547156 (code B ref 49469); Sat, 16 Oct 2021 10:03:01 +0000 Received: (at 49469) by debbugs.gnu.org; 16 Oct 2021 10:02:34 +0000 Received: from localhost ([127.0.0.1]:40960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbgWP-0001rM-Nc for submit@debbugs.gnu.org; Sat, 16 Oct 2021 06:02:33 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:50216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbgWJ-0001r8-Ut for 49469@debbugs.gnu.org; Sat, 16 Oct 2021 06:02:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bnAQADN2lEF+3ra8lIpt5NsJqW78F4Y/9HCNo25ZIHc=; b=QNGIYRseVCIaULGwubCxD5VHEo YBytuOmzyvD93Nalufljg4Yz+bn48KvgFncE4pVRFFDRLaefBW9Nv/syjzoKWM2Xw9S1iBRXOE8DP oUA82S3s4KUtredb+1rluF2cwKo+RPi9pvu8Gnc5gw+NHBwwdZnIKj/dmZsWZ2fIfA6g20SOeaBTU mZ/GPyHixLyDSQvno/t7PW9JNVqfYPdh+7loAWnBJst03wPdnxjQJwWM5MKxydYmNw5pWfrh9ZyUK PmQmiei36k5MOIaoN2GyrLBqarqFro6RVXRVipRmxv0NVhFBlkQ5Po53iId6GrZDiOX83ALJO9sRj vL/643fw==; Received: from [192.168.2.1] (port=16566 helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mbgWG-000C3o-EQ; Sat, 16 Oct 2021 15:32:24 +0530 From: Arun Isaac References: <20211010061525.11302-1-jgart@dismail.de> <20211010061525.11302-2-jgart@dismail.de> Date: Sat, 16 Oct 2021 15:32:18 +0530 Message-ID: <87sfx1s2xh.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634378590; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=bnAQADN2lEF+3ra8lIpt5NsJqW78F4Y/9HCNo25ZIHc=; b=gRbsozZDIYRpslMPN8kxIDdvKG3v3/eI774h9nVpph0pcuvSWBFp/4i+wr3X1RJtNVtFjx 9zF6SLuoZdj+VOXP7capyeSGcUX+TezbG2Y4GT4k5vcadJo5hqHAFqgj/uwJVhkpq3QWUo fqx2oZ1PgK6Yh9YHlRIuNytt7GMIBpHNgL7o8AJyymNuqdBxh7UFFwa7ij1L4SmpMm9S6u BaJ+nCEgCMKfb8UwnLlbCTJqGJy5ijx9I0T3rI7KhZYrHYNylcPINv4c631B7oviaQSCft BCDgHAUjhakDOYh5UMxqu2cCXTgPqbmHTVJHVJI7faZn2hHq2ce1yNXFRoYgbw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634378590; a=rsa-sha256; cv=none; b=f+2hfGX3OLtI3J3HsIT6hQAiTVwQW8EgJB2keWJYnEnP3XYC0KBOLBW3TD5pQRx39oWDuT TGRjsiTKNzF9KLbA4B5ZMvbk1XpisKPwCjp3xseJWK7SiBQrAgKL0mcUhkBXRsSjs05kKS BzGcGq0Otcy89sNoheRdKMkT/4DvbCzUVPloCXbvXuRayHuNs90qaTbvrb06ivZKVS6nGK 3pksfqjTXr1L22o+3pBcCPEmL8xMn298WXcHAVJ3VJpTRU2hETaYvbtZ9psPrPNnRkLp9x 2/prQSKyS1rw2nY3TjvbECBKb0zAa9oUokou2en59j7uo9rF7PU2qI7ZrrxCZg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=QNGIYRse; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=QNGIYRse; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 91164A33B X-Spam-Score: -3.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: xshkrxrtWRcG --=-=-= Content-Type: text/plain Hi jgart, Thanks for the updated patch! Some feedback follows. > +(define-public python-pysox > + (let ((commit "3d0053381c24ae3490f759d4de87194b85789d36") > + (revision "0")) > + (package > + (name "python-pysox") > + (version (git-version "1.4.2" revision commit)) According to PyPI, it seems that the latest version is 1.4.1. And, I see that upstream is not tagging releases correctly in their git repo. Could you raise this issue with upstream? > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/rabitt/pysox") We should prefer the PyPI source tarball. If there is something missing in the PyPI source tarball, and that's why you are using the GitHub source, could you add a comment explaining the reason? > + (substitute* "sox/log.py" > + (("Logger\\('sox") > + (string-append "Logger\('" sox-bin)))))) I think the above substitution is not required, because in this instance 'sox' is the name of the logger, rather than the full path to the sox executable. > + (setenv "PYTHONPATH" (string-append ".:" (getenv > "PYTHONPATH"))) This setting of PYTHONPATH does not seem to be required. The tests succeed without it. > + (description > +"@code{pysox} is a wrapper around the @command{sox} command line tool. > + pysox's API offers @code{Transformer} and @code{Combiner} classes that allow the user to > +incrementally build up effects and audio manipulations. @code{pysox} also > +provides methods for querying audio information such as sample rate, > +determining whether an audio file is silent and much more.") I think @code{pysox} should be @code{python-pysox} since we are referring to the python-pysox scheme variable. Could you send an updated patch? Also, please do use `git format-patch -v2', `git format-patch -v3', etc. when sending updated patches. Thanks! Arun --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAmFqoyobHGFydW5pc2Fh Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuzVKYH/0eAAxxWYbb/TfFK37VN d73FmCBcZ9arPBuCWz+rwkeJyBEeFr8m84tScmZ7yW7CL4Ssjx788YOVWED0us7x 2ZEFDoGFN/GDWS1RVfCstqeodWuT463VTOGhNR3s4oRBhzIA0YV6cb791D7Qj2Zp 3kij2Z2hohvEtqK/HIb7x311lCF8PoJJbJl4ONT2twPLEZaVMkzCa8cgpFtYbIyr 8VaHQ5+5V/TpfcMSCJyW3okxO0tSWsfnkTTz7+rDYkzV80ZFHPMFEBVXMlWWMs3n PlIHCrhF/x0cu+G6qjXnYlJt+yLSS6tJuNWbNroW0twUgozIPEiD3Nz7xehRqsnu p08= =HsEa -----END PGP SIGNATURE----- --=-=-=--