From: Arun Isaac <arunisaac@systemreboot.net>
To: jgart <jgart@dismail.de>
Cc: 49469@debbugs.gnu.org
Subject: [bug#49469] [PATCH] gnu: Add python-pysox.
Date: Sat, 16 Oct 2021 15:32:18 +0530 [thread overview]
Message-ID: <87sfx1s2xh.fsf@systemreboot.net> (raw)
In-Reply-To: <0e7aba9bd4b403707a06597219700743@dismail.de>
[-- Attachment #1: Type: text/plain, Size: 1988 bytes --]
Hi jgart,
Thanks for the updated patch! Some feedback follows.
> +(define-public python-pysox
> + (let ((commit "3d0053381c24ae3490f759d4de87194b85789d36")
> + (revision "0"))
> + (package
> + (name "python-pysox")
> + (version (git-version "1.4.2" revision commit))
According to PyPI, it seems that the latest version is 1.4.1.
And, I see that upstream is not tagging releases correctly in their git
repo. Could you raise this issue with upstream?
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/rabitt/pysox")
We should prefer the PyPI source tarball. If there is something missing
in the PyPI source tarball, and that's why you are using the GitHub
source, could you add a comment explaining the reason?
> + (substitute* "sox/log.py"
> + (("Logger\\('sox")
> + (string-append "Logger\('" sox-bin))))))
I think the above substitution is not required, because in this instance
'sox' is the name of the logger, rather than the full path to the sox
executable.
> + (setenv "PYTHONPATH" (string-append ".:" (getenv
> "PYTHONPATH")))
This setting of PYTHONPATH does not seem to be required. The tests
succeed without it.
> + (description
> +"@code{pysox} is a wrapper around the @command{sox} command line tool.
> + pysox's API offers @code{Transformer} and @code{Combiner} classes that allow the user to
> +incrementally build up effects and audio manipulations. @code{pysox} also
> +provides methods for querying audio information such as sample rate,
> +determining whether an audio file is silent and much more.")
I think @code{pysox} should be @code{python-pysox} since we are
referring to the python-pysox scheme variable.
Could you send an updated patch? Also, please do use `git format-patch
-v2', `git format-patch -v3', etc. when sending updated patches.
Thanks!
Arun
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]
next prev parent reply other threads:[~2021-10-16 10:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 18:45 [bug#49469] [PATCH] gnu: Add python-pysox jgart via Guix-patches via
2021-07-08 19:35 ` jgart via Guix-patches via
2021-10-09 15:20 ` Arun Isaac
2021-10-10 6:15 ` [bug#49469] jgart via Guix-patches via
2021-10-10 6:15 ` [bug#49469] [PATCH] gnu: Add python-pysox jgart via Guix-patches via
2021-10-16 10:02 ` Arun Isaac [this message]
2021-10-16 10:05 ` Arun Isaac
2021-11-24 16:25 ` Arun Isaac
2021-11-25 4:33 ` jgart via Guix-patches via
2021-11-25 4:46 ` jgart via Guix-patches via
2021-11-29 16:12 ` bug#49469: " Arun Isaac
2021-11-25 4:42 ` [bug#49469] [PATCH v3] " jgart via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfx1s2xh.fsf@systemreboot.net \
--to=arunisaac@systemreboot.net \
--cc=49469@debbugs.gnu.org \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.