From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eIk6LZrAbmGpQQEAgWs5BA (envelope-from ) for ; Tue, 19 Oct 2021 14:56:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YF3dKJrAbmGLTwAAbx9fmQ (envelope-from ) for ; Tue, 19 Oct 2021 12:56:58 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1FE6421DED for ; Tue, 19 Oct 2021 14:56:58 +0200 (CEST) Received: from localhost ([::1]:60136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcofp-0002aC-6F for larch@yhetil.org; Tue, 19 Oct 2021 08:56:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcofL-0002a4-Qg for guix-devel@gnu.org; Tue, 19 Oct 2021 08:56:27 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:30074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcofJ-0000Sw-JT for guix-devel@gnu.org; Tue, 19 Oct 2021 08:56:27 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3AogQHJ6w8Z/Z0LlKwPAQYKrPwzr1zdoMgy1kn?= =?us-ascii?q?xilNoNJuH/Bw8Pre5sjztCWE8wr5N0tQ/exoVJPqfZqYz+8T3WBzB8bbYOCFgh?= =?us-ascii?q?rPEGgK1+KL/9SjIULDH4VmuZuIHZIVNDS9NykCse/KpC+DeuxQpeWvweSQq96b?= =?us-ascii?q?4HdrQw1wcrph6BoRMHf4LmRGADBpPN4aGIr03LslmxOQPU04V4CYCmlAf8Wrnb?= =?us-ascii?q?32vaOjWhIYARs69QmJijuy+PrWGwWVty1+bxp/hYsY1AH+/TDE2g=3D=3D?= X-IronPort-AV: E=Sophos;i="5.84,326,1620684000"; d="scan'208";a="396383287" Received: from 91-160-117-201.subs.proxad.net (HELO ribbon) ([91.160.117.201]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 14:56:20 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: Tricking peer review References: <874k9if7am.fsf@inria.fr> <86ee8hfm1k.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?utf-8?Q?Vend=C3=A9miaire?= an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 19 Oct 2021 14:56:20 +0200 In-Reply-To: <86ee8hfm1k.fsf@gmail.com> (zimoun's message of "Tue, 19 Oct 2021 10:36:55 +0200") Message-ID: <87sfwx896z.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=192.134.164.104; envelope-from=ludovic.courtes@inria.fr; helo=mail3-relais-sop.national.inria.fr X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634648218; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9cs3JmSPdqVsav1stBzcFETB+9bT2S6L0cah0xiWBc4=; b=GgM1YZ8xUydh8EPOz3yWsRXmJY6yQQmVxK0gCXs04JN/BYUXTu40CosQEeK8kZPTllMVkv 1kmCSszZWiLuc8gDEIntSNbub/3UhI7rzYe+SbA1S33miuyP8iDsOJYkw0CaAEwf83MHX9 N5pElWSVzm1C/2unAnQSyGOtMBASE1zDomLfaeRskEWlxlkvDVPtb+8ZFtKFAWguyLfUje JA0wWWt0zrHPZh1tA2et4jxq5bbGd0WVb1aa0tWuPDOaeq/mEMOr71Hrf2boDKw+tSFm7v y63rTeUEOpRHbRZ+IApyxPhd9ONDrdrumPDyzQZoNw6uQ3E455L1MjlbOeiqEQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634648218; a=rsa-sha256; cv=none; b=HfrHLao0jWa7QBnJjMN6jQZfbKlX8oHzUd3rH6gNIW2QrllbCX3INZeQMVR1GpFxGS/Vvo YGASjL5HjhV5UN48PKPNapRUkwn59fXh+hSZSMUNVfY8HSZ97MXO0MKfHtrRDUptiInVU8 FitdoYMNYr7A99wU8f0X0e39yr1x+5zE8aGN9/3SX7y+5y51VdhBO/xKrePDORwLgzS1Wd N27n4V3cW1CqSH1+iBX2EJCv5xyZSyOsCmjsDhsEgsud1iha1LCuU8mpe//yxOqdXSV6qK IuT6CK4vmw8ukrXPR5YaoLeLFxsjkN3Mu6x6fLZRKBTY0dt3BOu1g3RMn+9GKA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 1FE6421DED X-Spam-Score: -2.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: otwZoTw8MaWh Hi, zimoun skribis: > I agree with a minor comment. From my opinion, not enough patches are > going via guix-patches and are pushed directly. > > For instance, the =C2=ABCommit policy=C2=BB section says =C2=ABFor patche= s that just > add a new package, and a simple one, it=E2=80=99s OK to commit, if you=E2= =80=99re > confident (which means you successfully built it in a chroot setup, and > have done a reasonable copyright and license auditing).=C2=BB > > And from my point of view, new packages should *always* go via > guix-patches, wait 15 days, then push if no remark. It lets the time > for the community to chime in. And if not, it just slows down for 2 > weeks. Three comments: (1) two weeks for a trivial Python/R/C package (the =E2=80=9Csimple one=E2=80=9D rule above) can be a lot, (2) committers are b= y definition trusted to not mess up and to clean up behind them, and (3) when a simple package is pushed there=E2=80=99s after-the-fact peer review in prac= tice (sometimes I reply to guix-commits notifications, for example.) I think it=E2=80=99s about finding the right balance to be reasonably effic= ient while not compromising on quality. Ludo=E2=80=99.