From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sAUtJ9I+FmJCZQAAgWs5BA (envelope-from ) for ; Wed, 23 Feb 2022 15:04:02 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CNF1JNI+FmLhfQAA9RJhRA (envelope-from ) for ; Wed, 23 Feb 2022 15:04:02 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6726B1EA39 for ; Wed, 23 Feb 2022 15:04:02 +0100 (CET) Received: from localhost ([::1]:42222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMsFN-00042a-54 for larch@yhetil.org; Wed, 23 Feb 2022 09:04:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMs0w-0004ts-1D for guix-patches@gnu.org; Wed, 23 Feb 2022 08:49:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMs0v-000545-Kh for guix-patches@gnu.org; Wed, 23 Feb 2022 08:49:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMs0v-0004oH-Ke for guix-patches@gnu.org; Wed, 23 Feb 2022 08:49:05 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54088] [PATCH 0/2] julia-build-system: Add missing julia-pkg-deps Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 23 Feb 2022 13:49:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54088 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 54088@debbugs.gnu.org Received: via spool by 54088-submit@debbugs.gnu.org id=B54088.164562409318318 (code B ref 54088); Wed, 23 Feb 2022 13:49:05 +0000 Received: (at 54088) by debbugs.gnu.org; 23 Feb 2022 13:48:13 +0000 Received: from localhost ([127.0.0.1]:44368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMs04-0004lH-Sr for submit@debbugs.gnu.org; Wed, 23 Feb 2022 08:48:13 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:43904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMrzm-0004gF-5E for 54088@debbugs.gnu.org; Wed, 23 Feb 2022 08:47:54 -0500 Received: by mail-wr1-f45.google.com with SMTP id s1so13319353wrg.10 for <54088@debbugs.gnu.org>; Wed, 23 Feb 2022 05:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vqEXpo0Mkmx2Twv+KQtp8piaX80PFMvjdhabB6MvNtY=; b=PwNYFmLnjBGfmZeoSV9bEHIYYcgnkM01MMqINc8AwRokypN9opbH/dmflQCVcHqnA0 Z1Ab882c+fryTj/DoyxxRxvU6hM4sTgidyMtJNt5ITeWLGlJl9y5oU87qVN1T2NbcMbN dO6NFMY3xy+MMfaQtpOSXlnm2gE8ACbckdDq4JzLXlD42oeDhWLWUEb3U8lyUIHiSoBX lPK5jeLm7KRqdcQ0KgoaXOzdqd1apmQTy1yEiy3lq91sIITNPpZWTHITOrh7gVzy3q+x XjQf/eaRWxHOnO7irsADecCET5QpkiIn+NppccqFPe7A81f6v/uYa2yTUXZl+aKshis1 3OGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=vqEXpo0Mkmx2Twv+KQtp8piaX80PFMvjdhabB6MvNtY=; b=fDwubJZeK/AJNgMRt+CIW1h6sb3ADMrEtuyOaQAN1EZpFxfsgzkf9GGa7fAd5Ore4F sHr8emliK6+/iVoh6VdhCHBd5+9RA939pQm+vwLG9fxK8svcVGKOjtmjPK3KS0RlNVub 2A87YlMrzs9AWJTX/sJYGHLyzBgckzRaXKo5g7pcc3eD2m+EcJDm5edRRywO3XaIkmcb 7ju7JtKKgbGYDeZOb+UvFo64jYn/nxk1UOzBN0Apnea4EcYz5THRV2ufeHmTG7qNBZ/u CcqpKuXv26+TBRziMI7KWT+4rNGx1LGo18hB7qzPlaoL54cJxDBlVZ4kPyADIdc0YdPX n0UQ== X-Gm-Message-State: AOAM531tBHK8abHBqHRwVwFQtoByng8sT6UVwn3U/1jcr21K8Cvicto/ JiFNC5gqbYXA8oq3DreuHly2CCeQ0UY= X-Google-Smtp-Source: ABdhPJwaZUVFZxlOahqd6CaFqld03HFj071UmwsEhyXw7H3eJNMmx0lWCTSDMxlhonDW2D15hP8/nA== X-Received: by 2002:adf:f804:0:b0:1ed:c0b4:c597 with SMTP id s4-20020adff804000000b001edc0b4c597mr533636wrp.66.1645624068628; Wed, 23 Feb 2022 05:47:48 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id s7sm22698894wri.5.2022.02.23.05.47.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 05:47:48 -0800 (PST) From: zimoun References: Date: Wed, 23 Feb 2022 14:44:43 +0100 In-Reply-To: (Efraim Flashner's message of "Mon, 21 Feb 2022 14:47:05 +0200") Message-ID: <87sfs9hf3o.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645625042; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=vqEXpo0Mkmx2Twv+KQtp8piaX80PFMvjdhabB6MvNtY=; b=KT0hf1U0gWGzRbJ6IV70YkN5wdy32JGTmgUuxHFYIbOX1CPfTCGgOVALBsJWQThM3OH8NO vYrrjtc4VEBDHxOVFTyByBYsVYLJw1JS7JH9eMK7Oyzsr5PglxpYknFx7XYaFOQflcA17l Cm4m0ShrT8ow75oTwcgOTf8L/mVTTkEMSiWVrQ9VBCnAv9L11sbXsxDAes8gjk/daUHco2 qUBgah47jiEqxyup07K9jJ3ZE/ASTIud/my5qZfeplTlXoH6U2TlWRqE6RjVVivfHFTIPb hntUI7g+XPO+Hse4aXFcOJ2+iyhQ2tmbJbna7jWk8Y1WVGVspRUcX2IHb1OREA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645625042; a=rsa-sha256; cv=none; b=WQorxXB4m5LNY5ZWkXhbqygZNLwsUai4ZctlHPu5/0QVeOVpYjDqBP6cUWEVu5qOJDh8Ns w57+nbKGHOZZ0EJ7aJDtMqOOF7p6tY0ZCUzSAGFetHHikzOPbxk0wVIbkufpw/fsb3m8z5 9Ya0UBqkV3AEEQqaD9mvq8IKSukOhixqDcgsjrq5Dwp9knB1V1fogJwREym7+UElPVh4MS 7tI6bYt8DHuHCZJev/v9tPL2kPsvLOvEPsfhoQqmD4HFz1DL2LAstqbnxT2debHZld9cv/ H8FHPe33PN0osviZgxa/2xURLm77GxV2kVhBZYxJSy3CI4xr9zFZ8as1RXwadw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PwNYFmLn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PwNYFmLn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6726B1EA39 X-Spam-Score: -3.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: ncJnFAJvQtgX Hi Efraim, On Mon, 21 Feb 2022 at 14:47, Efraim Flashner wrote: > It turns out we didn't expose julia-package-dependencies in the > julia-build-system, making the created Package.toml incomplete. This > corrects the omission and fixes the one package where it is manually > added. All LGTM. But I take this opportunity to uniform, as discussed: It's definitely the new pattern we're using now. I suppose it's not really necessary here, but having more instances of it throughout the codebase also makes it easier to search for examples when others are looking to use or modify gexps. The first patch of the series uses G-exps. Note that it does not imply any rebuild. The Julia build system is adapted for the new 'julia-package-dependencies' and so it requires the minor tweak to default with ''() instead of #f; otherwise it crashes for some packages. Since we are at it, I fix a minor typo of how Julia uses --procs. Other said, currently "guix build julia-media -c 0" works but not "guix build julia-media -c 1" which crashes. Because the build system modifications imply a full Julia rebuild, let take the opportunity to remove the trailing #t. It is done package per package because each modified package need a rebuild so it eases to follow, IMHO. They can be squashed otherwise. Cheers, simon