From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KLoBDfa7HGLSpQAAgWs5BA (envelope-from ) for ; Mon, 28 Feb 2022 13:11:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QF/7Bfa7HGL2SAEAG6o9tA (envelope-from ) for ; Mon, 28 Feb 2022 13:11:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B825C34F37 for ; Mon, 28 Feb 2022 13:11:33 +0100 (CET) Received: from localhost ([::1]:34000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOesG-0002Ek-Qt for larch@yhetil.org; Mon, 28 Feb 2022 07:11:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:32986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOeWU-0005zu-GR for guix-patches@gnu.org; Mon, 28 Feb 2022 06:49:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOeWU-0005St-7X for guix-patches@gnu.org; Mon, 28 Feb 2022 06:49:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOeWU-0000tG-68 for guix-patches@gnu.org; Mon, 28 Feb 2022 06:49:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54069] [PATCH v2 3/4] gnu: libosinfo: Unbundle usb.ids, pci.ids. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Feb 2022 11:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54069 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: John Kehayias , 54069@debbugs.gnu.org, Brendan Tildesley , Maxim Cournoyer Received: via spool by 54069-submit@debbugs.gnu.org id=B54069.16460489343403 (code B ref 54069); Mon, 28 Feb 2022 11:49:02 +0000 Received: (at 54069) by debbugs.gnu.org; 28 Feb 2022 11:48:54 +0000 Received: from localhost ([127.0.0.1]:60317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOeWL-0000sp-Oc for submit@debbugs.gnu.org; Mon, 28 Feb 2022 06:48:53 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:60638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOeWJ-0000sb-Pc for 54069@debbugs.gnu.org; Mon, 28 Feb 2022 06:48:52 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 23D6226E; Mon, 28 Feb 2022 12:48:46 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pf2f7zWjmnIh; Mon, 28 Feb 2022 12:48:44 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id EAA8DBD; Mon, 28 Feb 2022 12:48:43 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220226043238.2657-1-mail@brendan.scot> <20220226043238.2657-3-mail@brendan.scot> <190017101.145924.1645925822107@office.mailbox.org> <58cd826af583022698ee91d0c2a25526ccb27756.camel@telenet.be> <87r17ot35k.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 10 =?UTF-8?Q?Vent=C3=B4se?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 28 Feb 2022 12:48:43 +0100 In-Reply-To: (Maxime Devos's message of "Sun, 27 Feb 2022 23:17:46 +0100") Message-ID: <87sfs3dxes.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: + X-Rspamd-Server: hera X-Rspamd-Queue-Id: 23D6226E X-Spamd-Result: default: False [1.40 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_CC(0.00)[brendan.scot,debbugs.gnu.org,protonmail.com,gmail.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com,protonmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_FIVE(0.00)[5]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646050293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=eGoBwAYr6AwsvJdhxinNV9DrYeYlAktiS++XhApIrHE=; b=t8a4n7aWiGDBRh72ZHJpy7hx3gd99WloafkDUuhDBCk2IPcJYYMegjW/Rj0UYVLWG9UYD3 qhtCNWGUUp03gNvXvp+t3hZIjZ9TqIoEkkhpf4VvPxPesAR3VLu4G9BHomDN/gsQs+OzgK MSThRPXLFt1h0zd6mmqdlSxn9TQDB5u0VAXWuwH3462Uu3ZXxww4nytZtMTvixytVYXAMT Cn97ah4duyfL9uvVmpn9DDHIwkd/StTpipopjiC9BBPwPp+qBCQlTPjDMqTp5h+N3SxDX3 6Nk1YY3KPP90gmPGmHCOJGBLpaTaH0/kwFLGTx0qaMKUddYaWoy2fEKT3ULiXQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646050293; a=rsa-sha256; cv=none; b=nRF9XeDicW0RoRpI+An06lBzzjPlu1G0rvEncV2lrzDw9cFIHOswbImvCoVwt8yU/MoERB KV/HkOcX2mAk9gqsmwsa5BEcZDN4DLFDbuwlB3MeqceR5RbxBISkQTGx4DkRcRd1MsV7HT px/UYQXl0UegyKZIS5SL6/JCv9kKBDm64mPIbyhZKjRJ8czQvPIpbrc9xK0OV/hghp9Z57 dAylqvFPzB3DeE8yOr3I6YiGXoNzT+gvGMm2KqBkXVH5l82SI9+/4V2LWiQK91heriatpL QN/vZanA8K7EO0mLoiSmcsDYpvYfqMQSfRxq2p8R9YTZp5rWuWea7lDNptec0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.10 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B825C34F37 X-Spam-Score: -3.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: n5LLt5TztucL Hi! Maxime Devos skribis: > Ludovic Court=C3=A8s schreef op zo 27-02-2022 om 22:23 [+0100]: >> Can=E2=80=99t we instead do: >>=20 >> =C2=A0 #~(let* ((usb.ids (string-append #$hwdata:usb "/share/hwdata/usb.= ids")) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (pci.ids (s= tring-append #$hwdata:pci "/share/hwdata/pci.ids"))) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=80=A6) >>=20 >> ? > > We could, and that's what the original v2 patch did. > However, this prevents package transformations: Right, but maybe that=E2=80=99s good enough?=E2=80=A6 Otherwise, we can do: #~(let* ((usb.ids (string-append (ungexp (this-package-inputs "hwdata") "usb") =E2=80=A6))) =E2=80=A6) [...] > Ludovic Court=C3=A8s schreef op zo 27-02-2022 om 22:23 [+0100]: >> I think this is equivalent to: >>=20 >> =C2=A0 #~(let* ((inputs #$(input-tuples->gexp (package-inputs this-packa= ge))) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=80=A6) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=80=A6) >>=20 >> Am I right? > > That's what I suggested initially: > >> > #~(let* ((inputs #$(input-tuples->gexp (package-inputs this- >> package))) >> > (usb.ids (search-input-file inputs >> "/share/hwdata/usb.ids")) >> > (pci.ids (search-input-file inputs >> "/share/hwdata/pci.ids"))) >> > (list (string-append "-Dwith-usb-ids-path=3D" usb.ids) [...])) >> >=20 >>=20 > > However, that lead to errors -- strings like # > appeared in the builder. Hmm weird. Thanks, Ludo=E2=80=99.