From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GP3vE7WRNGI8EwAAgWs5BA (envelope-from ) for ; Fri, 18 Mar 2022 15:05:41 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UEKJDLWRNGI66AAAG6o9tA (envelope-from ) for ; Fri, 18 Mar 2022 15:05:41 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C29BE3A58B for ; Fri, 18 Mar 2022 15:05:40 +0100 (CET) Received: from localhost ([::1]:42706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVDEZ-0003rE-2U for larch@yhetil.org; Fri, 18 Mar 2022 10:05:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVCf9-0000Cd-9K for guix-patches@gnu.org; Fri, 18 Mar 2022 09:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVCf9-00036T-0Z for guix-patches@gnu.org; Fri, 18 Mar 2022 09:29:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVCf8-0002cM-Hm for guix-patches@gnu.org; Fri, 18 Mar 2022 09:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Mar 2022 13:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54368 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 54368@debbugs.gnu.org Received: via spool by 54368-submit@debbugs.gnu.org id=B54368.164761012610021 (code B ref 54368); Fri, 18 Mar 2022 13:29:02 +0000 Received: (at 54368) by debbugs.gnu.org; 18 Mar 2022 13:28:46 +0000 Received: from localhost ([127.0.0.1]:56531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVCer-0002bY-QX for submit@debbugs.gnu.org; Fri, 18 Mar 2022 09:28:46 -0400 Received: from mail-qt1-f172.google.com ([209.85.160.172]:40807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVCep-0002bJ-GO for 54368@debbugs.gnu.org; Fri, 18 Mar 2022 09:28:44 -0400 Received: by mail-qt1-f172.google.com with SMTP id i4so6792658qti.7 for <54368@debbugs.gnu.org>; Fri, 18 Mar 2022 06:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XGM5eteU5P94+x7m0TQ0bCla0vt4ggrSc97FAXtuSHY=; b=FCQJQ6sx7hoqc65h7LgGKQMF5tyZRrrQxlaBGojhOaoftx4GQKvDsOAVSoX/+6UzXn pB74TStSt+nZLGEFGRz+0L1iGho/3LjkUv+UnS2O+djs2M58sGAD/XZjscHJ3ZVCScz0 TIj0ccIsXV35gtNPz4s8R6Px6aTPb/dkRTq3/IvF6N7+6Bp4Uok+yIc4kdjTVJBrLYz6 pwy76Tceirt8jbeGuA3dwUEjytYQEwnzDTX1scjEfA+hP8XFRw3LM65YUoU3zRqSArC2 2OfeePXumUHTFpGlcBiZtr8EOpQ0nDYl2bPrKFAE4k0fUIskJe2G69bpEJTi6gPY4Yge aLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XGM5eteU5P94+x7m0TQ0bCla0vt4ggrSc97FAXtuSHY=; b=EW0+34CuTFW9kQluXU+214tEGBeSJo11zTH5JqTyIDAJwBziueZwG9yk5Xz507Z9Wn 5YTYexL2sBBNVvwr/W7sVGw5JxFVOjulsvH1TZ/HukVVRsmOfGWEmVjJN+w7UXuiK5Fd 08zmV9m7cflEm7BUW8YOvg7BjKHM20A985sOn9hEAhOvjM/SokeTLbhbzX911wSJz5bC 2JXOTj3Tue6/HHu+u75yPVhwLUUutAFOZlmietQ9ya6QQvrWDPfLplBa0uNkf52q50f4 7vuQqWRlqAhDpwJZfzbM9kQe8rvmJ1fW/hSLHd+G3hQf1AkO0yylbjZOmxZ8ZDG6e4LU gMeQ== X-Gm-Message-State: AOAM532c1euoH+45jKyG9DLHMGfZ1M5mct951spSeP9IpxswIDvtnwC0 BWnpKxfiVgxMahowe34Kp6bW2QGKYE83nA== X-Google-Smtp-Source: ABdhPJwLfQoEsNNTe2hXFUAsuAFMf/Vp2QwntyvolFuAqZuiA4aBOE/NL/kbaUdBCXfZB21XtsXr1Q== X-Received: by 2002:a05:622a:4d3:b0:2e1:bc11:3b97 with SMTP id q19-20020a05622a04d300b002e1bc113b97mr7334192qtx.189.1647610117673; Fri, 18 Mar 2022 06:28:37 -0700 (PDT) Received: from hurd (dsl-10-132-234.b2b2c.ca. [72.10.132.234]) by smtp.gmail.com with ESMTPSA id x19-20020a05620a14b300b0067e09a47e39sm3736867qkj.34.2022.03.18.06.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 06:28:37 -0700 (PDT) From: Maxim Cournoyer References: <20220313054356.17578-1-maxim.cournoyer@gmail.com> <20220313054356.17578-3-maxim.cournoyer@gmail.com> <87bky38upu.fsf_-_@gnu.org> Date: Fri, 18 Mar 2022 09:28:36 -0400 In-Reply-To: <87bky38upu.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Fri, 18 Mar 2022 10:40:13 +0100") Message-ID: <87sfrf4cfv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647612340; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=XGM5eteU5P94+x7m0TQ0bCla0vt4ggrSc97FAXtuSHY=; b=uEjP4QwHjW9mmCpVR8M/ZVQIbKbQy7qb9Rhal6ffmQDv+0J409RtMT+Q2KYZuvyq3Jj7QW jhr6QIMuqlbi6TyCE/HLCwqzVh2/+fwmlIdXJWsB5jgVDt4I22/EAQbMl+VI4n0iRL6LCy UY6VyF+W+d2CCOgo2GhcKSSFBgiT+Df2ytiP8X2lWcqlGAoM5wbJvlQpM+4f5PNxOTW0Q/ Y+VzIFZbqpCPfMgS4Si6u7hSeU43WVoskoZwrGD8isclJXx83ivsvyqYnrjCcTlgEzoymR ApvcrOnfmFeQM3E0+5PTDrrC6Bymdm033F2cvSQZMowTZUtTcrQe5r35LPpKSw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647612340; a=rsa-sha256; cv=none; b=iVEQEQ8FuONvDsHH2cWIXpzpLFRU7Ko6HBI91Q6nZAdpIlTg7h5qoXPehZCUD66PKWW1qZ 2TmI7YfB2uekrq3m3txNI3KojgN/BoHP6pbsbZ0Az8rBsuYuwjegn3TIKqbAXxKTFZ2QLo dbDH5atZhk0sRtzCcDcuqJFK5u7V4BRNr4QI8U0QfWsyO0bmxWQqWo6QkYEsPnBcSlYJfj 7ozj93aDx6r19bfQcui2LxkfAgq3UDI9IvAyDaVaiBUFC/sAGgX5UUvVGoyFomh/ODE4qV nib9Ej8H7PX/RwN5lma9lriE8+wJoG4euxV3Lsvs66Ub+BdRiJd1bG4W1mYVRA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=FCQJQ6sx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=FCQJQ6sx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C29BE3A58B X-Spam-Score: 5.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: awFVPxIlZBwi Hi Mathieu, Mathieu Othacehe writes: > Hello Maxim, > > This looks great! I created a dedicated jobset here: > https://ci.guix.gnu.org/jobset/wip-btrfs-raid-tests to check everything > is still running fine. > >> +OS to install TARGET-OS. Return the VM disk images of TARGET-SIZE bytes >> +containing the installed system. Unless providing OS, the PACKAGES will be >> +added to the packages defined in INSTALLATION-OS (from (gnu system install)). >> +NUMBER-OF-DISKS can be used to specify a number of disks different than one, >> +such as for RAID systems." > > I'm having troubles understanding the "Unless providing OS" part of the > sentence, but that's also because this mechanism of adding packages to > the default OS definition is tricky. > > Maybe we should augment the OS definition with those packages > unconditionally in the body of the "run-install" procedure. Yes, it's a bit weird that we accept an argument whose only purpose is to affect the default value of another argument! I'll try implementing your idea; I also think it's better. Thank you! Maxim