From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YBXqExO5iWLP/QAAbAwnHQ (envelope-from ) for ; Sun, 22 May 2022 06:16:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iIDkEhO5iWKeZAEAG6o9tA (envelope-from ) for ; Sun, 22 May 2022 06:16:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BD8686250 for ; Sun, 22 May 2022 06:16:18 +0200 (CEST) Received: from localhost ([::1]:41414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nsd0r-0000H9-4g for larch@yhetil.org; Sun, 22 May 2022 00:16:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsd0c-0000Ga-Gy for guix-patches@gnu.org; Sun, 22 May 2022 00:16:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49487) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nsd0c-0002hW-43 for guix-patches@gnu.org; Sun, 22 May 2022 00:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nsd0c-0003gS-0S for guix-patches@gnu.org; Sun, 22 May 2022 00:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#46182] [PATCH] lint: Add 'check-git-protocol' checker. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 May 2022 04:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46182 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , GNU Debbugs , 46182@debbugs.gnu.org Received: via spool by 46182-submit@debbugs.gnu.org id=B46182.165319293414122 (code B ref 46182); Sun, 22 May 2022 04:16:01 +0000 Received: (at 46182) by debbugs.gnu.org; 22 May 2022 04:15:34 +0000 Received: from localhost ([127.0.0.1]:43384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsd08-0003fa-8F for submit@debbugs.gnu.org; Sun, 22 May 2022 00:15:34 -0400 Received: from mail-qv1-f51.google.com ([209.85.219.51]:36376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsd04-0003fH-GC; Sun, 22 May 2022 00:15:31 -0400 Received: by mail-qv1-f51.google.com with SMTP id y20so9967055qvx.3; Sat, 21 May 2022 21:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Xx7tDCqXlx+1GCkXRSrp3UcQx8j2bWZAuR4xvHhBGCI=; b=f7A63CWSvSMEkmjD4IsTeHZ/g1DvsYHf/wkCO26MfPq+RY5xemzmRx6w5xDWnw78EO 59wr2EYlBuIppw7eMsR0Awv8Wcd6606TNJmoMLPGx1EcYF8uWqxf1byyDVVgGmt3bcp+ FyvJw1jLiWf/NAvx/tZGnVVtvJ7HolIG+VPqODd1kzXMLZ7ZHZD7kSexmVAJQ1lNEVL/ tZXj4zWOKRimDzGND6GHO8YdjJI83oz0VfCNO85lcUynanP1LCWupmS9QNMyd5J4KUny PLsXHmUWhAq8Zt6H58JOGYf6F9xr27nDWTosPQxQFNqrxQT5QII5lEgVhhaBYDPLjP8m q86Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Xx7tDCqXlx+1GCkXRSrp3UcQx8j2bWZAuR4xvHhBGCI=; b=rdcAwCJ/w6fP+Shb5p2PT7YiUJg4tAgsxVoy9OF9zdHuz5LG8DoYhGzc68xB5jwsIt RjnrUZIO3uF8sc0hjcfVTocc++Ctqud44BWNNL8r5iNsHArG0LQugeVVVilB9k0u52QI gXSdBnUy0NBmHLdDm7fc3erwfdcj4REWlYeNbesvj/J3+AdGU1fxmN+Gy6m4STtNL8ik MIAwhESaCyhjpuPhDAHxPCu3QAHVh2zUX8vWAcdWWnPV5/k3iN36UMJMnef+KzzaR23o Yu3zGVVZdvXiQxoj7AoWgY0sIWB4ftdwO0Xy4D0OOnivV9HFun//39NFC7/TsOFfmTls vQQQ== X-Gm-Message-State: AOAM530KnmfhYvuray/TTJcQPLsBexwPinrP7Ic9v7WsllkWq24XI2sI g4AoUSA3KnA3L4CgeUI54e/6Qle+wnmtvmMN X-Google-Smtp-Source: ABdhPJzI4KYH2sfH8jjUgUK3mDcQpF7IArCPqaPj4wwCeAKthWWP26bU1rNOSpCWd1iaOEF/dtpbwQ== X-Received: by 2002:ad4:41c3:0:b0:461:d481:b540 with SMTP id a3-20020ad441c3000000b00461d481b540mr13307981qvq.108.1653192922949; Sat, 21 May 2022 21:15:22 -0700 (PDT) Received: from hurd (dsl-152-80.b2b2c.ca. [66.158.152.80]) by smtp.gmail.com with ESMTPSA id l26-20020ac84cda000000b002f934764791sm416888qtv.80.2022.05.21.21.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 21:15:22 -0700 (PDT) From: Maxim Cournoyer References: <87zgz9uxwu.fsf@gnu.org> Date: Sun, 22 May 2022 00:15:21 -0400 In-Reply-To: <87zgz9uxwu.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 11 Mar 2021 23:29:37 +0100") Message-ID: <87sfp26w4m.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653192978; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Xx7tDCqXlx+1GCkXRSrp3UcQx8j2bWZAuR4xvHhBGCI=; b=XXGX+XvvuDzKWfE3rIjJxnKsM0NGAVIEJUzQ/3kPYc6KX8QFsF8XbxoiRXc0N7yxcWNBVz EGW55GzC11zRsPglhFkY+SZlB+911jyi44+TzYfMMdbIGq8JGJtbbahO3Hgv11mwQg73Mq gawy8jf+SD0umiOcOpp0sQP4HNrhQT4BFCTrvshYoifsQhu0OQ+VJxHOibDe9LR1v4QRZ5 kZG9r+AFMI9NspymDTJpAoV72Kg7crtW6v51vGRF3CgB4bmvg9t17Qt6L4LV+fZ3r75eQg vJACHLlDi3LsfRX8KPmcayWyERPuCS5b/cbjYFvjKMlnE5I9z9cI/gCU5ji+zg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653192978; a=rsa-sha256; cv=none; b=oi0y/TQ513qRUTbqZPe+ChWALu/StMBpJaC+HAkFbk7DeP9V7q4UM6rJFKl3CjKTKdA7Sl 0Iszb9wzyVs0Fwwimu8ngS3fTewCJVHSB8i75uDVp+e9aKs2JAZmvFTzxRFmukn+A+NIpr CARYAwaNYk4YvJdRcoVoe6h+oOk34Ydw853GsyETudbTw7IDoXuOKEpYCrAHlsQ/+d++Y4 A3P1pz0i97ewkbFIGsOvfztaZ2c0QpWKzlJaJaxgWEeKPt6sTasEdjsWq5Ghk4efKpCUCn 9QlJyOFkKn93wC52pyiqda/ogDU1J5XDnGW19rESrj07/lKMw6edbu7SxB/whA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=f7A63CWS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.45 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=f7A63CWS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BD8686250 X-Spam-Score: 5.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: gF0wKACo/WQw tags 46182 +moreinfo thanks Hello, Ludovic Court=C3=A8s writes: > Hi! > > Leo Famulari skribis: > >> We could also make it warn about use of the HTTP protocol (as opposed to >> HTTPS). Your thoughts? >> >> * guix/lint.scm (check-git-protocol): New procedure. >> (%local-checkers): Add 'git-protocol' checker. >> * doc/guix.texi (Invoking guix lint): Document it. > > Nice! I think it=E2=80=99s OK to use =E2=80=98eqv?=E2=80=99 here (=E2=80= =98eq?=E2=80=99, even). > > One nit: it would be nice to add a positive and a negative test in > tests/lint.scm. You can run =E2=80=9Cmake check TESTS=3Dtests/lint.scm= =E2=80=9D then. > > Otherwise LGTM! Gentle ping to Leo :-). It looks near ready. Thank you! Maxim