From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gIzUGfvle2NydAAAbAwnHQ (envelope-from ) for ; Mon, 21 Nov 2022 21:56:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WIK7Gfvle2PLmAAAauVa8A (envelope-from ) for ; Mon, 21 Nov 2022 21:56:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 212623D656 for ; Mon, 21 Nov 2022 21:56:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxDps-00067a-SB; Mon, 21 Nov 2022 15:56:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxDpj-0005z6-5l for guix-patches@gnu.org; Mon, 21 Nov 2022 15:56:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxDpi-0001mI-T5 for guix-patches@gnu.org; Mon, 21 Nov 2022 15:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxDpi-0006Zx-C8 for guix-patches@gnu.org; Mon, 21 Nov 2022 15:56:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#58812] [bug#59164] Coding style: similarly-named variables Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Nov 2022 20:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58812 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 59164@debbugs.gnu.org, 58812@debbugs.gnu.org Received: via spool by 58812-submit@debbugs.gnu.org id=B58812.166906415625269 (code B ref 58812); Mon, 21 Nov 2022 20:56:02 +0000 Received: (at 58812) by debbugs.gnu.org; 21 Nov 2022 20:55:56 +0000 Received: from localhost ([127.0.0.1]:48980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxDpb-0006ZU-SI for submit@debbugs.gnu.org; Mon, 21 Nov 2022 15:55:56 -0500 Received: from mail-qk1-f178.google.com ([209.85.222.178]:45749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxDpZ-0006ZD-TO; Mon, 21 Nov 2022 15:55:54 -0500 Received: by mail-qk1-f178.google.com with SMTP id v8so8909911qkg.12; Mon, 21 Nov 2022 12:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=f2BQH21an7hjWbLnErDeQIITcwak8jyouTcuX/SktR8=; b=jOSN5QfQl4uqW2nq4rmt8zgR4g4ZS2SzqTC4oy3fM46x6CTYMnF2PTQ+B7ip9RGSnp Mwx5+14iRKhwVEaPbFh5ckNiPFcsVnuUGO5x57+6BmrqUBnr8iuIW6Tm5cPLIvhCrLtj pDuZVZ8f0Z9xPslRYMako+HSIh1GcPpLNcR99OofYoP/FV7lXI6cZgLAi6AOgATyvp2G C6g7B1Txp7bi0pIMt+Jg/U6GmcivpWa8fKNAx+bQ61BEGudRnAlvYU74daZVZkE19w7Q +86Fx3FHlUR2CT72N/rV4iDWlyIrDFVeaKFZK0UdCLJ8UHyTmqOMu9o8MdN5A8ps5iLs OV6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=f2BQH21an7hjWbLnErDeQIITcwak8jyouTcuX/SktR8=; b=NE6oCL30lHI19QLQwA91GQpmm9sgxG9DGu4T7Gfudbx7MfopT9ksW9AZ9RPJu6OuDR +kwTtCw00q7IvYCu9jYiq9v6rPvaGbfau2ozNPdPu902ymdQLsvq7ErizXcjv19MfLbx 3iC1BaQRS/jjwlvGBljrZ3pO6m3ECn9pnv0yQq1Rgduz+q8kLW39WrlnlYnjVxFjcLab ftCXgfMmcjE55eTFDYS9a1siG33L+LcxnjelVcBewgOjyCzHSSHx6GGixPjWJCw/r7Wb xWFqnnwg6WLEOHaDkWB+ikaEMDcZiZzoW0anoYao5nfGlqmo7O2w3Y9E2AXpzsISZ4oe fIeg== X-Gm-Message-State: ANoB5pmKz3eXytCXkJ/o7zb2GYIXn8cIgiLa6YFX331d+EWR3b0Exz6c NTKb908k3EkcqmXn5cKwr47KPsrA7Tk= X-Google-Smtp-Source: AA0mqf5xo9+hsxIljoKwTGqTH2y9w2XYzrGq8UqIRUgOGjYcXA1U8m5jv+KxfVNiigwBUhdVllIgyw== X-Received: by 2002:a37:44ce:0:b0:6fa:4335:5793 with SMTP id r197-20020a3744ce000000b006fa43355793mr666636qka.242.1669064148020; Mon, 21 Nov 2022 12:55:48 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1003]) by smtp.gmail.com with ESMTPSA id m14-20020ac85b0e000000b003a591194221sm7445908qtw.7.2022.11.21.12.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 12:55:47 -0800 (PST) From: Maxim Cournoyer References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> <87sfihfpng.fsf_-_@gnu.org> <86zgcpju9p.fsf@gmail.com> <87y1s82o23.fsf@gmail.com> <87zgckwdtw.fsf@gmail.com> Date: Mon, 21 Nov 2022 15:55:46 -0500 In-Reply-To: <87zgckwdtw.fsf@gmail.com> (zimoun's message of "Mon, 21 Nov 2022 16:02:19 +0100") Message-ID: <87sficqb71.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669064187; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=f2BQH21an7hjWbLnErDeQIITcwak8jyouTcuX/SktR8=; b=p4EzKcyva/j5Mm/11hvjizutxPMO5oGBHxlForcSG+LPiZhFFTki27C0wGCO4fy4CCdpcw hI7PNdikDTswf5mY7XDruF9gjfgDRGG5i7GqzZdAl9aiBKLmfcMDwcayVnUsFx21zU3QsH QHnwessun75DMJtiG2ZGQk6ZpMREV6sb8EXOap47rJ2ZIaP7zZS/a2YBYn2QUkJIkfMiA/ VAyRfaOaZRa7PXd/rkF+2e8Qdf3OasIQpfou7RA8fKfakbKLgfpE4qdjkCY3SpxQwjzFV7 8xF2foCy9I3Or8KpmjPOv3xPpFN4REv9EO1CzcTUWbinj9eKrfHar4u8onsR5Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669064187; a=rsa-sha256; cv=none; b=KlLbw1k6l0ApD/dphDIDUyi87O37MesWTehNnwVlYdclhlRCtdqzUi1wYNVud9+ykSIGjO 8hgH6VcPtsKUhN00ILiloSsHmiWvnslsBFOQFxk5jZY83qnr5jofRas7zn5V2WxNMHeJg3 Yu9yAEmeWThVW6cufGHMp8hXb5SVXjZI2GF7bi3RNmFLedz7NrUSmCfqol+q/1A52nXnrt IE2qt/GOhnJB38o4UEQwF+VMv6AqIpyv2c0fvCWAC+FSPRAj3TRiOJC1RDIHuhkzojHOks RzWjO+2IaLwtSxmopobLluecSIpeDoMnvO4hIUwvbRhb4TgkdBR73OQJ6bf23A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=jOSN5QfQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 8.99 X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=jOSN5QfQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 212623D656 X-Spam-Score: 8.99 X-Migadu-Spam: Yes X-Migadu-Scanner: scn1.migadu.com X-TUID: sfFqwaMipKXL Hi Simon, zimoun writes: > Hi Maxim, > > On Fri, 18 Nov 2022 at 12:02, Maxim Cournoyer = wrote: > >> The intent was to keep away from the following imperative style, which >> hurts both readability and debuggability in my opinion: >> >> --8<---------------cut here---------------start------------->8--- >> (let* ((my-target "something") >> (my-target (mutate-once my-target)) >> (my-target (mutate-twice my-target))) >> (do-something-with my-target)) >> --8<---------------cut here---------------end--------------->8--- > > Well, =E2=80=99mutate-*=E2=80=99 is not really mutating. Maybe I miss so= mething and > from my understanding, this =E2=80=99let*=E2=80=99reads, > > (let ((my-target "something")) > (let ((my-target (mutate-once my-target))) > (let ((my-target (mutate-twice my-target))) > (do-something-with my-target)))) > > > and not, > > (begin > (define my-target "something") > (set! my-target (mutate-once my-target)) > (set! my-target (mutate-twice my-target)) > (do-something-with my-target)) Right. I used "mutated" where I should have used "shadowed by lexical scoping". The outcome for me is the same; the original value of an argument (target) in the code gets shadowed, thus is theory it becomes more difficult to inspect its original value, should we have a debugger that is able to stop at the place to inspect to print ',locals'. In practice since using breakpoints/a debugger to debug Guile code rarely works as intended (in my experience hacking on Guix!), we typically sprinkle the source with 'pk', and that point becomes moot. > Well, the former is =E2=80=99lexical-scope=E2=80=99d so the 3 =E2=80=99my= -target=E2=80=99 are not truly > an imperative style, I guess. > > Back to the pattern, you are suggesting to write, > > (let* ((my-target "something") > (my-target* (mutate-once my-target)) > (my-target** (mutate-twice my-target*))) > (do-something-with my-target**)) > well, I am not convinced it helps for readibility. And I think, the > pattern is manually doing what =E2=80=99let*=E2=80=99 is already doing fo= r you. The value it provides is that it becomes easy to inspect each intermediary result in a debugger. I think we're done expressing the arguments to have on both sides, which aren't too strong either ways :-). I'm happy to restrain myself using such a pattern and keep moving forward. --=20 Thanks, Maxim