From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8CWmOdjS7mMDhQAAbAwnHQ (envelope-from ) for ; Fri, 17 Feb 2023 02:05:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kE2oONjS7mMOLQAAG6o9tA (envelope-from ) for ; Fri, 17 Feb 2023 02:05:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3E6201BA8C for ; Fri, 17 Feb 2023 02:05:28 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=NGnYym06; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676595928; a=rsa-sha256; cv=none; b=SKdBjJbE7upLjnv835slWqQUIJmRzotupK1JtVBcW+ngcxISOuvw+KIFkoCoZ8Ga+ri4bO p8aFyfXXeWEkbI+bSLGzuWR+Aw6isCr5kEMtf3S+/aCrr+Xx/xnL3AVetHN3/CE3oxK18c ua51KpdNizz8Zitn+Gx5B+CbD3+DH1OC7rC+dwF5So5OHsSuNmnveAEoWoiB3Ll8eHXiNH /W2b4dlGDU2Cdpf3nSlDbssPuj8Ih5j9UUbP0dH2dXHw1aOAQbsOqZGe3D+pXdbreT1tYH Xh+49j9HoDFGHhuVLHDw1xRIchIdst7SNP2JXof+26isBvgQx7dWFWwcvef8yA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=NGnYym06; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676595928; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=9GgRyD9cjgl37mvhOt9t2pkTFhvVvyk7Bm+4fPn8XsI=; b=OYy7qI7Q5+OgZuVqIw/IkjbeWfPD4eW4UDkEEFBniWjhqEq1lgB9M/orsVZejEBhE7vNrD XLcU6Rqb5cxKFOzqTPH5IvKPWepdMK+lsKIX4XPYpOKdS+nh1xdLgxy8Ly3v0o1qox7tlk NvLxTDcR+W2iohUezzFebtukxMM/TfpOqcKkoDqHTpHecew0mtalLQVLCrmd6AW0MkJtfP xBUQ68nb6n2P9T2TtknCheZHTGskZV+RFgKjQ2MjlVHYagnPaACEejJEfdFShFAEe9xwpw avFjw+cTaWaun3v5SUVT80UFLrheRbJvrSvT1aNFJnRNsZawx3As4yZzrrsjJg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSpBS-0006Qg-TG; Thu, 16 Feb 2023 20:05:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSpBQ-0006QQ-Cs for guix-patches@gnu.org; Thu, 16 Feb 2023 20:05:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSpBO-00036g-Kz for guix-patches@gnu.org; Thu, 16 Feb 2023 20:05:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSpBO-0006Ev-FK for guix-patches@gnu.org; Thu, 16 Feb 2023 20:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60673] [PATCH 01/39] gnu: Add ocaml-domain-name. Resent-From: Csepp Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Feb 2023 01:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Christopher Baines Cc: 60673@debbugs.gnu.org, raingloom@riseup.net X-Debbugs-Original-Cc: 60673@debbugs.gnu.org, Csepp , guix-patches@gnu.org Received: via spool by 60673-submit@debbugs.gnu.org id=B60673.167659588023947 (code B ref 60673); Fri, 17 Feb 2023 01:05:02 +0000 Received: (at 60673) by debbugs.gnu.org; 17 Feb 2023 01:04:40 +0000 Received: from localhost ([127.0.0.1]:38039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSpB2-0006EA-36 for submit@debbugs.gnu.org; Thu, 16 Feb 2023 20:04:40 -0500 Received: from mx1.riseup.net ([198.252.153.129]:41142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSpAz-0006Dl-IS for 60673@debbugs.gnu.org; Thu, 16 Feb 2023 20:04:38 -0500 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4PHtrJ0rtRzDqWn; Fri, 17 Feb 2023 01:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1676595872; bh=bEla+P5FOXETt8rvo4c9kJhPSZjNmXOrihm6+T8Th3Y=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=NGnYym06hcXrp4K/bjbSQzmdpeaMuLLPn3kNHZV/O4S2ORQmGQW4zyEP0uUSKfada mK97ivhRRgBYvZsTxt49zztR1+yeD1J9iXmKPJAbGmBressM1U3U/s68wEwQ9F6z3/ DDHrylXNK3NLU1dMHEPBBhoOFeeP+SSzxQ91bwF8= X-Riseup-User-ID: D5A5BE7A5B330F7D18A9AA9785F849340A0E597F0BFBA531B095FC01A0EA463B Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4PHtrH2Yylz5wyx; Fri, 17 Feb 2023 01:04:31 +0000 (UTC) References: <20230109003529.23375-1-raingloom@riseup.net> <874jrxdhxi.fsf@cbaines.net> <87wn4t2aik.fsf@riseup.net> <875ycc8v82.fsf@cbaines.net> From: Csepp Date: Fri, 17 Feb 2023 02:03:46 +0100 In-reply-to: <875ycc8v82.fsf@cbaines.net> Message-ID: <87sff5t84l.fsf@riseup.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 3E6201BA8C X-Spam-Score: -2.82 X-Migadu-Spam-Score: -2.82 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: suJTRCI9JwGG Christopher Baines writes: > [[PGP Signed Part:Undecided]] > > Csepp writes: > >> Christopher Baines writes: >> >>> [[PGP Signed Part:Undecided]] >>> Hey, >>> >>> While I think the builds look OK for this series, there are quite a few >>> formatting issues raised by the linter (this can be seen on [1] and [2]). >>> >>> 1: https://qa.guix.gnu.org/issue/60674 >>> 2: >>> https://data.qa.guix.gnu.org/compare?base_commit=238f965c331990459a69cbc713ca951ad40e6044&target_commit=3b5485b9cdaebda127dc040ad67a287f39e33519 >>> >>> Could you run the linter on the packages you've added here, address the >>> issues it raises and send an updated series? >>> >>> Thanks, >>> >>> Chris >>> >>> [[End of PGP Signed Part]] >> >> Those are all URL constants, can't really do much about them other than slice >> them up with string-append, which I'm not sure really helps with >> readability or ease of editing. They were not an issue while I was >> editing the code and gnu/packages/ocaml.scm already has a lot of lines >> that whitespace-mode highlights as too long, so I thought it wouldn't >> matter much and my time would be better spent elsewhere. > > You're right that there are quite a few other instances of lines that > are too long in that module, but I don't think that's a reason not to > add more. I think splitting the long URL strings with string-append is a > good approach and can help with readability. > > [[End of PGP Signed Part]] Alright, got around to sending the updated patch series. Hopefully I got the send-email arguments right.