all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* npm has irreproducible install behavior
@ 2023-07-07  5:47 Ricardo Wurmus
  2023-07-07 12:38 ` Jelle Licht
  0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2023-07-07  5:47 UTC (permalink / raw)
  To: guix-devel; +Cc: Jelle Licht

Hi Guix,

after a few days of frustrating investigation I found a bug in one of
the libraries used by npm:

  https://github.com/npm/pacote/issues/285

The result is that “npm install” will not install *all* files dependent
on whether a file is deduplicated in the store.  This causes
irreproducible output and build failures down the line on different
systems depending on the state of the file system.

We should patch this ourselves.  We can either tell node-tar not to mark
up hardlinks with the “Link” type, or we can patch pacote to not skip
files that have the “Link” type.

I’ve tested this little addition to the build phases of node-lts on an
affected system:

--8<---------------cut here---------------start------------->8---
           (add-after 'install 'do-not-ignore-links
             (lambda* (#:key outputs #:allow-other-keys)
               (with-directory-excursion
                   (string-append (assoc-ref outputs "out")
                                  "/lib/node_modules/npm/node_modules")
                 (substitute* "pacote/lib/fetcher.js"
                              (("\\/Link\\$\\/.test\\(entry.type\\)") "false")
                              (("\\/File\\$\\/.test\\(entry.type\\)")
                               "/(File|Link)$/.test(entry.type)"))
--8<---------------cut here---------------end--------------->8---

What do you think?

-- 
Ricardo


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-13  8:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-07  5:47 npm has irreproducible install behavior Ricardo Wurmus
2023-07-07 12:38 ` Jelle Licht
2023-07-13  6:48   ` Ricardo Wurmus
2023-07-13  8:41     ` Ricardo Wurmus

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.