From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oDg8ItLwtmTTVAEASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 22:06:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GOAIItLwtmRadwEAauVa8A (envelope-from ) for ; Tue, 18 Jul 2023 22:06:42 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6591348826 for ; Tue, 18 Jul 2023 22:06:42 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Z3Mkx3r2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689710802; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8eL7SYYMr6I1A78+RraiQI9va7xyojhHIOnPcvoWqh4=; b=SWxih5YRfFeM2lRQUHq3wzX7v7rcQ2VhX869Jf/Fi39tLUVEh9iib4FfHwFqLcKcVrJbQV jZ8C6aw7I71IOlicniGyj/uUwMB2F+0KYNeB4a+jikWThKEiM6L+PiMcKQa4MWwV3yGRCX dP1WGwYVoOSF89qvchRjeX9+anpUUZtoPpNlYDMhJPtKLobegBYO8yuHlsb/Eunqehb9fG HAqyjHXFe0XwUtXuHheUwOgqvWjAel+wjCiMvokwcz+zVsCNzYrUn0TJDpEVAwW1z7CXn4 YKJun7F6hiSIIf7zJY6xk0mQA5RdpKlwgriNjBVFXcIYsCCpJArVI05WBJmAIA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Z3Mkx3r2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689710802; a=rsa-sha256; cv=none; b=r80KZdiMWfyjsGGPV/1gpxsl8UX0slXQBHDorgQrU3dAvlmYMws96avQefivA61G6ewVFJ 2LtEGwIPB2jfX7DvFckRiJFJk8N0UNGkchiYF+cllKfZbkcjTcLyKtmTAQ3Yx8hA2hzyqS L1xd8VOdAHwD/HcjzTZkGLqIEAs8a6s2Doxc+XUBXpjJZ0NGnYaGAL+4l9g7qWWHPLqQZ4 CWQB7LWCbgcCg23s1wbAihORj1ThQLzHl9vEMfJVxbFxTOAf55YJYTS1pyYejtAefDKybw 749h6blDWllkesar3eDXMwSTKO4eO/aoHmjnZ80Z/Y4/JA3ABisZVyKm1+QqRg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLqxX-0002Lz-Th; Tue, 18 Jul 2023 16:06:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLqxP-0002Go-2V for guix-patches@gnu.org; Tue, 18 Jul 2023 16:06:05 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLqxO-0004mQ-Ql for guix-patches@gnu.org; Tue, 18 Jul 2023 16:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLqxO-0003lF-4J for guix-patches@gnu.org; Tue, 18 Jul 2023 16:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64711] [PATCH 40/43] gnu: pango: Support build for the Hurd. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 20:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64711 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Janneke Nieuwenhuizen Cc: Raghav Gururajan , 64711@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 64711-submit@debbugs.gnu.org id=B64711.168971070314366 (code B ref 64711); Tue, 18 Jul 2023 20:06:02 +0000 Received: (at 64711) by debbugs.gnu.org; 18 Jul 2023 20:05:03 +0000 Received: from localhost ([127.0.0.1]:54357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLqwQ-0003je-IZ for submit@debbugs.gnu.org; Tue, 18 Jul 2023 16:05:02 -0400 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]:51547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLqwM-0003j4-Fv for 64711@debbugs.gnu.org; Tue, 18 Jul 2023 16:05:01 -0400 Received: by mail-qk1-x72a.google.com with SMTP id af79cd13be357-76714d3c3a7so606338485a.3 for <64711@debbugs.gnu.org>; Tue, 18 Jul 2023 13:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689710693; x=1692302693; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8eL7SYYMr6I1A78+RraiQI9va7xyojhHIOnPcvoWqh4=; b=Z3Mkx3r2juFT86Mp1wiS7DyJGozV+B6xV9MSZEtPnmLQA+q+xp9TbSozkeWyuBb7aG bscopEUDVqaabYghPnaFAS/AdMbwAsI7tHX814O+zP0CiG7XqeTLMaAcOJNDo4HqeIUO OXdwrgd5zsm9FdmD3hL3655NDwqlyruWOS2RmC+gEvNnrgmTdBzzIR56c9lylYJ7qlPb bMZZZpQt/9oGYyOyB98jvvfbxm2vNT4N0tjzf/S0BYeIDGGobbKlzO19ZuQL0T95KH1q oVjRuY+8H12Y/vBq6Ht7E9ASeYKzi2yoNxPT0ZKFXY5oLVPTi8vodtP0I+jgz6euFsPX UFTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689710693; x=1692302693; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8eL7SYYMr6I1A78+RraiQI9va7xyojhHIOnPcvoWqh4=; b=jd8KHEQp/pOJOTX47ZVQBCKvOrouRdKgd7RHX4iMPVIOeQxsgM4nDFam8vg6MhrzU3 nIyju8yFM/WXPuMD0ID6RnHKoC90qHY/BRDkFWpSWJ4Y7+Szi71ax1cKudQy/jAFcfac o+XaSOHunQI0tVuIBhvXe1dNegPdQlWKBvIp7CR7HvY4XJWXejQLD7n6VEEvytAX3x3H zERQPmiuigBhfz5YV6IxNq7z2EkZt1DUzM1l63p9F0PR2lC589F5+Yw40VmurtAunR+v JhGo1cKYXh5E9CkeUzA2p5D1Nhj/pB2CjYupqWTkv5E7fnESPhnE0X/n0JgBprQkP5s1 RbRg== X-Gm-Message-State: ABy/qLakhVeH7MentItrSiYSuDe/hQx1C5tNokkIfAAJukBYEa1YI2xm fufGYPnceRz6B6aVkFfv6o4= X-Google-Smtp-Source: APBJJlHehKyXZygTmxo/tEQfPVRvXM/i5F/0hd3MWJtVj9NUvPoJA/hDiT2ZQbfkeqloyZISnDAgqQ== X-Received: by 2002:a05:620a:21db:b0:768:125b:2b94 with SMTP id h27-20020a05620a21db00b00768125b2b94mr617768qka.78.1689710692989; Tue, 18 Jul 2023 13:04:52 -0700 (PDT) Received: from raisin ([2607:fad8:4:6::984a]) by smtp.gmail.com with ESMTPSA id 18-20020a05620a071200b007672e3348edsm813915qkc.108.2023.07.18.13.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 13:04:52 -0700 (PDT) From: Maxim Cournoyer References: Date: Tue, 18 Jul 2023 16:04:51 -0400 In-Reply-To: (Janneke Nieuwenhuizen's message of "Tue, 18 Jul 2023 16:40:33 +0200") Message-ID: <87sf9lt28s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 5.85 X-Migadu-Queue-Id: 6591348826 X-Migadu-Spam-Score: 5.85 X-Migadu-Scanner: mx0.migadu.com X-TUID: MnkUlHaaHEOJ Hi Janneke, Thanks for your efforts on this. Janneke Nieuwenhuizen writes: > * gnu/packages/gtk.scm (pango)[native-inputs]: Do not include > gobject-introspection when building for the Hurd. > --- > gnu/packages/gtk.scm | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm > index 853696c7f5..15dea2852b 100644 > --- a/gnu/packages/gtk.scm > +++ b/gnu/packages/gtk.scm > @@ -401,12 +401,14 @@ (define-public pango > (list bash-minimal > zlib)) > (native-inputs > - (list `(,glib "bin") ;glib-mkenums, etc. > - gobject-introspection ;g-ir-compiler, etc. > - help2man > - perl > - pkg-config > - python-wrapper)) > + `((,glib "bin") ;glib-mkenums, etc. > + ,@(if (target-hurd?) > + '() > + (list gobject-introspection)) ;g-ir-compiler, etc. > + ,help2man > + ,perl > + ,pkg-config > + ,python-wrapper)) Stylistically, I think it'd be better to use append (and 'if') here than quasiquotes (to avoid having to unquote all inputs). Otherwise it LGTM. -- Thanks, Maxim