all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: John Kehayias via Guix-patches via <guix-patches@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Lilah Tascheter <lilah@lunabee.space>,
	64528@debbugs.gnu.org, iyzsong@envs.net
Subject: [bug#64528] [PATCH v2] gnu: mesa: Fix Vulkan on older Intel GPUs.
Date: Tue, 25 Jul 2023 21:25:57 +0000	[thread overview]
Message-ID: <87sf9bisyo.fsf@protonmail.com> (raw)
In-Reply-To: <f1faeff0e4d26bef7bc3bfed0b25cfb2552116e5.camel@gmail.com>

Hi Liliana,

On Sun, Jul 16, 2023 at 08:28 PM, Liliana Marie Prikler wrote:

> Hi John,
>
> Am Sonntag, dem 16.07.2023 um 18:06 +0000 schrieb John Kehayias:
>> Ah, sorry I didn't see and respond earlier as we have a mesa-updates
>> branch that I'm just waiting for the go ahead to merge to master. It
>> updates mesa and is already built on Cuirass.
>>
>> How can we ensure that upon merging we don't cause the full rebuild?
>> Should I revert this, apply the updates, and then do this graft? Or
>> will applying the update on top of this graft commit be okay too?
> Since this graft is phrased as more or less a package transformation, I
> would expect it to still apply (more or less) on top of any update you
> do on mesa-updates.  If you already fixed the package on mesa-updates,
> then you can simply drop the replacement during your regular merge of
> master into mesa-updates.  Similarly, if you want to do away with the
> graft, but haven't done so yet, you can inline the changes after the
> merge.  In either case, it should be done before mesa-updates gets
> pushed to master.
>

I added a new commit on mesa-updates (after rebasing on master) to
ungraft, incorporating this change in mesa directly now.

>> My original thought was that this shouldn't be grafted but can just
>> be applied directly to mesa-updates with the next round of patches
>> there, as this one is already built. This could be done pretty
>> quickly, though I expect a new mesa version soon that I would group
>> this with, along with some other mass rebuild changes waiting. I
>> think on the order of a couple or few weeks.
>>
>> What do we all think? (Sorry there is no mesa team as of yet, not
>> sure how to set that up without it applying to a too large scope of
>> packages by default.)
> I think grafting this for now, but undoing the graft on mesa-updates is
> the way to go.  In my humble opinion we should fix bugs on master as
> they arise while doing long-term solutions in teams where we have more
> resources for big builds.
>

Sure, sounds good. I ended up updating mesa again along with a few
other patches and somewhat related updates; letting things rebuild now
and hope to merge to master once that looks good.

Thanks!
John





      reply	other threads:[~2023-07-25 21:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-08  5:16 [bug#64528] [PATCH] gnu: mesa: Fix Vulkan on older Intel GPUs Lilah Tascheter via Guix-patches via
2023-07-08 15:46 ` Liliana Marie Prikler
2023-07-08 18:29 ` [bug#64528] [PATCH v2] " Lilah Tascheter via Guix-patches via
2023-07-16  7:26   ` bug#64528: " Liliana Marie Prikler
2023-07-16 18:06 ` [bug#64528] " John Kehayias via Guix-patches via
2023-07-16 18:28   ` Liliana Marie Prikler
2023-07-25 21:25     ` John Kehayias via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf9bisyo.fsf@protonmail.com \
    --to=guix-patches@gnu.org \
    --cc=64528@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=john.kehayias@protonmail.com \
    --cc=lilah@lunabee.space \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.