From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2FV7OMmL/2SNPQAAG6o9tA:P1 (envelope-from ) for ; Mon, 11 Sep 2023 23:51:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2FV7OMmL/2SNPQAAG6o9tA (envelope-from ) for ; Mon, 11 Sep 2023 23:51:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9546258EC5 for ; Mon, 11 Sep 2023 23:51:05 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=q1x6U3So; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694469065; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Ki+aPR2gV71fjhf5NXDFcdYLW/oL3nC/OvDWk79DBno=; b=j/2bCmD6A6BKyD4IXOt4FPqDNhtUJkY+5PSq0zM6Am3IDqOtbZ7aYcgI1HXzKUEpjmrDuV z/T8hrQfMw5kzpiZ03HIzoa+G7C4zChn3kVNBMSXdSVEes5bqqJ/Sz3jKKwgMfA23HK+rt gOnxdrEGpQ4P+Y4yVs4zvaK6Snx2ay+H6qoJXqzeiSkBV0YjE5vVM2g5EhvEe1iedywphA x1KxvM0rViMm4eHjBb/ub+6mohAHI6mryV+b51srUfjZi6JJ4np3h1IS51fbQ9kNi/Rur6 Th95ifCS6Zd4j46OxCpanW/sgEU1sg5TQt0YIYHo7h7RYD1kY9z0tg/hpnPfFA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694469065; a=rsa-sha256; cv=none; b=dYxX/i7MHA5YJIbPexcfuWkNPTH2nGS70WillXqtHZR3QAqzOOB+1fO1EeQu8V4qeUAOmY DQYabENElPVKjYYJu5mnAXmHR3RyMc6hWD4FcSdcgr7Qm4P18wFCGBoDGiVxyUe4m/6IgG lg89u4u1/LJg91EY37Yr9qmL7iHpCTBoLut0Zu+R2O2BV118e08Nsv0VPHyQ2yM//eVfbD PklMMfszU6l6b0AygqVbu2Uvk9bdDDbPSS2x0XA114p877s8R1tIT/Sq792IbFSwSng8H5 7CVqkJ9NEO8iahVq62ZpwPbxT8ORBvMiVFPCw5Qvths2SLg5eb901CTs6tAIVQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=q1x6U3So; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfooB-0007jn-Ka; Mon, 11 Sep 2023 17:51:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfoo7-0007jD-9L for guix-patches@gnu.org; Mon, 11 Sep 2023 17:51:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfoo5-0004fK-VZ for guix-patches@gnu.org; Mon, 11 Sep 2023 17:50:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfooA-0006OC-5o for guix-patches@gnu.org; Mon, 11 Sep 2023 17:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65012] [PATCH] gnu: Add picket. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Sep 2023 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65012 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= Cc: 65012@debbugs.gnu.org Received: via spool by 65012-submit@debbugs.gnu.org id=B65012.169446905624546 (code B ref 65012); Mon, 11 Sep 2023 21:51:02 +0000 Received: (at 65012) by debbugs.gnu.org; 11 Sep 2023 21:50:56 +0000 Received: from localhost ([127.0.0.1]:55011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfoo3-0006Np-PO for submit@debbugs.gnu.org; Mon, 11 Sep 2023 17:50:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfoo1-0006NY-9U for 65012@debbugs.gnu.org; Mon, 11 Sep 2023 17:50:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfonr-0004e6-C0; Mon, 11 Sep 2023 17:50:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Ki+aPR2gV71fjhf5NXDFcdYLW/oL3nC/OvDWk79DBno=; b=q1x6U3SoYqIbxLscw0Om Pe8jScU/WaY2A7LWgYA3s8am/OqAYKmZj0OJ9zOs0Ty/9PqeyO7PwBgd73mjx1Il+k78Xjoz5h2YB 9gRZHoaKKme1oDow5Ifc3ZWAH8ZFYjHm69AbqO+ZLjNADBL1fBE21u27h52MYks9KZKoRyFNUiY8p L+xpzdKjga12vD3bdkVLIc6FP+B/q+C5Y1mgmHsDIqq0x9bs31CsZ9aVWpJ0GqLoZGmdtAn4HR/Za A7SfeviUAF3I//G5Amfje4Kf8jLc4XPur0Il0D5B1E+h828lO4cHk7QG15R7g24f1QlDKNBd0Zwh5 fgTNN+YBNxU8bg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Mon, 11 Sep 2023 23:50:41 +0200 In-Reply-To: ("Sergio Pastor =?UTF-8?Q?P=C3=A9rez?="'s message of "Sun, 10 Sep 2023 17:42:05 +0200") Message-ID: <87sf7kpefi.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.99 X-Spam-Score: -5.99 X-Migadu-Queue-Id: 9546258EC5 X-Migadu-Scanner: mx0.migadu.com X-TUID: jxbkjZnuG0n7 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sergio Pastor P=C3=A9rez skribis: > * gnu/packages/image.scm (mini): New variable. > --- > This patch bundles the mINI header library. This library includes a serie= s of > tests which have g++, linux-header, and a few other dependencies that get > satisfied with `gcc-toolchain'. For an unknown reason adding the module `= gnu > packages commencement` breaks Guile. This patches have been tested under > `GUIX_PACKAGE_PATH` successfully. Also, adding this package definition un= der a > module which already includes the commencement module does not present the > issue. > > For this reason I submit this 2 patches as a proposal. Any further info > regarding the issue described would be appreciated. As you found out, the (gnu packages commencement) module cannot be imported directly. The solution here is to use =E2=80=98gnu-build-system=E2=80=99, which has G= CC & co. as implicit inputs, and adjust the relevant phases. I made the change below and applied this patch. Thanks! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index 4332a7ead8..403409975a 100644 --- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -68,7 +68,6 @@ (define-module (gnu packages image) #:use-module (gnu packages cpp) #:use-module (gnu packages curl) #:use-module (gnu packages compression) - #:use-module (gnu packages commencement) #:use-module (gnu packages documentation) #:use-module (gnu packages fontutils) #:use-module (gnu packages freedesktop) @@ -1945,24 +1944,30 @@ (define-public mini (sha256 (base32 "01wn7h9rjz9h6cr11dd62jsb3315d1h6c33pdmwi2l7d8a4n3h8d")))) - (build-system copy-build-system) + (build-system gnu-build-system) (arguments - (list #:install-plan ''(("src/mini/ini.h" "include/mini/ini.h")) - #:phases #~(modify-phases %standard-phases - (add-before 'install 'check - (lambda _ - (with-directory-excursion "tests" - (for-each (lambda (test) - (let ((test-name (basename test - ".cpp"))) - (invoke "./build.sh" test-name) - (invoke "./run.sh" test-name))) - (find-files "." ".cpp")))))))) - (native-inputs (list gcc-toolchain)) + (list #:phases + #~(modify-phases %standard-phases + (delete 'build) + (delete 'configure) + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (with-directory-excursion "tests" + (for-each (lambda (test) + (let ((test-name (basename test + ".cpp"))) + (invoke "./build.sh" test-name) + (invoke "./run.sh" test-name))) + (find-files "." ".cpp")))))) + (replace 'install + (lambda _ + (install-file "src/mini/ini.h" + (string-append #$output "/include/mini"))))))) (home-page "https://github.com/pulzed/mINI") (synopsis "INI file reader and writer header library") (description - "This is a tiny, header only C++ library for manipulating INI files.") + "This is a tiny, header-only C++ library for manipulating INI files.") (license license:expat))) (define-public picket --=-=-=--