From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id WAc4ExdMe2UQMwEAkFu2QA (envelope-from ) for ; Thu, 14 Dec 2023 19:40:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id UOtAEBdMe2VXNgAA62LTzQ (envelope-from ) for ; Thu, 14 Dec 2023 19:40:23 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Y4kwjfn2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702579223; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cT25ZJq3RZrD8hyIVaAJRSfhC2eHfAaNW2LRzHYyoSQ=; b=Kz6NLgmS6AUzKwPHAEx7a7fM1aPFX3hFeXS/Rrct8k4z23XEGa3DPV+f96m4FSWFkFrsF8 ejxZZadAAnshLpKbALUcXZ8Dszt6by+HCOUda6moN93MbmLYLVvwMEwItNgcFFbIlHI9jR NlPaXHza0G4aG3VYsmUfMDwfQ8lab7Cesoroh5f+G7inzTbroF7l0y6NYVmyo906wOfkeq sGe4+hC4B3i5oMZB9f+drbbNU9jLmfPFwmnvEYtDN/qq1yDS9AG5edgkRQvM3eooltPGSQ L+iDPRG0YJ/CyTrkctCij1KJs2yrmi64R682wu2QNip+FY6R1gWHnAXwRQbuKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Y4kwjfn2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1702579223; a=rsa-sha256; cv=none; b=U3JfOVrJoPkK0sbNzvuntcEp5R4JsB6IBhwHZGMIE053DaJdIBaoWH+yuhsEapPz1Dh87A mGQExWMfekLz7PCrPUEc4KsN24qVgB3hwNWb7SIFn35WEGhWitCoyeVd3V6m0yr5FzMr4e VRsWFw+pdRGrSS+9d9CqG0FCbIodArjNccWHjt4rNqSnVNeoFgGNdTH1Q8rr9bxPX3+wPn a7jI6qA9N6XOJ8xJ0dgnjdzRjmWTbWfT+0sQYbvJk2Nj1rXIevbXYlSthrqSxRA+zYwDDG KyLXAyH5w8YtpyFW3B/+ju1xEqigYmzvLgY5QvSdOq88Gkbbj4IHbqMx/gCW0g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1163D4259D for ; Thu, 14 Dec 2023 19:40:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDqct-0007vb-VB; Thu, 14 Dec 2023 13:40:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDqcs-0007vM-Ib for guix-patches@gnu.org; Thu, 14 Dec 2023 13:40:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rDqcs-0008VS-7c for guix-patches@gnu.org; Thu, 14 Dec 2023 13:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rDqcr-0000D4-If for guix-patches@gnu.org; Thu, 14 Dec 2023 13:40:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67512] [PATCH 0/5] Add LibreWolf Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 14 Dec 2023 18:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67512 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ian Eure Cc: 67512@debbugs.gnu.org Received: via spool by 67512-submit@debbugs.gnu.org id=B67512.1702579190773 (code B ref 67512); Thu, 14 Dec 2023 18:40:01 +0000 Received: (at 67512) by debbugs.gnu.org; 14 Dec 2023 18:39:50 +0000 Received: from localhost ([127.0.0.1]:50913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDqcg-0000CP-7g for submit@debbugs.gnu.org; Thu, 14 Dec 2023 13:39:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDqcf-0000CA-38 for 67512@debbugs.gnu.org; Thu, 14 Dec 2023 13:39:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDqcZ-0008A9-VR; Thu, 14 Dec 2023 13:39:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=cT25ZJq3RZrD8hyIVaAJRSfhC2eHfAaNW2LRzHYyoSQ=; b=Y4kwjfn2r5/iXRGAOSkm wWmiH0jmJnRnmWX8BVNEP7/gFQP87f/PKi6kPeCY0sBN73pwx8YjJhIFM61UisgIxv4QW13T+Da5s QMqpAoi0vMaBPLLHlFk+XncNnOsgWkdRC0XjAqmtiX8adG7bk1wEwLq3xh4rBq8/iGJK9Jl1OBR9p vdFD51c3FZy3WVXHjWJGgnmuDw+uVHUKc9u9NdO1YfRmmaV7AwPDe8Ue7RvZCDBe82lCkyrthx1qY jgvJ/iSJTpz19XNAXqfUh4a69+NdRAH8QNkP1e8Z4eLr/+c4hdetg6eH71jIHUeUmcMamNRaXqptq snI+myt7nGTNQg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87h6kpk7db.fsf@retrospec.tv> (Ian Eure's message of "Sun, 10 Dec 2023 14:28:35 -0800") References: <878r613em1.fsf@gnu.org> <87h6kpk7db.fsf@retrospec.tv> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 24 Frimaire an 232 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de l'Oseille X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 14 Dec 2023 19:39:40 +0100 Message-ID: <87sf44tyqb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -3.95 X-Spam-Score: -3.95 X-Migadu-Queue-Id: 1163D4259D X-TUID: k22YT3N3fIQb Hi Ian, Ian Eure skribis: > Ludovic Court=C3=A8s writes: [...] >> This is much appreciated! People often complain that IceCat is >> based on >> too old a version of Firefox, so if we can have LibreWolf (or even >> Firefox without its problematic bits), that=E2=80=99s great. >> > > IMO, LibreWolf pretty much is Firefox without the problematic bits. > It=E2=80=99s been my default browser for several years, and I=E2=80=99m v= ery satisfied > with it. Perfect, then. >> As the person who made the changes, it would be great if you could >> pinpoint things that had to be changed compared to =E2=80=98icecat=E2=80= =99. What >> phases or flags differ? What phases can be factorized? >> > This work isn=E2=80=99t based on the icecat package, but on the firefox-e= sr > package from nonguix. The duplication I refer to is two small helper > functions, `runpath-of' and `runpaths-of-input', totaling nine lines > of code; they=E2=80=99re flagged with a comment in the patch. As mention= ed in > the cover letter, I=E2=80=99m happy to extract these, I just don=E2=80=99= t know where > they ought to be placed. They=E2=80=99re defined inside a lambda in a ge= xp, > which sounds like it may be challenging to put somewhere accessible to > both packages. > > Skimming the icecat package, not many of the build steps are shared > with librewolf, and factoring the commonalities out would IMO result > in overly complex, brittle, hard to maintain code that=E2=80=99s worse th= an > the slight duplication between the two packages. If there=E2=80=99s a st= rong > feeling that they must be accounted for, I=E2=80=99ll give it a try, but I > don=E2=80=99t believe that it=E2=80=99s the best option. Yeah, you=E2=80=99re right that factorizing can be a bad idea when misplace= d, so let=E2=80=99s keep it that way. I=E2=80=99ll take a closer look at the patches if nobody beats me at it! Thanks, Ludo=E2=80=99.