From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id yCvsBrhvf2XMhAEAkFu2QA (envelope-from ) for ; Sun, 17 Dec 2023 23:01:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id CPreALhvf2VTOgAA62LTzQ (envelope-from ) for ; Sun, 17 Dec 2023 23:01:28 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=axU8le1x; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702850487; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HBwFZUY5o/iG2JGwxSO59sQjZPsJ/2Fp2Uns1jZL7+w=; b=t2K0qhuruCGgfBT8TKgAGdDhqEK2qRTKnhAVJ6GTQhBbJF91TbmSr1r2VCIgFiiAfPSdaL BoTb/sWejJiGweIoTRFwEQC6EdH/FSRnTTuAi1vDON0LlH0wUNSXMLMG0LIYZgs89z6g8H yimFzr+TQkBgPEIjB1uoiOMttJPUuY1jTftWs2qSwFVSGx+PmWbHbKRrHFlFrU/DTT+D3G a1+mlg81mcrO+IaFvVP3OU2/BhNsb8zmcUgHO8K0b+q6QX/AbYPNquwGAmyeHsk7Oh1h9q ExGz2lGVkZgE1nxG9qkfsCC4sbGqLVT3pDTrNpnyOp8u9Qyf3wy0f+7WzBZw5g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1702850487; a=rsa-sha256; cv=none; b=M83B/0Ye6Io8s6k6nifiauQ4ZVckntREGkWm9rrvmc+ZRHSsBnkPWdpEY09p8CXLdoOFL7 m8p2TP6IgUgmsVqnUmIqrGpEo2kNVrrX3/hfL0rxBlVs1/USvZ2Lfvg/b1xR/ckMlvleOR sCGGg582ufNqw2sQz+c14wbZdOUEj0g2t1ukG9g+F8yVj/ZIPrU/JDjlqiuBaHrbwsAeUM 6WI27CqdorPZER+GMNjkkcy8LO/R0XChlTxf7bR2VFG5F2OAB2ALiO4VDs8/HOjVfVW8pW iQ7V8UOIM7VFejnQKqcwYj2WDaUbaoNjdICV/Yrxgbe0iB5/SyJIglyBSdurIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=axU8le1x; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C87CF42E75 for ; Sun, 17 Dec 2023 23:01:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEzC3-0005Ak-5Q; Sun, 17 Dec 2023 17:01:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEzC1-0005AS-A4 for bug-guix@gnu.org; Sun, 17 Dec 2023 17:01:01 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEzC1-0002LR-2F for bug-guix@gnu.org; Sun, 17 Dec 2023 17:01:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEzC2-00052e-9Q for bug-guix@gnu.org; Sun, 17 Dec 2023 17:01:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#67839: shepherd: sometimes hangs on `guix system reconfigure` Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 17 Dec 2023 22:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67839 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Attila Lendvai Cc: Attila Lendvai , 67839@debbugs.gnu.org Received: via spool by 67839-submit@debbugs.gnu.org id=B67839.170285041312817 (code B ref 67839); Sun, 17 Dec 2023 22:01:02 +0000 Received: (at 67839) by debbugs.gnu.org; 17 Dec 2023 22:00:13 +0000 Received: from localhost ([127.0.0.1]:59090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEzBE-0003K0-QL for submit@debbugs.gnu.org; Sun, 17 Dec 2023 17:00:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEzBD-0002t9-1N for 67839@debbugs.gnu.org; Sun, 17 Dec 2023 17:00:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEzB5-00022G-HN; Sun, 17 Dec 2023 17:00:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=HBwFZUY5o/iG2JGwxSO59sQjZPsJ/2Fp2Uns1jZL7+w=; b=axU8le1xwPXmaNIqWspq YaDgbMp3B4uB3GZCaOIhtwcHx4pYkV8uAzi1rHbWfscyWWuJuxgRQwje9xKG6jlWDk6Oa9CSlGm0E bCYIJN3KdX/yrc/ngzFe9JfBLRQKGirxH2TrpipMbnJ2ra7nfcV3YHjv3NUfOJ4eJxnDqyYwUr7nI CnzKNGf1R0LSD6M2eJcIMtYNg8p+TdaOE3FGwVoeIUTz+nHK/2ATDSZ261vbl5cmQEWzmW7Miy9nc 0nYYndfSeXWdpTZzf34v6IzlsOI3XRAh4sjZ2+PxSs3E9PfjkjN/BO7C09A4WUXjAk9DrfKdaQ8Q5 +ef5Fmn7sm8EeQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20231217004424.28303-2-attila@lendvai.name> (Attila Lendvai's message of "Sun, 17 Dec 2023 01:44:24 +0100") References: <20231217004424.28303-2-attila@lendvai.name> Date: Sun, 17 Dec 2023 22:59:59 +0100 Message-ID: <87sf40qylc.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.71 X-Spam-Score: -6.71 X-Migadu-Queue-Id: C87CF42E75 X-Migadu-Scanner: mx11.migadu.com X-TUID: /qYo6kEXHAyR Hi Attila, Attila Lendvai skribis: > * modules/shepherd.scm (main): Switch with-service-registry and > with-process-monitor. This way the parameterize of the process monitor c= overs > everything else. This fixes the bug that caused `guix system reconfigure= ` to > hang in certain situations. Fix proposed by @emixa-d at: > https://github.com/wingo/fibers/issues/29#issuecomment-1858922276. [...] > * modules/shepherd/service.scm (spawn-service-controller): Add two assert= s. > This is the bug that causes `guix system reconfigure ...` to sometimes ha= ng, > and subsequently all shepherd commands, because a match-error flies out f= rom > the service-controller of a replaced service, and thus its fiber dies. T= hese > asserts get triggered without the previous commit that fixes the issue. Good catch!! I pushed these patches with small edits, in particular adding a test that reproduces the bug without relying on assertion failures: 5dbde1c support: =E2=80=98assert=E2=80=99 logs source location informatio= n. 0bcf02a Update NEWS. c07f0a8 service: Add asserts to ensure a process monitor is running. 9be0b7e shepherd: Make sure =E2=80=98with-process-monitor=E2=80=99 covers= everything needed. Thanks for the tedious but fruitful debugging work! Ludo=E2=80=99.