From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id qIo9DeJhoWXiVwEAkFu2QA (envelope-from ) for ; Fri, 12 Jan 2024 16:59:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id aI9nBeJhoWX1hQEAe85BDQ (envelope-from ) for ; Fri, 12 Jan 2024 16:59:30 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=CAbPe8I7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705075169; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=S0OYBiDazU6MuOtfYiWP80siFfsYW3FFKXtmu3YvBBE=; b=DeEy3mQtw4C/ngefijbmgbSYS0JDqDWEwwnaF7g9m0XjGIDhTrDqZhCFv+APvf6e+qxnw9 LLIExKRQ7ZVlJb+Qzk17IwXBri/olrv/XpYbr6xmI5R74Vt3ymkTMvm4vubR2yD1TYPcDU LI4P8Qbrof4TW3Rey/CVHBzhgyPBEnid0vIO6VOWvbF0gnJE9i2moEApNK49+0gT3nAgyT 46rBzDcb8yrwJhQdCiCmmXWV7Q3yiphoUiYSOrc+gdW65L+gWdhC8MpX/5d9o3+E/n4ZR9 NSFXwohvT6GKP0BbyukDM07wlxhELgZwH7x0H2XXiFWO0dZg7nJAxXld+MgkOg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=CAbPe8I7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705075169; a=rsa-sha256; cv=none; b=BqvKbpMeD9dUHMmXoyX1HVYeyIh+SWSdBessA7PO2vmiy5enTaukb65UAAHB3aG+gSfLuA OmrehFulDiZJ4KSro3awkFKs+OneCwAwl4YUEHw5NYQYFINpOC4lqRUwT2+moMbEbOsuZq WxnDsa2jGrLtmI5UcFe6vYuDK3gkxbVAksoNi3jkLhEJZ7JfLEfRg1rBefMRjmwNrzDIub tJQXEeF7ghC4HGNprLwTE2S8d9puOHSRwrC9AbVYZhu2+dG6lbDNrQK9DciYAeiZKGmkCq XrG2n+GYrUGdMWSBByvtU7BhM+UrqMg5j9yqZzaIqOBkzXgzg0JkAQlnuIixnQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D1F6BAE74 for ; Fri, 12 Jan 2024 16:59:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOJw5-0000X9-MX; Fri, 12 Jan 2024 10:59:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOJw3-0000Wu-Av for guix-patches@gnu.org; Fri, 12 Jan 2024 10:59:07 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOJw0-0003Vb-58 for guix-patches@gnu.org; Fri, 12 Jan 2024 10:59:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOJvy-0008Cy-4g for guix-patches@gnu.org; Fri, 12 Jan 2024 10:59:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68405] [PATCH v2] guix: download: Add support for git repositories. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Jan 2024 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68405 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 68405@debbugs.gnu.org Cc: Romain GARBAGE Received: via spool by 68405-submit@debbugs.gnu.org id=B68405.170507508631485 (code B ref 68405); Fri, 12 Jan 2024 15:59:02 +0000 Received: (at 68405) by debbugs.gnu.org; 12 Jan 2024 15:58:06 +0000 Received: from localhost ([127.0.0.1]:37303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOJv4-0008Bl-CP for submit@debbugs.gnu.org; Fri, 12 Jan 2024 10:58:06 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:64110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOJv0-0008B5-Ir for 68405@debbugs.gnu.org; Fri, 12 Jan 2024 10:58:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=S0OYBiDazU6MuOtfYiWP80siFfsYW3FFKXtmu3YvBBE=; b=CAbPe8I72geRlgmDFHfkvKIHFOP1suklDgLDYMh6tICxxw//RWn+HrhW mPp8MyCsVa+N0IbaOatMvdLASfbzwjF2SN56r9mCJWshBNNb2LXk+oV07 1R1bSwhBtm/nGDaWHgoeHgUCRSnkC1N7L5Tw46qifyMyngbK3jGJAiqYg w=; X-IronPort-AV: E=Sophos;i="6.04,190,1695679200"; d="scan'208";a="146377462" Received: from unknown (HELO ribbon) ([193.50.110.52]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2024 16:57:58 +0100 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20240112151411.22470-2-romain.garbage@inria.fr> (Romain GARBAGE's message of "Fri, 12 Jan 2024 16:12:19 +0100") References: <20240112151411.22470-2-romain.garbage@inria.fr> Date: Fri, 12 Jan 2024 16:57:57 +0100 Message-ID: <87sf32ilx6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 2.10 X-Spam-Score: 2.10 X-Migadu-Queue-Id: D1F6BAE74 X-TUID: 56JIBT6dt0HP Hello! Romain GARBAGE skribis: > * guix/scripts/download.scm (git-download-to-store*): Add new variable. > (copy-recursively-without-dot-git): New variable. > (git-download-to-file): Add new variable. > (show-help): Add 'git', 'commit', 'branch' and 'recursive'options > help message. > (%default-options): Add default value for 'git-reference' and > 'recursive' options. > (%options): Add 'git', 'commit', 'branch' and 'recursive' command > line options. > (guix-download) [hash]: Compute hash with 'file-hash*' instead of > 'port-hash' from (gcrypt hash) module. This allows us to compute > hashes for directories. > * doc/guix.texi (Invoking guix-download): Add @item entries for > `git', `commit', `branch' and `recursive' options. Add a paragraph in > the introduction. > * tests/guix-download.sh: New tests. Full disclosure: Romain and I work together at Inria. I=E2=80=99ve reviewe= d the changes and they LGTM, but we=E2=80=99ll leave time for others to chime in. Ludo=E2=80=99.