From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 6Gz1MnbdsmXhZgAA62LTzQ:P1 (envelope-from ) for ; Thu, 25 Jan 2024 23:15:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 6Gz1MnbdsmXhZgAA62LTzQ (envelope-from ) for ; Thu, 25 Jan 2024 23:15:18 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=gY71W2H6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706220918; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=rBZ0C/XpATulhSCZOVcjakwxGZRReYovlvFsjFYpfYw=; b=qS1tDMHoqdV82T+MACcuM7jeddkLcmByvsgJUwd05L916EAdiOdLdBx3ZtGz5/3xk3xkii HeYR8YoFa7KKZzTxu103nPfKtotRfdWcVGaDuaQJQuNJpVfbFw2fOzRDsDSWMdtVZjLsiP zkfOQ1qyM59htUbpHsZprHhZVw+YEmJtDE1OFCEwHPpb194cV9M/C9AVjv0G/ACWAQGWzZ rDIGhWUcEpQn/Aqlx2qDEnZpYAhV/65QfiljZVBkVD2oOKAoEgdOVC1dmVdyNgFTjj+l/F 3Kr8YfMOTsvTAaAkz1i5d2b6W5iBEpLVMjRqAkQ2m1klN2I+YWIr3hjU8C9PNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=gY71W2H6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706220918; a=rsa-sha256; cv=none; b=uQwsD12s6/fixdGiDUipXu/6x4b07Gi5Z0BgIrSClmSgGZFGZKDog+3f+E2+kPm61H8tCc 3Ksa2G2qKwi1Ii93xUWdkN3YezViJyMl4aP+7OzQV5HDYmBQMWdRAka+zu1+ntAim92CQR 37rMcKyKrTRKYZ5iX1Lv+WHBnxrg07/7euzVlbIarU3QzuNe0hgJir9KN6awVBVEAL8mMM 4jUxZj1guEp6nnFOWnO3uDQcyFMeUtQqpeY4L1nkxnz4KxFw6i1kozRYrb5wMHV9LRETUZ xfpMnaz/UcYzbOlEsaKfdv0mCwHMk4kyqDYyDP3GHQ6iQ1wLRRMn6a+tsy852Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A354D3D59E for ; Thu, 25 Jan 2024 23:15:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rT7zt-0005yf-Tm; Thu, 25 Jan 2024 17:14:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rT7zs-0005y1-LU for guix-patches@gnu.org; Thu, 25 Jan 2024 17:14:56 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rT7zs-0004Qe-D8 for guix-patches@gnu.org; Thu, 25 Jan 2024 17:14:56 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rT7zy-0003Gi-40 for guix-patches@gnu.org; Thu, 25 Jan 2024 17:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68696] [PATCH] gnu: Add guile-lmdb. Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 Jan 2024 22:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68696 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Artyom Bologov Cc: 68696@debbugs.gnu.org Received: via spool by 68696-submit@debbugs.gnu.org id=B68696.170622089312533 (code B ref 68696); Thu, 25 Jan 2024 22:15:02 +0000 Received: (at 68696) by debbugs.gnu.org; 25 Jan 2024 22:14:53 +0000 Received: from localhost ([127.0.0.1]:49470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT7zp-0003G5-39 for submit@debbugs.gnu.org; Thu, 25 Jan 2024 17:14:53 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:56567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT7zj-0003FQ-NR for 68696@debbugs.gnu.org; Thu, 25 Jan 2024 17:14:48 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40eac352733so54822535e9.0 for <68696@debbugs.gnu.org>; Thu, 25 Jan 2024 14:14:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706220876; x=1706825676; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=rBZ0C/XpATulhSCZOVcjakwxGZRReYovlvFsjFYpfYw=; b=gY71W2H6gd7WxxBDvu9F2N1upvTSPnWAOwBPKO3vZZHLIwaBEgM4FHZ30Kh86YY82h Ch36uMh3a3sLV/oKUgbvB0Oef3g0YjxnVmtTFF6CjKI3ze8xY7ruh6U6PKChXLMa9Rq2 Hr06MHQshyQTf03PNI+3R7rFoPhlsQFlw+myvDIz52NkV+5rt+OyOnVYO79LF5uk6OWa xqMMU/0AUf8dwNTHVb7eq/e2r1Prm23lj6c/hAgYqLFCog/KNBtiA9qFVwrVgBRF0qss chPT41DN8y5jAhSEDxr9Yqsk9hWH3xhlf2i1rEIQKoIrlnIyS27kIqPzpDTCuQyUxgqu s0dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706220876; x=1706825676; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rBZ0C/XpATulhSCZOVcjakwxGZRReYovlvFsjFYpfYw=; b=UlVXEy1ZRofkc+GfusIV4ol4LsTTOAsKzhDXqriN1yqU0nYOmlwR2Z+K8piHjPjm1Y ym3eq4PrR+ZoQmbDX5YnXpvtCUZBcsm0xS9+0ANzkq3FZfYwaENcMDFcfaYmvTS9s4tl JWjcizkC+NZldH7xVnmS7amGt9+o3LezxBJqwpcw94jeGZnZ+f+tCzSQVzqH+ViTLNvU YyqbXGyjsntoCIf/bWTcvv5Ueptw2AXCqLB8DEVAm86hfT/ylgj4thIhrve8qp/E0Zj2 8O49/po2r3Oo9KYWodkM7CDLXS6f8cTSn1U7QwUXcNFh0v05szl9iP0+iNpORrvnv+mO UsEg== X-Gm-Message-State: AOJu0YwVBJIHft65YhvXvKEEaTPe0guFxCDo+R2CxaLCWznSFGj5P1Kx HZJxAiPp9GM9r5wUXiGFEhf7N8SfYhfTr218o+4cutwLaGO9fsMWD29M0iFeGWo= X-Google-Smtp-Source: AGHT+IEMekDRMrvPhQJ8BNhlw+WcqDvTW/3qm7EmSAcZn0l6d95v9qh//nlK4DmH+FwW7Ir+QwWKMQ== X-Received: by 2002:a05:600c:1c9c:b0:40e:d2b6:ba44 with SMTP id k28-20020a05600c1c9c00b0040ed2b6ba44mr215938wms.31.1706220875580; Thu, 25 Jan 2024 14:14:35 -0800 (PST) Received: from guxtil (cpc100856-bagu15-2-0-cust368.1-3.cable.virginm.net. [82.25.93.113]) by smtp.gmail.com with ESMTPSA id ay17-20020a05600c1e1100b0040ec7a6d39esm3858583wmb.16.2024.01.25.14.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 14:14:34 -0800 (PST) From: Sharlatan Hellseher In-Reply-To: <87le8eedrb.fsf@aartaka.me> (Artyom Bologov's message of "Wed, 24 Jan 2024 23:21:50 +0400") References: <87le8eedrb.fsf@aartaka.me> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Thu, 25 Jan 2024 22:14:32 +0000 Message-ID: <87sf2ljc1j.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 0.24 X-Migadu-Queue-Id: A354D3D59E X-Spam-Score: 0.24 X-Migadu-Scanner: mx11.migadu.com X-TUID: MW0akgqKUiaf --=-=-= Content-Type: text/plain Hi, Thank you for patch! >+ (package >+ (name "guile-lmdb") >+ (version "0.0.1") >+ (source (origin >+ (method git-fetch) >+ (uri (git-reference >+ (url "https://github.com/aartaka/guile-lmdb") >+ (commit "438143ca9ba157faec6f4c2740092c31c733fbfe"))) >+ (file-name (git-file-name name version)) >+ (sha256 >+ (base32 >+ "0p43c8ppbhzpi944in0z2jqr7acl8pm7s1x0p5f0idqda6n6f828")))) As this project has no version tags, take a look at how the package style may be altered in this case. (gnu packages lisp-xyz) contains quite a lot of examples without releases. --8<---------------cut here---------------start------------->8--- (let ((commit "438143ca9ba157faec6f4c2740092c31c733fbfe") (revision "0")) (package (name "guile-lmdb") (version (git-version "0.0.1" revision commit)) (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/aartaka/guile-lmdb") (commit commit))) (file-name (git-file-name name version)) (sha256 (base32 "0p43c8ppbhzpi944in0z2jqr7acl8pm7s1x0p5f0idqda6n6f828")))) --8<---------------cut here---------------end--------------->8--- - revision :: bumps on every package update in guix, starting from 0. > + (arguments > + '(#:source-directory "modules" > + #:phases (modify-phases %standard-phases > + (add-before 'build 'substitute-lmdb-so > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((lmdb (string-append (assoc-ref inputs "lmdb") > + "/lib/liblmdb.so"))) > + (substitute* > + '("modules/lmdb/lmdb.scm") > + (("liblmdb.so") > + lmdb)) > + #t)))))) You may simplify this part a little by using G-Expressions: --8<---------------cut here---------------start------------->8--- (arguments (list #:source-directory "modules" #:phases #~(modify-phases %standard-phases (add-before 'build 'substitute-lmdb-so (lambda _ (let ((lmdb (string-append #$(this-package-input "lmdb") "/lib/liblmdb.so"))) (substitute* "modules/lmdb/lmdb.scm" (("liblmdb.so") lmdb)))))))) --8<---------------cut here---------------end--------------->8--- - this-package-input commonly used replacement for (string-append (assoc-ref inputs ... - lambdas in phases don't need trailing #t. > + (synopsis "Bindings for LMDB (Lightning Memory-Mapped Database) in Guile.") You need to drop full stop in the end of synopsis, and may use full description instead of acronym+description. > (description "Scheme wrapper around liblmdb.so. It may be rephrased as "This package provides a scheme wrapper for liblmdb.so." > +@end itemize\n") You may drop \n here. Please take a look at review points, and apply guix lint in the end. Looking forward for V2! Thans, Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmWy3UgACgkQdtcnv/Ys 0rW3oxAAquUyTZbU29/sSgcUEDkQB9su5C/CTGkYnyne5kQi/mflMhYyauxWWWsH 3LQpmvLtBdDtoAN9+Fe0lgdFlvRHiNhaxHU+dVQnf7/dMANyY9tdXsVmjOmB6JXx Gg0WeL6gWHfCkZ1wZnAcUUZ46eMfPbP8palERZuj/dhZLrK/IX6sLSNRpmXGFQRu 553UbD3aeER3cw6WX8n47HTnLWpczaQGl2P5m+IAxd5+7UdUiOmMjzXoyB2KTvx9 Vn05sHSWdlGdYM3wB5dC3zhjipBbdQJz+8tVNs51JyeVUVLRC/syb89CyOqW9PJY NzY7jggwoUYDvSgdWtk7cuPdVbrdE3Zcq+jXyQG/CygDgCB0wCnqf+buKMwOhz/9 TRsvV74brsHXMlMQV2j8gU2Z+98F/L2he4ZbS8qB/XdT78ZuuqzI0GywKJYUCImc mifGK+DuJUna1jAR27Cxzw+w4HcENV8uoocwDlrQjGMJ/4vO+gJ1Oi1PfSQxRbO1 LGHfRnLvf62QP0qCUlkjK97pm6SumCfI+5GlSkvaPjBMHyYV8dg0Y2Jm4Xfr1/9u A+KK2g6GILeLzrRvH4cGzlfhbzolDzaT7CN2b0U0uKavsFEKBNuTnEo5caWidyGK TolloX0yOUKCFbEn8DSt1d6j18YoJz/IeIq/dyVmfgCfAfZhKXg= =fIx5 -----END PGP SIGNATURE----- --=-=-=--