From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id WBVmBAkh+2XfJAAA62LTzQ:P1 (envelope-from ) for ; Wed, 20 Mar 2024 18:46:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id WBVmBAkh+2XfJAAA62LTzQ (envelope-from ) for ; Wed, 20 Mar 2024 18:46:49 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710956809; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=xV7suBTi0QkXsvdKi0q2Q45hxj6pIvxAMqB76qsBhoA=; b=NjPqABTQjKb2b7B8Ae0YpxyFxzS57xjb/WZMArv0GK8LPVKT9FskLGFCIojYjMvBlT/XDg 5tXiGsa0F+0M35a2RRa/WDP1ukiiALjYaUGO4il9cpT/OMYw09PamhfMqseF7rKQXa+C42 pIpJN2Xcgl6P9Ant02IVr3i8pNK37/js515u8Biwl+rwyGoLoMjH3Kij1sc1qXTdSNEE5Z HTQE5UiKNFqXq5njH/6qlzLLZXtmobK0HWFOA8fUsgFO3haFishYUoy/+pVlTCph3N0HgB HphNOgO4rnx4kXb3nYPAPeogohKqsvU6uTgcd1R8EiYAoRiMrs5SeN7V2xUvFw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1710956809; a=rsa-sha256; cv=none; b=oB7THedzMlbKE9C5T8a1tQH5taXvR40dyo+4uWgcrINDpC+bOWw4PSQgxOp/lfcUdBY95J fczhzQNtsJ9p6x0LEqDWJMXa4cjujZyA7DnDEHE09kUScMYNFayAMNLWg29h47xJw+vXVa KY0oeT2xeV/gYUl///pAdV/IOEDiWcAA/0YOdDks9yn7Mn0XgpWM0Fk3bQgdZA+AwHU5m2 oPSXDlyGDoOKy3L+cm0RVk8l19asaUOlfQ4Z8Ih/HUgk/c65QP+82BlkzH1HvB6VX3j3la rpjK71MIrLZQFsIqb2bxBrSfltmQCV+PWhc7S65cbTnDXyEgDfppux5LROrgYQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 863651A476 for ; Wed, 20 Mar 2024 18:46:48 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rn01F-0007HC-1A; Wed, 20 Mar 2024 13:46:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rn019-0007G8-2f for guix-patches@gnu.org; Wed, 20 Mar 2024 13:46:23 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rn018-0004OT-Q1 for guix-patches@gnu.org; Wed, 20 Mar 2024 13:46:22 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rn01m-0004dF-7b for guix-patches@gnu.org; Wed, 20 Mar 2024 13:47:02 -0400 Subject: bug#69579: [PATCH] gnu: python-joblib: Update to 1.3.2. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 20 Mar 2024 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 69579 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves , Vagrant Cascadian , 69579-done@debbugs.gnu.org Mail-Followup-To: 69579@debbugs.gnu.org, mail@cbaines.net, ngraves@ngraves.fr Received: via spool by 69579-done@debbugs.gnu.org id=D69579.171095679117723 (code D ref 69579); Wed, 20 Mar 2024 17:47:01 +0000 Received: (at 69579-done) by debbugs.gnu.org; 20 Mar 2024 17:46:31 +0000 Received: from localhost ([127.0.0.1]:52902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rn01F-0004bh-Q8 for submit@debbugs.gnu.org; Wed, 20 Mar 2024 13:46:31 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rn01A-0004bM-UI for 69579-done@debbugs.gnu.org; Wed, 20 Mar 2024 13:46:28 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id D817127BBE2; Wed, 20 Mar 2024 17:45:43 +0000 (GMT) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 4547a191; Wed, 20 Mar 2024 17:45:41 +0000 (UTC) References: <20240306093803.4725-1-ngraves@ngraves.fr> <87ttlgbh6y.fsf@wireframe> <87ttlaljc9.fsf@ngraves.fr> <87plvyuwxj.fsf@cbaines.net> <87wmq6p907.fsf@ngraves.fr> <87bk7f2to3.fsf@ngraves.fr> <87plvuqsww.fsf@cbaines.net> User-agent: mu4e 1.10.8; emacs 29.1 From: Christopher Baines Date: Wed, 20 Mar 2024 17:45:07 +0000 In-reply-to: <87plvuqsww.fsf@cbaines.net> Message-ID: <87sf0kkda4.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -8.42 X-Spam-Score: -8.42 X-Migadu-Queue-Id: 863651A476 X-Migadu-Scanner: mx12.migadu.com X-TUID: a600euW6hKg7 --=-=-= Content-Type: text/plain Christopher Baines writes: > Nicolas Graves writes: > >> On 2024-03-13 14:16, Nicolas Graves wrote: >> >>> On 2024-03-13 12:39, Christopher Baines wrote: >>> >>>> Nicolas Graves via Guix-patches via writes: >>>> >>>>> On 2024-03-08 12:29, Vagrant Cascadian wrote: >>>>> >>>>>> On 2024-03-06, Nicolas Graves wrote: >>>>>>> * gnu/packages/python-xyz.scm (python-joblib): Update to 1.3.2. >>>>>>> [build-system]: Update to pyproject-build-system. >>>>>>> [arguments] >>>>>>> <#:phases>: Remove check phase. >>>>>>> <#:test-flags>: Keep former test flag. >>>>>>> [propagated-inputs]: Add python-psutil. >>>>>>> >>>>>>> Change-Id: Ide110a19431b1d26e1d7dd8d1adc3b3f0f417749 >>>>>>> --- >>>>>>> gnu/packages/python-xyz.scm | 22 ++++++++-------------- >>>>>>> 1 file changed, 8 insertions(+), 14 deletions(-) >>>>>>> >>>>>>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm >>>>>>> index 46232d3c98..122dca6e4e 100644 >>>>>>> --- a/gnu/packages/python-xyz.scm >>>>>>> +++ b/gnu/packages/python-xyz.scm >>>>>>> @@ -6169,26 +6169,20 @@ (define-public python-pystitcher >>>>>>> (define-public python-joblib >>>>>>> (package >>>>>>> (name "python-joblib") >>>>>>> - (version "1.1.1") >>>>>>> + (version "1.3.2") >>>>>>> (source (origin >>>>>>> (method url-fetch) >>>>>>> (uri (pypi-uri "joblib" version)) >>>>>>> (sha256 >>>>>>> (base32 >>>>>>> - "0019p280s2k941mihl67l7y6amwx86639xp3zvpsg1lmyish67rh")))) >>>>>>> - (build-system python-build-system) >>>>>>> + "1cbjjzsh9hzaqr2cqja95673p7j88b8bd02hjpkq8xz147k6by4j")))) >>>>>>> + (build-system pyproject-build-system) >>>>>>> (arguments >>>>>>> - `(#:phases >>>>>>> - (modify-phases %standard-phases >>>>>>> - (replace 'check >>>>>>> - (lambda* (#:key tests? #:allow-other-keys) >>>>>>> - (when tests? >>>>>>> - (setenv "JOBLIB_MULTIPROCESSING" "0") >>>> >>>> We should look at why this was added, and whether it should be kept. >>> >>> This is only present in the check phase, not in the final package. I >>> guess when we switched to the pyproject-build-system or simply updated, >>> this simply wasn't necessary anymore. >>> >>> Since tests were consistantly (--check) passing, I do not see the need >>> to investigate that. >> >> Christopher, is that good enough of an explanation to get this one >> merged or would you rather have mpe really investigating it? > > I think it's good to check the commit message at least: > > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=a41f93c39d03143ce9007ad278a04fa30498bc0b > > Given that there's no reasoning there for this change, I think it's fine > to remove. I've gone ahead and pushed this to master as a24aa227f72544ae4b95510c62f968d219148efc. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmX7IMNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfoFg/+NuW4KcdzFkfD8H1bM13kYjwjJjFb4uZx 9aO7OTlxI9G7oCGGsY944Og1mf2wp5z5jWn/AlDCucNq9GrRtQSYIwz3slj6C1i8 32CbqrAmNyufczlh1wSIYxccNU1NbY95Xo9EiQD/awpt6EvbHlilQRYNOjAmxRaC ttf4UWrN0iv5q2n4tmWALVhuaJ3GV+D+AUxNhVahK7urRQX+WlYOX/5+oUbcWizT xO2dC14z9MTWJ/AIgbvOWzR+WPXQWpJVUxuynikH4HmzToDuwGf3HVpdw928gjIw 2SH4NtIGNBiTPZEDR+t2bZXahPa/fdqptODvL2pBypw783ue37AhMOsuA6q3Ze8B ub/R6W0CAHBGDBp1Bb/OsGpUA/Z5FPIdns85vRlkaBu4ICM+UMzFNkfvZJCZBczz lurbE33SAbr49hzy96hUMP1O4LliX1YIrJsi7bnWyJQigyI/g25ZKVFTcKVo2wxG oONtLTvcsD1FtImBxSZnzqaysMHbvoTcx7T2zOJj5JDNOJxQIbYwvAXJz7Rk9zWD I+S65ptGdDPZXN9qncq1K2WEr1aBfYFiZkQ5gJCsBpdSDNDoacJ2aKPIfw0q7+H6 gLgpj/Mz8gPayI6c+R9DROcYT4XoDQidGykD78wULja38IydfkD2HX7rO08awdgG 9XIiP3df8M8= =tqS9 -----END PGP SIGNATURE----- --=-=-=--