From: "Ludovic Courtès" <ludo@gnu.org>
To: Ahmad Draidi <a.r.draidi@redscript.org>
Cc: 70285@debbugs.gnu.org
Subject: [bug#70285] [PATCH 2/3] services: cuirass: Add new configuration options.
Date: Mon, 29 Apr 2024 23:33:31 +0200 [thread overview]
Message-ID: <87sez3zwes.fsf@gnu.org> (raw)
In-Reply-To: <7ccac410c5f7d0c9b27c828bc088c485f22884a8.1712576504.git.a.r.draidi@redscript.org> (Ahmad Draidi's message of "Mon, 8 Apr 2024 21:54:13 +0400")
Hi Ahmad,
Ahmad Draidi <a.r.draidi@redscript.org> skribis:
> * gnu/services/cuirass.scm (<cuirass-configuration>): Add ttl and threads
> fields.
> (cuirass-shepherd-service): Handle the new options.
> * doc/guix.texi (Continuous Integration): Document them.
[...]
> + (ttl cuirass-configuration-ttl ;string
> + (default "30d"))
For consistency with <guix-publish-configuration>, I would make it an
integer (number of seconds).
If that’s fine with you, could you send an updated patch or let me know
if I should make this change on your behalf?
The rest of the patch series looks good to me!
Thanks,
Ludo’.
next prev parent reply other threads:[~2024-04-29 21:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 17:48 [bug#70285] [PATCH 0/3] Cuirass service config options work Ahmad Draidi via Guix-patches via
2024-04-08 17:54 ` [bug#70285] [PATCH 1/3] services: cuirass: Use separate extra options for cuirass web process Ahmad Draidi via Guix-patches via
2024-04-08 17:54 ` [bug#70285] [PATCH 2/3] services: cuirass: Add new configuration options Ahmad Draidi via Guix-patches via
2024-04-29 21:33 ` Ludovic Courtès [this message]
2024-05-02 1:36 ` Ahmad Draidi via Guix-patches via
2024-05-04 16:21 ` bug#70285: " Ludovic Courtès
2024-04-08 17:54 ` [bug#70285] [PATCH 3/3] services: cuirass: Remove use-substitutes? configuration option Ahmad Draidi via Guix-patches via
2024-05-02 1:37 ` [bug#70285] [PATCH v2 1/3] services: cuirass: Use separate extra options for cuirass web process Ahmad Draidi via Guix-patches via
2024-05-02 1:37 ` [bug#70285] [PATCH v2 2/3] services: cuirass: Add new configuration options Ahmad Draidi via Guix-patches via
2024-05-02 1:37 ` [bug#70285] [PATCH v2 3/3] services: cuirass: Remove use-substitutes? configuration option Ahmad Draidi via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sez3zwes.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=70285@debbugs.gnu.org \
--cc=a.r.draidi@redscript.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.