From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id EPPLF+HuUmZP5QAAA41jLg (envelope-from ) for ; Sun, 26 May 2024 10:12:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id yNG4EeHuUmZwQwEA62LTzQ (envelope-from ) for ; Sun, 26 May 2024 10:12:17 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716711137; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=fSvdr2cndFiuJPCrKVv7RAJzc6awkt544yDXYT5Iffw=; b=S5H/Xlb9T9vOjIlciAQZbMRjYx5N4WwZoYzA9ahYuUDb4SCTkG8q2lOykmhW064ZImsGPK OxYf+AE8rcRHXdQ9TBULUq2NHk2os0lwE5iHqR/X75i/3b/pVsQw+y8J7wcBc0ttaR/Zy3 BQluLbadpN83fwsZQJlL3rMqesQxjo+xt479imyfI6QSIV3tEzelvJxmMENmalizNP8Kg0 9lJdJJGXqUAidTMWh1YFJxMWrMx5BEM8j4xN3O8uPUGJ/M2dUUDp8Rlwtx1MjHtD0ax4cu IyAATOxbyxOlIqptj1gBKZlIPVJqtoCY72iotaatX7VC85WjSXDIDTBc6gS1vg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716711137; a=rsa-sha256; cv=none; b=e+dDo9+CoILIPlqFFtJcaKF66sA6D0/OD8MSwWNyDFIgzJYLZRJqqvFjCswTPfc/RJ5ysg VTWZvNxCcQCXvMSx3BweKjw3JxcREQu7qwz4aMnMtX5wd8OyuMn72dcz+4FRsV8HworoyB 7y3rVxkZ7Nv4dorO13R2/9jcpMtUoSQDWGeY/2TfnisMQQGsDD3ckagsy5R7s7oEqikWox RzP77GIvDqvrg/PW2II2jIA9kWBgIuFIs/Xcll/2xwsoo73mqQR/6iF1wqgsXr5vFpplSX TT2b4H0FWj12WaTh/12ZcmAOCohhJRiDK+3Q1Tc+1w9tU9tZ2e/EHnLjYu48mQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BDF4873D40 for ; Sun, 26 May 2024 10:12:16 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sB8z2-0008Sd-92; Sun, 26 May 2024 04:12:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sB8z0-0008RQ-G7 for guix-patches@gnu.org; Sun, 26 May 2024 04:11:58 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sB8yw-00006v-MM for guix-patches@gnu.org; Sun, 26 May 2024 04:11:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sB8z4-0007kf-Ku for guix-patches@gnu.org; Sun, 26 May 2024 04:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71038] [PATCH 1/2] guix: store: Enable specifying the available builtin builders. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 May 2024 08:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71038 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines , 71038@debbugs.gnu.org Received: via spool by 71038-submit@debbugs.gnu.org id=B71038.171671108229719 (code B ref 71038); Sun, 26 May 2024 08:12:02 +0000 Received: (at 71038) by debbugs.gnu.org; 26 May 2024 08:11:22 +0000 Received: from localhost ([127.0.0.1]:38288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB8yQ-0007jH-EA for submit@debbugs.gnu.org; Sun, 26 May 2024 04:11:22 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB8yO-0007j9-Ox for 71038@debbugs.gnu.org; Sun, 26 May 2024 04:11:21 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 8B5DD27BBE2; Sun, 26 May 2024 09:10:41 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id badc66fd; Sun, 26 May 2024 08:10:40 +0000 (UTC) From: Christopher Baines In-Reply-To: <87a5ki3ygr.fsf@gmail.com> (Simon Tournier's message of "Wed, 22 May 2024 12:58:12 +0200") References: <87y187b6xv.fsf@cbaines.net> <6b9c634c024b6fd7a50d3b82edc244676a8ca8e8.1716038375.git.mail@cbaines.net> <87a5ki3ygr.fsf@gmail.com> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Sun, 26 May 2024 09:10:40 +0100 Message-ID: <87sey5f0xr.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -6.94 X-Migadu-Queue-Id: BDF4873D40 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -6.94 X-TUID: Qfcx/Ui9GNYX --=-=-= Content-Type: text/plain Simon Tournier writes: > On sam., 18 mai 2024 at 14:19, Christopher Baines wrote: > >> diff --git a/guix/store.scm b/guix/store.scm >> index 58ddaa8d15..0c734cdca7 100644 >> --- a/guix/store.scm >> +++ b/guix/store.scm >> @@ -571,7 +571,7 @@ (define* (connect-to-daemon uri #:key non-blocking?) >> >> (define* (open-connection #:optional (uri (%daemon-socket-uri)) >> #:key port (reserve-space? #t) cpu-affinity >> - non-blocking?) >> + non-blocking? assume-available-builtin-builders) > > Why add the variable %assume-available-builtin-builders and default to > it? > > Something like: > > --8<---------------cut here---------------start------------->8--- > (define %assume-available-builtin-builders > "List of builtin builders supported by the builder Guix daemon." > (list "download" "git-download")) > > (define* (open-connection #:optional (uri (%daemon-socket-uri)) > #:key port (reserve-space? #t) cpu-affinity > non-blocking?) > non-blocking? > (assume-available-builtin-builders %assume-available-builtin-builders)) > --8<---------------cut here---------------end--------------->8--- > > And then default to this %assume-available-builtin-builders elsewhere in > [PATCH 2/2]. IMHO, it changes almost nothing but it would help to know > (document) what to pass as argument. I think it's sensible to not use a fixed list by default, but check what the daemon supports. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmZS7oBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xf++A/+MLo6Soaxrz5sb8pCizVsRG9iCNpHwOZx pFyDWiOhN2QnbFY5GBn/duq3+a4oDvEhRz15u430jWFw0yolHhv+r/ylydYKvyGF qyJ1MZ+oACzk7wHF7JcER5TsAoJHrOqhgAUfXwdwFJNxCeKlsTTuF+al3Deyko5G /nxk/DkXSsTPLA2U7blalytkyICdj9Gu4LOOzRphXNNiw5u1+DDN++ZkrQ+ngGyl WprBhBnvRxHu9Rk/SQftFXLlpMmoRMLuYC2IWwpwqGB1/BeDv91GhcOHyiuGbajS tV+10kYigehOknNJhA5V0amtjWTZ61bZ9nzeNdpKBth1gg+phSuGi431s1fz29+A P3oHQgh3o94Mw5gVkaoIGe9rzChc5PFyAASh/5/1JaPFnAEn7ce3oYyBsNPFBmWs wvUG1kOt3AQ0r8Eb15k2ROx5rmLxMVVSP9xk2JcN8uA/bpwaXUhNv3IJkQoKpWqd YwiQ153TV6FvsIdL3gfafOnwNm9ut+6SCD3wwZdcVz6oXn29FDOHoqb3ZWgigs1F JcRJr7VnSiSSHTmpttw0aJViQUuackrEkQpEFtL7JFYX50z30Q+ezkC0EtH5F1Cv VbxVZFwH0TyImSVVRd+4rZdJh07uZlv+ZTPaSFyv48HkPsVX6p3IP5sL2xUwWbVK 9XLcduTy2Eg= =K8Wp -----END PGP SIGNATURE----- --=-=-=--