From: Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com>
To: 71023@debbugs.gnu.org
Cc: sharlatanus@gmail.com
Subject: [bug#71023] [PATCH 0/9] Update fzf to 0.52.1
Date: Tue, 04 Jun 2024 17:00:00 +0000 [thread overview]
Message-ID: <87sexs8wz3.fsf@gmail.com> (raw)
In-Reply-To: <cover.1715964816.git.luishenriquegh2701@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1237 bytes --]
Hi Oleg,
> From the first glance, some of the changes need to be grouped as
> single commit - [PATCH 8/9] gnu: golang.scm: Update packages and
> go versions.
thanks for the feedback! I didn't know it was OK to group commits,
do you think all commits before the last one should be grouped?
> A general cement to all of them - is everything related just to
> bump fzf to the latest version or it's a collection of not
> related patches?
So, to upgrade fzf I had to update some of its dependencies and,
due to it, had to update their go versions from 17 to 18. When I
checked if any other dependent packages were affected with =guix
refresh=, it showed to me that the packages were not building
because they were compiled with Go 17 and it seems the
=go-build-system= vendorizes all package dependencies before
building. I tried fixing only the packages that were broken, so I
guess they are all related in that sense. I'm totally open to
being convinced otherwise though :)
> Also try to avoid adding any new packages to golang.scm.
OK, I read some other packages there and it seemed to me that
=fastwalk= was similar in nature to the ones near it (where I
inserted it). Should I move it to =golang-xyz.scm= instead?
[-- Attachment #1.2: Type: text/html, Size: 1704 bytes --]
[-- Attachment #2: Type: text/plain, Size: 21 bytes --]
--
Luis H. Higino
next prev parent reply other threads:[~2024-06-04 17:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 0:32 [bug#71023] [PATCH 0/9] Update fzf to 0.52.1 Luis Higino
2024-05-18 1:11 ` [bug#71023] [PATCH 1/9] gnu: Add go-github-com-charlievieth-fastwalk Luis Higino
2024-05-18 1:11 ` [bug#71023] [PATCH 2/9] gnu: aerc: Update go version Luis Higino
2024-05-18 1:11 ` [bug#71023] [PATCH 3/9] gnu: vale: " Luis Higino
2024-05-18 1:11 ` [bug#71023] [PATCH 4/9] gnu: senpai: " Luis Higino
2024-05-18 1:11 ` [bug#71023] [PATCH 5/9] gnu: chezmoi: " Luis Higino
2024-05-18 1:11 ` [bug#71023] [PATCH 6/9] gnu: games.scm: Update go versions Luis Higino
2024-05-18 1:11 ` [bug#71023] [PATCH 7/9] gnu: golang-xyz.scm: " Luis Higino
2024-05-18 1:11 ` [bug#71023] [PATCH 8/9] gnu: golang.scm: Update packages and " Luis Higino
2024-05-18 1:11 ` [bug#71023] [PATCH 9/9] gnu: go-github-com-junegunn-fzf: Update to 0.52.1 Luis Higino
2024-05-21 20:49 ` [bug#71023] [PATCH 0/9] Update fzf " Sharlatan Hellseher
2024-06-04 17:00 ` Luis Henrique Gomes Higino [this message]
2024-06-10 10:14 ` [bug#71023] Groups Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sexs8wz3.fsf@gmail.com \
--to=luishenriquegh2701@gmail.com \
--cc=71023@debbugs.gnu.org \
--cc=sharlatanus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.