From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: Nigko Yerden <nigko.yerden@gmail.com>
Cc: Attila Lendvai <attila@lendvai.name>, guix-devel@gnu.org
Subject: Re: Cookbook recipe from "The Repository as a Channel" section does not work for Guix with properly configured GUILE_LOAD_PATH
Date: Sun, 18 Aug 2024 23:33:09 +0200 [thread overview]
Message-ID: <87sev1qzxm.fsf@pelzflorian.de> (raw)
In-Reply-To: <6fe218cd-2995-4d46-ba5f-3e262b730faf@gmail.com> (Nigko Yerden's message of "Thu, 15 Aug 2024 09:11:33 +0500")
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
Hello Nigko and Attila. My current belief is that any `local-file'
referring to outside the .guix-channel directory cannot work in channels
in all situations. (Attila’s hashes files are inside guix-crypto’s
.guix-channel src directory. They are fine.)
At first glance, Guix is faulty and does not respect all symlinks
in `absolute-dirname'. The following diff should be applied to
guix.git, to resolve symlinks before computing dirname, not after:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: guix/utils.scm --]
[-- Type: text/x-patch, Size: 436 bytes --]
diff --git a/guix/utils.scm b/guix/utils.scm
index d8ce6ed886..322c9457e4 100644
--- a/guix/utils.scm
+++ b/guix/utils.scm
@@ -1124,7 +1124,7 @@ (define absolute-dirname
;; needs to be canonicalized.
(if (string-prefix? "/" file)
(dirname file)
- (canonicalize-path (dirname file)))))))
+ (dirname (canonicalize-path file)))))))
(define-syntax current-source-directory
(lambda (s)
[-- Attachment #3: Type: text/plain, Size: 975 bytes --]
But this does not help with the cookbook’s guile channel nor Nigko’s
test-repo, even after repeatedly pulling a guix channel with this
change.
I might misunderstand .go compilation and whether macros are evaluated
at compile-time. But maybe the error is because `local-file' is
relative to the current-source-directory from which the .go file was
compiled. But the .go file was compiled from a directory union that
does not contain the source code, it only has the modules directory
listed in .guix-channel. Only when the pre-compiled .go is not used,
the source directory can be found. (Am I on the right track or
mistaken?)
/var/guix/profiles/per-user/florian/current-guix links to it. guix gc
--referrers and --derivers show what is built from what. Maybe I
misunderstand. Maybe the channel build system would need changes.
In particular,
$ guix build -S guile@3.0.99-git
never works no matter the load path.
Regards,
Florian
next prev parent reply other threads:[~2024-08-18 21:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 12:45 Cookbook recipe from "The Repository as a Channel" section does not work for Guix with properly configured GUILE_LOAD_PATH Nigko Yerden
2024-08-13 14:38 ` pelzflorian (Florian Pelz)
2024-08-13 15:06 ` Nigko Yerden
2024-08-13 17:25 ` pelzflorian (Florian Pelz)
2024-08-13 17:49 ` Nigko Yerden
2024-08-14 15:35 ` pelzflorian (Florian Pelz)
2024-08-14 16:40 ` pelzflorian (Florian Pelz)
2024-08-14 19:29 ` pelzflorian (Florian Pelz)
2024-08-15 4:11 ` Nigko Yerden
2024-08-18 21:33 ` pelzflorian (Florian Pelz) [this message]
2024-08-19 7:43 ` Nigko Yerden
2024-08-19 19:28 ` pelzflorian (Florian Pelz)
2024-08-20 7:18 ` Nigko Yerden
2024-08-20 16:49 ` pelzflorian (Florian Pelz)
2024-08-22 4:45 ` pelzflorian (Florian Pelz)
2024-08-22 9:53 ` Nigko Yerden
2024-08-22 13:22 ` Nigko Yerden
2024-08-22 16:00 ` pelzflorian (Florian Pelz)
2024-08-23 5:07 ` Nigko Yerden
2024-08-23 15:47 ` pelzflorian (Florian Pelz)
2024-08-23 16:25 ` pelzflorian (Florian Pelz)
2024-08-24 14:47 ` Nigko Yerden
2024-08-26 8:50 ` pelzflorian (Florian Pelz)
2024-08-28 12:36 ` Nigko Yerden
2024-08-28 16:40 ` pelzflorian (Florian Pelz)
2024-08-29 6:17 ` Nigko Yerden
2024-08-19 9:30 ` Nigko Yerden
2024-08-19 16:17 ` Nigko Yerden
2024-08-14 14:00 ` Attila Lendvai
2024-08-15 16:34 ` Nigko Yerden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sev1qzxm.fsf@pelzflorian.de \
--to=pelzflorian@pelzflorian.de \
--cc=attila@lendvai.name \
--cc=guix-devel@gnu.org \
--cc=nigko.yerden@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.