From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id OI5wI0VrX2eczAAAe85BDQ:P1 (envelope-from ) for ; Sun, 15 Dec 2024 23:50:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id OI5wI0VrX2eczAAAe85BDQ (envelope-from ) for ; Mon, 16 Dec 2024 00:50:29 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=UxOVm4SJ; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=UjCTzWGA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734306629; a=rsa-sha256; cv=none; b=K5udgRZelx7IJA6hLe0BSPNU5sVPXin8KzAbHplMqT2qf/MJIZZJGzM4WQlMDuj6oPB6MK fOk0UdcZzAqq+t9L4cV9N1vT/ELshhfRkr37GAE7ZmAbz44O9cQoTk7lkfj5Og/sgB9IU1 eilbAda2LC+V0zERgi91/TAv3E2l/dl2Y2tRYWGQjEJMzjdy7DQhuC4n//sFK64tJawE4A dRR0HKS9ZT2vN+kIQq+paHmPbVfn3B/DcdiHoeMKcQC/pS4zennBWnjHHxgBUqkaE8ykej AH7ea5SDPUPE7hEsZS90hxZmRnXofxMoaqivID5K+Z6fdExtbC2h6CznjSpJdA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=UxOVm4SJ; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=UjCTzWGA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734306629; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rzJW0J6M59bpzhnlSXF81H0olXRe9uqIq5Bv3AA2/w4=; b=BdO7EGtNR1Ns1qr8ZrlT9Qfk4D6Fu0A+4OM99WmiVfbrb12lUo7B8Xyd7Br8XkT8kFp7SO 57d3ZKXTTF6hWuqHiySV32SZipyEVY+JsVF1intLSgVLTIZbihWAhxCn8SOqi8osOxfsuw 3d525DX2LfnCyjh2ugS7xBvpSfKnANrh3ZChA5KLchpLofUTNwTUctHZqBLkv8B7ETnHF0 UMw54DctR44vQFU3S8NZBnTHyLymRD9QGw0d9Vbpa7QoVoiP/57T6DYMx2ClfLGwxJe6ZR 4JuaJK4Ny6pdfb9RC2a9AICfSti4IhKD3D938WB+MIaDHBSG72DXO7Ltl9kshA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 343C58A9FA for ; Mon, 16 Dec 2024 00:50:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMyNB-000475-N2; Sun, 15 Dec 2024 18:50:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMyN9-00046w-SS for guix-patches@gnu.org; Sun, 15 Dec 2024 18:50:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMyN9-0008Vw-Im for guix-patches@gnu.org; Sun, 15 Dec 2024 18:50:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=rzJW0J6M59bpzhnlSXF81H0olXRe9uqIq5Bv3AA2/w4=; b=UxOVm4SJDFOdlfpON0AABitGvJCUeCOXkRn0x5xN1eD2HiCX+GzjsFLkbfy8cBNrtbUQ1J5nkIBQJNqnyPnDAljGtPghIQTFXFzRWMeSDMdhS8GPfW5V82hL3Mr4OpOICLMvcHuiLfXLtZJ933mDp03LH3QAnumFgczeKirn8m+veR6H2xCviQdfnxSLI0j5OZE6iNdXuC2yESvFffi2Nw85xxV7DTeDCw9sCCbIETdgGFMbp7QU+TZRuzOU9aYMOMYFn1i0ZKrQ08iV7KFDoxec4bEJsRhtyQ7Yl4dH7HfM8P2Ws8dIRE1Ty0kUmnLAYkqp9f1Z7R0Bph5eaMK1vw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tMxu6-0001Ft-Jk for guix-patches@gnu.org; Sun, 15 Dec 2024 18:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74784] [PATCH] gnu: hugs: Fix build with GCC. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Dec 2024 23:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74784 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Homo Cc: 74784@debbugs.gnu.org Received: via spool by 74784-submit@debbugs.gnu.org id=B74784.17343047654760 (code B ref 74784); Sun, 15 Dec 2024 23:20:02 +0000 Received: (at 74784) by debbugs.gnu.org; 15 Dec 2024 23:19:25 +0000 Received: from localhost ([127.0.0.1]:52606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMxtQ-0001Eb-1i for submit@debbugs.gnu.org; Sun, 15 Dec 2024 18:19:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMxtK-0001EJ-Hw for 74784@debbugs.gnu.org; Sun, 15 Dec 2024 18:19:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMxtF-0005Dq-0U; Sun, 15 Dec 2024 18:19:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=rzJW0J6M59bpzhnlSXF81H0olXRe9uqIq5Bv3AA2/w4=; b=UjCTzWGAaZIUOJwFeMac vx9led4BL8fHjPR4s0eRWkyDy1sEu/0euScO9IRgKxRm52SE0KDF9l2TfmMXPPDJmC7Gz8NvmGlFt /WAiHd0DyFaibf9DFP66DENKhKLr8WTiCfC64EoAtUTXC+I1KN1iOMLFf/weN6tXe/SmPFfoOIrpJ 6EyJJoDEfP/+bR8xavhpSh11wrcQ2yas/+NMwTrVtiA6iz3bVWu2Oy7jsgtIgZ35WiEfuOLZiOJo2 zHqdN6uJh26GDIkUK1XZRQinW5JUTg1YD0WqKPrlzxDAm8n2hS8Ba6n8AGC+GYw1YjhVc1l5H0ZOt 4Cg/44hpyCR3/g==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20241211102636.20121-1-gay@disroot.org> (Homo's message of "Wed, 11 Dec 2024 12:26:36 +0200") References: <20241211102636.20121-1-gay@disroot.org> Date: Mon, 16 Dec 2024 00:19:00 +0100 Message-ID: <87seqofsbf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.69 X-Spam-Score: -4.69 X-Migadu-Queue-Id: 343C58A9FA X-Migadu-Scanner: mx12.migadu.com X-TUID: 0mFxX8OQocXV Hi, Homo skribis: > Change-Id: I6bbfb65e62d9a2b1a3c8b29eb386a24d6974eb45 > --- > gnu/packages/hugs.scm | 7 +++---- > gnu/packages/patches/hugs-fix-build.patch | 21 +++++++++++++++++++++ > 2 files changed, 24 insertions(+), 4 deletions(-) > create mode 100644 gnu/packages/patches/hugs-fix-build.patch A couple of minor nits but I think it=E2=80=99ll be useful if you plan to contribute more: > --- /dev/null > +++ b/gnu/packages/patches/hugs-fix-build.patch > @@ -0,0 +1,21 @@ > +diff --git a/packages/base/include/HsBase.h b/packages/base/include/HsBa= se.h > +index aa1a7fb..78d5b46 100644 Could you add a sentence at the top explaining what the patch does? (This will placate =E2=80=98guix lint=E2=80=99 in addition to myself. :-)) Could you also register the file in =E2=80=98gnu/local.mk=E2=80=99? Last, you can use =E2=80=98etc/committer.scm=E2=80=99 to generate a commit = log or template thereof that follow the project=E2=80=99s conventions. Thanks, Ludo=E2=80=99.