From: ludo@gnu.org (Ludovic Courtès)
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org
Subject: Re: Enhanced 'warning'
Date: Thu, 18 Apr 2013 22:59:52 +0200 [thread overview]
Message-ID: <87r4i7wo53.fsf@gnu.org> (raw)
In-Reply-To: <877gjzd4gb.fsf@karetnikov.org> (Nikita Karetnikov's message of "Thu, 18 Apr 2013 23:27:48 +0400")
Nikita Karetnikov <nikita@karetnikov.org> skribis:
>> You should reuse the body of the current ‘warning’ macro, though.
>
> What's wrong with this macro?
>
> (define-syntax define-diagnostic
> (syntax-rules ()
> ((define-diagnostic name prefix)
Since there’s a single rule, you should use ‘define-syntax-rule’
instead, for conciseness.
> (define-syntax name
> (lambda (x)
> (define (augmented-format-string fmt)
> (string-append "~:[~*~;guix ~a: ~]~a" (syntax->datum fmt)))
>
> (syntax-case x (N_ _) ; these are literals, yeah...
> ((name (_ fmt) args ...)
> (string? (syntax->datum #'fmt))
> (with-syntax ((fmt* (augmented-format-string #'fmt))
> (prefix (datum->syntax x prefix)))
> #'(format (guix-warning-port) (gettext fmt*)
> (program-name) (program-name) prefix
> args ...)))
> ((name (N_ singular plural n) args ...)
> (and (string? (syntax->datum #'singular))
> (string? (syntax->datum #'plural)))
> (with-syntax ((s (augmented-format-string #'singular))
> (p (augmented-format-string #'plural))
> (prefix (datum->syntax x prefix)))
> #'(format (guix-warning-port)
> (ngettext s p n %gettext-domain)
> (program-name) (program-name) prefix
> args ...)))))))))
>
> I'm getting the "extra ellipsis in form" error.
This is a macro-generating macro. In the body of the generated macro,
above, there are 4 occurrences of ‘...’. But these ellipses have no
meaning in the outer macro; they are just meaningful in the context of
the generated macro, hence the error.
Instead, you should replace all 4 occurrences with (... ...).
Yes, it’s always surprising at first. ;-)
Ludo’.
next prev parent reply other threads:[~2013-04-18 21:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 5:06 [PATCH] Add 'guix hash' Nikita Karetnikov
2013-04-03 8:34 ` Ludovic Courtès
2013-04-05 14:04 ` Nikita Karetnikov
2013-04-05 14:14 ` Nikita Karetnikov
2013-04-05 16:15 ` Ludovic Courtès
2013-04-10 11:48 ` Nikita Karetnikov
2013-04-10 11:54 ` Ludovic Courtès
2013-04-10 12:21 ` Nikita Karetnikov
2013-04-10 17:30 ` Ludovic Courtès
2013-04-05 16:13 ` Ludovic Courtès
2013-04-09 16:28 ` Nikita Karetnikov
2013-04-11 20:35 ` Ludovic Courtès
2013-04-12 5:24 ` master: FAIL: tests/guix-package.sh (was: [PATCH] Add 'guix hash'.) Nikita Karetnikov
2013-04-12 6:48 ` master: FAIL: tests/guix-package.sh Nikita Karetnikov
2013-04-12 16:24 ` Ludovic Courtès
2013-04-18 5:01 ` Enhanced 'warning' (was: [PATCH] Add 'guix hash'.) Nikita Karetnikov
2013-04-18 5:06 ` Enhanced 'warning' Nikita Karetnikov
2013-04-18 11:55 ` Ludovic Courtès
2013-04-18 19:27 ` Nikita Karetnikov
2013-04-18 20:59 ` Ludovic Courtès [this message]
2013-04-19 20:16 ` [PATCH] ui: Add a 'define-diagnostic' macro. (was: Enhanced 'warning') Nikita Karetnikov
2013-04-20 5:48 ` [PATCH] ui: Add a 'define-diagnostic' macro Nikita Karetnikov
2013-04-20 9:10 ` Ludovic Courtès
2013-04-20 17:33 ` Nikita Karetnikov
2013-04-20 19:55 ` Ludovic Courtès
2013-04-20 9:09 ` Ludovic Courtès
2013-04-21 18:14 ` [PATCH] Add 'guix hash' Nikita Karetnikov
2013-04-21 19:02 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4i7wo53.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=bug-guix@gnu.org \
--cc=nikita@karetnikov.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.