From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] ui: Add a 'define-diagnostic' macro. Date: Sat, 20 Apr 2013 11:09:28 +0200 Message-ID: <87r4i5bmbb.fsf@gnu.org> References: <87li92alhe.fsf@karetnikov.org> <874nforp12.fsf@gnu.org> <8762015b0w.fsf@karetnikov.org> <874nflx8e3.fsf@gnu.org> <871ua85t4w.fsf@karetnikov.org> <87sj2o59zy.fsf@gnu.org> <877gjzd4gb.fsf@karetnikov.org> <87r4i7wo53.fsf@gnu.org> <8761zie0nz.fsf_-_@karetnikov.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:53257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTTnf-0001WS-6y for bug-guix@gnu.org; Sat, 20 Apr 2013 05:09:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTTne-0003Qf-12 for bug-guix@gnu.org; Sat, 20 Apr 2013 05:09:39 -0400 Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=55227 helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTTnd-0003K7-Qd for bug-guix@gnu.org; Sat, 20 Apr 2013 05:09:37 -0400 In-Reply-To: <8761zie0nz.fsf_-_@karetnikov.org> (Nikita Karetnikov's message of "Sat, 20 Apr 2013 00:16:32 +0400") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Nikita Karetnikov Cc: bug-guix@gnu.org Nikita Karetnikov skribis: >> This is a macro-generating macro. In the body of the generated macro, >> above, there are 4 occurrences of =E2=80=98...=E2=80=99. But these elli= pses have no >> meaning in the outer macro; they are just meaningful in the context of >> the generated macro, hence the error. > >> Instead, you should replace all 4 occurrences with (... ...). > >> Yes, it=E2=80=99s always surprising at first. ;-) > > Yep, could you add it to the manual? There is only a reference to this > book [1] which briefly discusses the topic. Well, it=E2=80=99s specified in R[56]RS I believe, but yeah. > I'm attaching the patch that adds a 'define-diagnostic' macro. Can I > push it to 'master'? Looks good to me. Make sure to run =E2=80=98make clean && make=E2=80=99 be= fore, to see if there=E2=80=99s anything that fails to build (you only need to do this because these are macros.) > I ran 'grep' to find things which use "warning" or "leave." I guess > it's possible to change other functions (the ones that use 'error' and > 'format'). But it will probably trigger a rebuild. So what should I > do? Everything in guix/build/* must be left as is: it=E2=80=99s not part of the= UI, except perhaps for (guix build download). However, the rule is to only import (guix build ...) modules in (guix build ...) modules. So this looks fine as is. We=E2=80=99ll see later if there=E2=80=99s anyth= ing wrong with (guix build download) or something else. > Also, is it possible to move 'report-error' inside 'leave'? Didn=E2=80=99t you want to export it as well? But otherwise no. > Finally, I haven't tested each change. All tests pass and there are no > warnings. Is it good enough? Plus =E2=80=98make clean && make=E2=80=99. Please push if it passes that. Thanks! Ludo=E2=80=99.