all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Add Mercurial to version-control.scm
@ 2013-09-06  9:32 Arne Babenhauserheide
  2013-09-07 13:06 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Arne Babenhauserheide @ 2013-09-06  9:32 UTC (permalink / raw)
  To: guix-devel

Hi,

Here’s a patch to add Mercurial as package:


--- /usr/local/share/guile/site/2.0/gnu/packages/version-control.scm	2013-09-04 16:27:21.495618474 +0200
+++ /home/arne/version-control.scm	2013-09-06 11:13:57.080871243 +0200
@@ -64,6 +64,26 @@
 from a command line or use a GUI application.")
     (license gpl2+)))
 
+(define-public mercurial
+  (package
+    (name "mercurial")
+    (version "2.7.1")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "http://mercurial.selenic.com/release/mercurial-" version ".tar.gz"))
+      (sha256
+       (base32
+        "121m8f7vmipmdg00cnzdz2rjkgydh28mwfirqkrbs5fv089vywl4"))))
+    (build-system python-build-system)
+    (home-page "http://mercurial.selenic.com")
+    (synopsis "Decentralized version control system")
+    (description
+     "Mercurial is a free, distributed source control management tool. 
+It efficiently handles projects of any size and offers an easy and intuitive interface.")
+    (license gpl2+)))
+
+
 (define-public subversion
   (package
     (name "subversion")


I put Mercurial between bazaar and subversion to keep alphabetic
ordering. Later items might not be ordered alphabetically, but that’s
out of my responsibility :)


Best wishes,
Arne

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Add Mercurial to version-control.scm
  2013-09-06  9:32 Add Mercurial to version-control.scm Arne Babenhauserheide
@ 2013-09-07 13:06 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2013-09-07 13:06 UTC (permalink / raw)
  To: Arne Babenhauserheide; +Cc: guix-devel

Hi Arne,

Arne Babenhauserheide <arne_bab@web.de> skribis:

> Here’s a patch to add Mercurial as package:

Thanks for the patch!

It looks good overall.  I’m assuming that it actually builds, is usable,
and that you assert that you did a reasonable auditing setting the
‘license’ field.

A few stylistic comments.

First, could you send the patch as produced by ‘git format-patch’, which
a ChangeLog-style commit log (see ‘HACKING’ and the VCS history for
details)?  Then we’ll happily push it.  :-)

> +(define-public mercurial
> +  (package
> +    (name "mercurial")
> +    (version "2.7.1")
> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "http://mercurial.selenic.com/release/mercurial-" version ".tar.gz"))

Please keep lines below 80 columns (see ‘Coding Style’ in ‘HACKING’.)

> +      (sha256
> +       (base32
> +        "121m8f7vmipmdg00cnzdz2rjkgydh28mwfirqkrbs5fv089vywl4"))))
> +    (build-system python-build-system)
> +    (home-page "http://mercurial.selenic.com")
> +    (synopsis "Decentralized version control system")
> +    (description
> +     "Mercurial is a free, distributed source control management tool. 
> +It efficiently handles projects of any size and offers an easy and intuitive interface.")

Likewise.

> I put Mercurial between bazaar and subversion to keep alphabetic
> ordering. Later items might not be ordered alphabetically, but that’s
> out of my responsibility :)

Yes, we’re pretty liberal in that regard.  ;-)

Thanks for your patch, and welcome aboard!

Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-07 13:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-06  9:32 Add Mercurial to version-control.scm Arne Babenhauserheide
2013-09-07 13:06 ` Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.