all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nikita Karetnikov <nikita@karetnikov.org>
To: "Joshua \"Youlysses\" S. Grant" <youlysses@riseup.net>
Cc: guix-devel@gnu.org
Subject: Re: Add Package Gl
Date: Sat, 28 Sep 2013 23:42:45 +0400	[thread overview]
Message-ID: <87r4c8ag22.fsf@karetnikov.org> (raw)
In-Reply-To: <1380392309.1256.11.camel@battlestallion> (Joshua S. Grant's message of "Sat, 28 Sep 2013 13:18:29 -0500")

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

Minor issues…

>    #:use-module ((guix licenses) 
>                   #:renamer (symbol-prefix-proc 'license:))

It’d better to use 'l: as a prefix to avoid (license license:something).
You could also use #:select if it’s possible.

>    #:use-module (gnu packages fontutils))
>
>

Extra newline.

> (define-public glu
>   (package
>      (name "glu")

Should be indented like so:

(package
  (name "glu")

>      (source (origin
> 	      (method url-fetch)
> 	      (uri (string-append "ftp://ftp.freedesktop.org/pub/mesa/glu/glu-" 
>                                    version ".tar.gz"))
>               (sha256
> 	        (base32 "0r72yyhj09x3krn3kn629jqbwyq50ji8w5ri2pn6zwrk35m4g1s3"))))

(source (origin
         (method url-fetch)
         (uri (string-append "ftp://ftp.freedesktop.org/pub/mesa/glu/glu-" 
                             version ".tar.gz"))
         (sha256
          (base32 "0r72yyhj09x3krn3kn629jqbwyq50ji8w5ri2pn6zwrk35m4g1s3"))))

>      (description 
> 	  "GLU, or OpenGL Utility Library provides some higher-level functionality 

(description 
 "GLU, or OpenGL Utility Library provides some higher-level functionality 

The rest of the file has the same problems.  But as Cyril said: “Other
than that, this looks good, thanks!”

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

  parent reply	other threads:[~2013-09-28 19:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-28 18:18 Add Package Gl Joshua "Youlysses" S. Grant
2013-09-28 18:07 ` Cyril Roelandt
2013-09-28 19:11   ` Joshua "Youlysses" S. Grant
2013-09-28 19:00     ` Cyril Roelandt
2013-09-28 19:42 ` Nikita Karetnikov [this message]
2013-09-28 19:45   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4c8ag22.fsf@karetnikov.org \
    --to=nikita@karetnikov.org \
    --cc=guix-devel@gnu.org \
    --cc=youlysses@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.