From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/6 v2] gnu: gtk+: enable introspection.
Date: Mon, 09 Dec 2013 00:53:19 +0100
Message-ID: <87r49myk5s.fsf@gnu.org>
References: <87a9gc3clz.fsf@gnu.org>
	<1386534737-17602-1-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48413)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VpoAC-0002nr-BZ
	for guix-devel@gnu.org; Sun, 08 Dec 2013 18:53:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VpoA6-0000NQ-Ar
	for guix-devel@gnu.org; Sun, 08 Dec 2013 18:53:28 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:63778)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1VpoA6-0000NM-4j
	for guix-devel@gnu.org; Sun, 08 Dec 2013 18:53:22 -0500
In-Reply-To: <1386534737-17602-1-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Sun, 8 Dec 2013 21:32:17 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/gtk.scm (atk, gdk-pixbuf, gtk+, pango): enable introspecti=
on
> * guix/build/gnome.scm: New file.

[...]

> --- a/gnu/packages/glib.scm
> +++ b/gnu/packages/glib.scm
> @@ -184,9 +184,10 @@ dynamic loading, and an object system.")
>         ("cairo" ,cairo)
>         ("flex" ,flex)
>         ("glib" ,glib)
> -       ("libffi" ,libffi)
>         ("pkg-config" ,pkg-config)
>         ("python-2" ,python-2)))
> +    (propagated-inputs
> +     `(("libffi" ,libffi)))

Please add a comment saying that GIR users need to use libffi (to use
its headers, right?), hence the propagation.

> +
> +           (substitute* "gdk/Makefile.in"
> +            (("--add-include-path=3D../gdk")
> +             (string-append
> +              "--add-include-path=3D../gdk"
> +              " --add-include-path=3D" (gir-path inputs "gdk-pixbuf")
> +              " --add-include-path=3D" (gir-path inputs "pango")))

Add a comment above saying what this is all about (what program these
flags are for, and what they do.)

> +(define-module (guix build gnome)
> +  #:export (gir-path))
> +
> +;;; Commentary:
> +;;;
> +;;; Tools commonly used when building GNOME programs.
> +;;;
> +;;; Code:
> +
> +(define (gir-path inputs pkg-name)
> +  ""
> +  (string-append (assoc-ref inputs pkg-name)
> +                 "/share/gir-1.0"))

Please add a docstring here (instead of ""), like

  Return the GIR directory name for PKG-NAME found from INPUTS.

So I think =E2=80=98gir-directory=E2=80=99 would be more appropriate.

OK to push with these things fixed.

Thanks,
Ludo=E2=80=99.