Re: [PATCH] gnu: xterm: Accept $SHELL even if not in /etc/shells

[ludo@gnu.org (Ludovic Courtès)]

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> IMO, it's not reasonable to have to add
>>> /home/<USER>/<PROFILE>/bin/<SHELL> for every combination of <USER>,
>>> <PROFILE>, and <SHELL> to /etc/shells, in order to prevent 'xterm' from
>>> overriding your $SHELL setting.
>>
>> On NixOS, /etc/shells contains this:
>>
>> /run/current-system/sw/bin/bash
>> /var/run/current-system/sw/bin/bash
>> /bin/sh
>>
>> Where {/var/,}/run/current-system contains the “global” profile, like on
>> our QEMU images.
>>
>> Perhaps that’s good enough no?
>
> If a user wants to set $SHELL to be the one in their private profile,
> I think 'xterm' shouldn't ignore it and modify $SHELL just because it
> hasn't been authorized by the administrator of the system.

Agreed.

However, we’re just packaging an existing application.  IMO, when we
find such limitations (it’s really a limitation, and not something that
makes it completely unusable), we should submit the improvement
upstream, unless upstream no longer exists (I’m not sure if this is the
case here.)

WDYT?

Thanks!

Ludo’.