From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: gnu: Have lua-5.1 compile a .so
Date: Thu, 11 Sep 2014 10:02:08 +0200
Message-ID: <87r3ziwpof.fsf@gnu.org>
References: <20140910223135.GF31169@luwin.ulrar.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XRzKZ-0004rE-ST
	for guix-devel@gnu.org; Thu, 11 Sep 2014 04:02:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XRzKT-0007km-Ua
	for guix-devel@gnu.org; Thu, 11 Sep 2014 04:02:15 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:37921)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XRzKT-0007kg-NZ
	for guix-devel@gnu.org; Thu, 11 Sep 2014 04:02:09 -0400
In-Reply-To: <20140910223135.GF31169@luwin.ulrar.net> (lemonnierk@ulrar.net's
	message of "Thu, 11 Sep 2014 00:31:35 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: lemonnierk@ulrar.net
Cc: guix-devel@gnu.org

Hello!

lemonnierk@ulrar.net skribis:

> While working on getting weechat to build with the lua plugin enabled,
> I noticed the lua package doesn't produce a liblua.so file. So here is
> a patch to make it do so. It's basically the same patch as in ArchLinux,
> with a few differences like actually installing the .so file.

I think the comments of Eric and Cyril need to be addressed.

Other than that, I=E2=80=99m wondering: is there a reason why upstream Lua
doesn=E2=80=99t install a shared library by default?  Is it because the nor=
mal
way to use it is to include the source in the package that uses it?

IOW, is it OK to diverge from upstream?

If in doubt, it=E2=80=99s probably fine, IMO, but I just wanted to make sur=
e.

Thanks,
Ludo=E2=80=99.