Re: [PATCH] emacs: Improve interface for working with multiple profiles.

[Alex Kost <alezost@gmail.com>]

Ludovic Courtès (2014-10-17 23:29 +0400) wrote:

> Alex Kost <alezost@gmail.com> skribis:

[...]

> What about renaming ‘guix-set-current-profile’ to
> ‘guix-set-default-profile’?  Because now, what it does is just to define
> the profile that is used when C-u isn’t used, right?

Right, but I think it shouldn't be renamed as "default profile" and
"current profile" have different meanings there:

- default profile is "/var/guix/profiles/per-user/user/guix-profile" (or
  whatever) and it is “fixed”;

- current profile is used by commands (as you pointed) and it may be
  changed.

For example, a user decides to look at generations and installed
packages of some profile.  So he may "M-x guix-set-current-profile ...",
then "M-x guix-generations" and "M-x guix-installed-packages".  After
that he could switch to another profile or to a default profile using
"C-u M-x guix-set-current-profile".

(there are even 2 variables: guix-default-profile and
guix-current-profile)

>> Also as prefix argument was previously used in "M-x guix-generations" to
>> select last N generations, I added a new command "M-x
>> guix-last-generations".
>
> OK.
>
>>  @item M-x guix-generations
>> -List generations for the current profile.  With numeric prefix, show so
>> -many last generations.
>> +List all generations for the current profile.
>            ^                    ^^^^^^^
> “all the generations”
>
> For all these commands, it may be better to omit “current”, because it’s
> not necessary the current/default profile that is used.

Yes, you are right.

>> +@item M-x guix-last-generations
>> +List last generations for the current profile. You will be prompted for
>> +the number of generations.
>
> Maybe: “List the @var{N} last generations of the profile.”
> Also, double space after period.

Hawk eye :-)

>> -By default commands for displaying packages display each output on a
>> +All these commands use current profile, which can be changed with
>> +@kbd{M-x@tie{}guix-set-current-profile}.  Also if you call any of these
>> +commands with prefix argument (@kbd{C-u}), you will be prompted for a
>> +profile just for that command.
>
> s/current/default/ ?

I believe “current” is better.

> I wonder if it might be better to move this paragraph above the first
> command, so it’s clear which profile we’re talking about.
>
>> -For example if you want to display all types of results in a single
>> +By default, the name of a profile is also displayed in a ``list'' or
>> +''info'' buffer name.  To change this behavior, use
>    ^^
> backquotes

Ouch, hawks should envy :-)

Thanks for the comments.