all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: "Taylan Ulrich \"Bayırlı/Kammer\"" <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ngircd.
Date: Thu, 05 Feb 2015 10:46:04 -0500	[thread overview]
Message-ID: <87r3u44b0j.fsf@netris.org> (raw)
In-Reply-To: <877fvw2zvh.fsf@taylan.uni.cx> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Thu, 05 Feb 2015 15:32:02 +0100")

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") writes:

> +    (arguments
> +     `(#:configure-flags
> +       `("--with-gnutls" "--with-iconv" "--enable-ipv6"
> +         ,,@(if (string-suffix? "-linux"
> +                                (or (%current-target-system)
> +                                    (%current-system)))
> +                '("--with-pam")
> +                '()))

There's no need for two levels of quasiquote here, and it unnecessarily
complicates the unquoting.  How about changing the inner quasiquote to
normal quote?  It should come out like this:

    (arguments
     `(#:configure-flags
       '("--with-gnutls" "--with-iconv" "--enable-ipv6"
         ,@(if (string-suffix? "-linux"
                               (or (%current-target-system)
                                   (%current-system)))
               '("--with-pam")
               '()))

> +       #:phases
> +       ;; Necessary for the test suite, should it be enabled in the future.

You can remove the ", should it be enabled in the future".

Modulo these little nitpicks, it looks good to me.  Please push!

     Thanks,
       Mark

  reply	other threads:[~2015-02-05 15:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-31 21:49 [PATCH] gnu: Add ngircd "Taylan Ulrich Bayırlı/Kammer"
2015-01-31 23:58 ` Taylan Ulrich Bayırlı/Kammer
2015-02-01  6:58   ` Mark H Weaver
2015-02-01 23:23     ` Taylan Ulrich Bayırlı/Kammer
2015-02-05 12:46       ` Ludovic Courtès
2015-02-05 14:32         ` Taylan Ulrich Bayırlı/Kammer
2015-02-05 15:46           ` Mark H Weaver [this message]
2015-02-05 11:53     ` Taylan Ulrich Bayırlı/Kammer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3u44b0j.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=guix-devel@gnu.org \
    --cc=taylanbayirli@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.