all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Marek Benc <dusxmt@gmx.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/4] gnu: gcc: Also substitute the dynamic linker name for GNU, (ie. Hurd) systems.
Date: Sun, 08 Feb 2015 00:22:12 +0100	[thread overview]
Message-ID: <87r3u1wbmj.fsf@gnu.org> (raw)
In-Reply-To: <54D39B1B.4060300@gmx.com> (Marek Benc's message of "Thu, 05 Feb 2015 17:32:27 +0100")

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

Marek Benc <dusxmt@gmx.com> skribis:

> From 7ae53fd611dd78a8c185734dad268428a8b931a8 Mon Sep 17 00:00:00 2001
> From: Marek Benc <dusxmt@gmx.com>
> Date: Thu, 5 Feb 2015 17:12:54 +0100
> Subject: [PATCH] gnu: gcc: Also substitute the dynamic linker name for GNU
>  (ie. Hurd) systems.
>
> * gnu/packages/gcc.scm (gcc-4.7): Also substitute the dynamic linker name for GNU (ie. Hurd) systems.
>
> ---
>  gnu/packages/gcc.scm | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm
> index 0260158..271d277 100644
> --- a/gnu/packages/gcc.scm
> +++ b/gnu/packages/gcc.scm
> @@ -186,6 +186,13 @@ where the OS part is overloaded to denote a specific ABI---into GCC
>                             suffix
>                             (string-append libc ,(glibc-dynamic-linker)))))
>  
> +                (substitute* (find-files "gcc/config"
> +                                         "^gnu(64|-elf)?\\.h$")
> +                  (("#define GNU_USER_DYNAMIC_LINKER([^ ]*).*$" _ suffix)
> +                   (format #f "#define GNU_USER_DYNAMIC_LINKER~a \"~a\"~%"
> +                           suffix
> +                           (string-append libc ,(glibc-dynamic-linker)))))
> +
>                  ;; Tell where to find libstdc++, libc, and `?crt*.o', except
>                  ;; `crt{begin,end}.o', which come with GCC.
>                  (substitute* (find-files "gcc/config"

Would this slightly more concise approach work:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1051 bytes --]

diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm
index 6143f5b..5cb7f8b 100644
--- a/gnu/packages/gcc.scm
+++ b/gnu/packages/gcc.scm
@@ -202,10 +202,11 @@ where the OS part is overloaded to denote a specific ABI---into GCC
 
                 ;; Fix the dynamic linker's file name.
                 (substitute* (find-files "gcc/config"
-                                         "^linux(64|-elf|-eabi)?\\.h$")
-                  (("#define GLIBC_DYNAMIC_LINKER([^ ]*).*$" _ suffix)
-                   (format #f "#define GLIBC_DYNAMIC_LINKER~a \"~a\"~%"
-                           suffix
+                                         "^(gnu|linux)(64|-elf|-eabi)?\\.h$")
+                  (("#define (GLIBC|GNU_USER)_DYNAMIC_LINKER([^ ]*).*$" _
+                    kind suffix)
+                   (format #f "#define ~a_DYNAMIC_LINKER~a \"~a\"~%"
+                           kind suffix
                            (string-append libc ,(glibc-dynamic-linker)))))
 
                 ;; Tell where to find libstdc++, libc, and `?crt*.o', except

[-- Attachment #3: Type: text/plain, Size: 21 bytes --]


Thanks,
Ludo’.

  reply	other threads:[~2015-02-07 23:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 16:32 [PATCH 4/4] gnu: gcc: Also substitute the dynamic linker name for GNU, (ie. Hurd) systems Marek Benc
2015-02-07 23:22 ` Ludovic Courtès [this message]
2015-02-09 17:24   ` Marek Benc
2015-02-10 16:27     ` Ludovic Courtès
2015-03-10  8:40       ` Manolis Ragkousis
2015-03-10 12:43         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3u1wbmj.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=dusxmt@gmx.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.