From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCHES] Add recode, enca.
Date: Mon, 09 Mar 2015 21:19:28 +0100
Message-ID: <87r3sxrkj3.fsf@gnu.org>
References: <87bnk8e8cq.fsf@taylan.uni.cx> <20150306220358.GB32498@debian>
	<87oao3qjae.fsf@gnu.org> <87twxu8eq1.fsf@taylan.uni.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48228)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YV49J-0007MX-48
	for guix-devel@gnu.org; Mon, 09 Mar 2015 16:19:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YV49E-0007KW-CV
	for guix-devel@gnu.org; Mon, 09 Mar 2015 16:19:37 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45003)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YV49E-0007KS-9T
	for guix-devel@gnu.org; Mon, 09 Mar 2015 16:19:32 -0400
In-Reply-To: <87twxu8eq1.fsf@taylan.uni.cx> ("Taylan Ulrich
	\=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
	message of "Mon, 09 Mar 2015 14:47:34 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?=
	=?utf-8?Q?=2FKammer=22?= <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org

taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
>>> You could set LD_LIBRARY_PATH to "." (or the subdirectory where the
>>> library can be found) before running the tests.
>>
>> This should be =E2=80=98LIBRARY_PATH=E2=80=99, not =E2=80=98LD_LIBRARY_P=
ATH=E2=80=99, but yes, good
>> idea.
>
> I found out that I can patch the setup.py file to include the necessary
> library dir in its instructions.  Updated patch is below.
>
> Tell me if this should go to a 'snippet' (or patch) in the 'source'
> instead (where it would patch setup.py.in).

The way you did it looks fine to me.

> I'm not sure if the need to specify the ".libs" subdirectory is
> Guix-specific or not.

I don=E2=80=99t think so (the package uses libtool, right?)  This may be a
genuine upstream bug, which could go unnoticed when the user happens to
have a librecode.so in the loader=E2=80=99s search path.

> From 8bd6b2b327820a15292097c9deeabcedfb9346ac Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?=
=3D
>  <taylanbayirli@gmail.com>
> Date: Wed, 4 Mar 2015 22:34:13 +0100
> Subject: [PATCH 22/25] gnu: Add recode.
>
> * gnu/packages/textutils.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +    (license (list license:gpl2+ license:lgpl2.1+))))

Please add a comment telling if this is an =E2=80=98or=E2=80=99 or an =E2=
=80=98and=E2=80=99.

Thanks!

Ludo=E2=80=99.