Re: [PATCHES] Add recode, enca.

[ludo@gnu.org (Ludovic Courtès)]

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>>> You could set LD_LIBRARY_PATH to "." (or the subdirectory where the
>>> library can be found) before running the tests.
>>
>> This should be ‘LIBRARY_PATH’, not ‘LD_LIBRARY_PATH’, but yes, good
>> idea.
>
> I found out that I can patch the setup.py file to include the necessary
> library dir in its instructions.  Updated patch is below.
>
> Tell me if this should go to a 'snippet' (or patch) in the 'source'
> instead (where it would patch setup.py.in).

The way you did it looks fine to me.

> I'm not sure if the need to specify the ".libs" subdirectory is
> Guix-specific or not.

I don’t think so (the package uses libtool, right?)  This may be a
genuine upstream bug, which could go unnoticed when the user happens to
have a librecode.so in the loader’s search path.

> From 8bd6b2b327820a15292097c9deeabcedfb9346ac Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Wed, 4 Mar 2015 22:34:13 +0100
> Subject: [PATCH 22/25] gnu: Add recode.
>
> * gnu/packages/textutils.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +    (license (list license:gpl2+ license:lgpl2.1+))))

Please add a comment telling if this is an ‘or’ or an ‘and’.

Thanks!

Ludo’.