From: ludo@gnu.org (Ludovic Courtès)
To: "Taylan Ulrich \"Bayırlı/Kammer\"" <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCHES] Add recode, enca.
Date: Mon, 09 Mar 2015 21:19:28 +0100 [thread overview]
Message-ID: <87r3sxrkj3.fsf@gnu.org> (raw)
In-Reply-To: <87twxu8eq1.fsf@taylan.uni.cx> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Mon, 09 Mar 2015 14:47:34 +0100")
taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>>> You could set LD_LIBRARY_PATH to "." (or the subdirectory where the
>>> library can be found) before running the tests.
>>
>> This should be ‘LIBRARY_PATH’, not ‘LD_LIBRARY_PATH’, but yes, good
>> idea.
>
> I found out that I can patch the setup.py file to include the necessary
> library dir in its instructions. Updated patch is below.
>
> Tell me if this should go to a 'snippet' (or patch) in the 'source'
> instead (where it would patch setup.py.in).
The way you did it looks fine to me.
> I'm not sure if the need to specify the ".libs" subdirectory is
> Guix-specific or not.
I don’t think so (the package uses libtool, right?) This may be a
genuine upstream bug, which could go unnoticed when the user happens to
have a librecode.so in the loader’s search path.
> From 8bd6b2b327820a15292097c9deeabcedfb9346ac Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
> <taylanbayirli@gmail.com>
> Date: Wed, 4 Mar 2015 22:34:13 +0100
> Subject: [PATCH 22/25] gnu: Add recode.
>
> * gnu/packages/textutils.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
[...]
> + (license (list license:gpl2+ license:lgpl2.1+))))
Please add a comment telling if this is an ‘or’ or an ‘and’.
Thanks!
Ludo’.
next prev parent reply other threads:[~2015-03-09 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 21:55 [PATCHES] Add recode, enca Taylan Ulrich Bayırlı/Kammer
2015-03-06 22:03 ` Andreas Enge
2015-03-07 12:54 ` Taylan Ulrich Bayırlı/Kammer
2015-03-08 21:19 ` Ludovic Courtès
2015-03-09 13:47 ` Taylan Ulrich Bayırlı/Kammer
2015-03-09 20:19 ` Ludovic Courtès [this message]
2015-03-09 21:47 ` Taylan Ulrich Bayırlı/Kammer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3sxrkj3.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=taylanbayirli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.