From: ludo@gnu.org (Ludovic Courtès)
To: "Tomáš Čech" <sleep_walker@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: gnu: Add agg.
Date: Wed, 18 Mar 2015 14:09:49 +0100 [thread overview]
Message-ID: <87r3smfo4i.fsf@gnu.org> (raw)
In-Reply-To: <E1YYBc3-0000d6-3W@vcs.savannah.gnu.org> (Tomas Cech's message of "Wed, 18 Mar 2015 10:54:11 +0000")
Tomas Cech <sleep_walker@suse.cz> skribis:
> commit 87bafa07ae68084819bb2648bd1042c354d11317
> Author: Tomáš Čech <sleep_walker@gnu.org>
> Date: Wed Mar 18 08:57:50 2015 +0100
>
> gnu: Add agg.
>
> * gnu/packages/graphics.scm (agg): New variable.
> * gnu/packages/patches/agg-am_c_prototype.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
[...]
> +++ b/gnu/packages/patches/agg-am_c_prototype.patch
> @@ -0,0 +1,10 @@
> +--- a/configure.in 2015-03-15 18:59:12.557417149 +0100
> ++++ b/configure.in 2015-03-15 18:59:29.273416518 +0100
Patches must have a comment at the beginning to explain what they do,
why, and what the upstream status is.
Please pay more attention to these rules before pushing. In general, I
would recommend that you wait for some review before pushing. (This is
sometimes slow, but hopefully others will help reduce latency,
hint hint! ;-))
> +@@ -8,7 +8,6 @@
> + AC_PROG_CC
> + AC_PROG_CXX
> + AC_ISC_POSIX
> +-AM_C_PROTOTYPES
> + if test "x$U" != "x"; then
> + AC_MSG_ERROR(Compiler not ANSI compliant)
> + fi
It is best to avoid modifying .ac or .am files because that requires
adding a dependency on the autotools.
What problem does this patch solve? I’m confident this can be worked
around without modifying the .ac file, for instance by passing the right
ac_cv_ variable as a ‘configure’ argument.
Thanks,
Ludo’.
next parent reply other threads:[~2015-03-18 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150318105410.2359.97929@vcs.savannah.gnu.org>
[not found] ` <E1YYBc3-0000d6-3W@vcs.savannah.gnu.org>
2015-03-18 13:09 ` Ludovic Courtès [this message]
2015-03-18 13:47 ` 01/01: gnu: Add agg Tomáš Čech
2015-03-18 20:40 ` Ludovic Courtès
2015-03-18 22:08 ` [PATCH] gnu: agg: Add explanatory comment to the patch Tomáš Čech
2015-03-19 16:02 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3smfo4i.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=sleep_walker@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.