From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: base: Avoid circular dependency among
	glibc-hurd-headers and hurd-minimal.
Date: Sun, 31 May 2015 22:25:18 +0200
Message-ID: <87r3pw1olt.fsf@gnu.org>
References: <CAFtzXzPib5s4zBUPdsQrO-ow8-h_+ddonP_s-D2enxEhY9hE8A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48808)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yz9nT-0003yw-3L
	for Guix-devel@gnu.org; Sun, 31 May 2015 16:25:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yz9nP-0002Fh-Ua
	for Guix-devel@gnu.org; Sun, 31 May 2015 16:25:27 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54202)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Yz9nP-0002Fc-Rg
	for Guix-devel@gnu.org; Sun, 31 May 2015 16:25:23 -0400
In-Reply-To: <CAFtzXzPib5s4zBUPdsQrO-ow8-h_+ddonP_s-D2enxEhY9hE8A@mail.gmail.com>
	(Manolis Ragkousis's message of "Wed, 27 May 2015 17:39:10 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>

Manolis Ragkousis <manolis837@gmail.com> skribis:

> From 744e51fc7f61685fd6785a64cefbaeb3cf87d2ec Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Wed, 27 May 2015 17:22:43 +0300
> Subject: [PATCH] gnu: base: Avoid circular dependency among glibc-hurd-he=
aders
>  and hurd-minimal.
>
> There is a circular dependency between glibc-hurd-headers and hurd-minima=
l, where
> one expects the other, while only the later needs the former.
>
> * gnu/packages/base.scm (glibc/hurd-headers): Add correct propagated-inpu=
ts.

[...]

> --- a/gnu/packages/base.scm
> +++ b/gnu/packages/base.scm
> @@ -758,6 +758,8 @@ command.")
>    (package (inherit glibc/hurd)
>      (name "glibc-hurd-headers")
>      (outputs '("out"))
> +    (propagated-inputs `(("gnumach-headers" ,gnumach-headers)
> +                         ("hurd-headers" ,hurd-headers)))
>      (arguments
>       (substitute-keyword-arguments (package-arguments glibc/hurd)
>         ;; We just pass the flags really needed to build the headers.

The patch makes sense to me: it=E2=80=99s a case of library A using headers=
 of
libraries B and C, so B and C must be propagated.

I=E2=80=99m not sure why you mention a circular dependency in the message, =
and
what this has to do with that though.  I think the message should simply
be:

  gnu: glibc/hurd-headers: Propagate Hurd and Mach headers.

  * gnu/packages/base.scm (glibc/hurd-headers)[propagated-inputs]: New
    field.

Thanks!

Ludo=E2=80=99.