From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable Date: Tue, 23 Jun 2015 14:43:46 +0300 Message-ID: <87r3p2r6od.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7McL-0001Ir-Ux for guix-devel@gnu.org; Tue, 23 Jun 2015 07:43:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7McI-0005Dq-O3 for guix-devel@gnu.org; Tue, 23 Jun 2015 07:43:53 -0400 Received: from mail-la0-x22d.google.com ([2a00:1450:4010:c03::22d]:33883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7McI-0005Cw-6t for guix-devel@gnu.org; Tue, 23 Jun 2015 07:43:50 -0400 Received: by lagx9 with SMTP id x9so4733040lag.1 for ; Tue, 23 Jun 2015 04:43:49 -0700 (PDT) In-Reply-To: ("Claes Wallin \=\?utf-8\?B\?KOmfi+WYieiqoCkiJ3M\=\?\= message of "Fri, 19 Jun 2015 20:51:10 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?Q2xhZXMgV2FsbGluICjpn4vlmInoqqAp?= Cc: guix-devel Claes Wallin (=E9=9F=8B=E5=98=89=E8=AA=A0) (2015-06-19 21:51 +0300) wrote: > From 9213e7207f5e72bf66460d2cdf4e27a86609e322 Mon Sep 17 00:00:00 2001 > From: Claes Wallin > Date: Fri, 19 Jun 2015 20:12:09 +0200 > Subject: [PATCH] gnu/package/pv.scm (pv): New file, new variable > > Signed-off-by: Claes Wallin I think there is no need in this =E2=86=91 line. The commit message should= be: --8<---------------cut here---------------start------------->8--- gnu: Add pv. * gnu/package/pv.scm (pv): New file. * gnu-system.am (GNU_SYSTEM_MODULES): Add it. --8<---------------cut here---------------end--------------->8--- And you also need to add "gnu/package/pv.scm" to "gnu-system.am". See commit 741115b for example. > --- > gnu/packages/pv.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 gnu/packages/pv.scm > > diff --git a/gnu/packages/pv.scm b/gnu/packages/pv.scm > new file mode 100644 > index 0000000..f0eac85 > --- /dev/null > +++ b/gnu/packages/pv.scm > @@ -0,0 +1,48 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright 2012, 2013, 2015 Ludovic Courts > +;;; Copyright 2015 Claes Wallin IIUC you are the only author of this file, right? Then there is no place for Ludovic there. > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages pv) > + #:use-module (guix licenses) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix build-system gnu) > + #:export (pv)) > + > +(define pv I think we prefer 'define-public' over exporting the package variables, but it is probably not a strong convention. > + (package > + (name "pv") > + (version "1.6.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "http://www.ivarch.com/programs/sources/pv-" > + version ".tar.bz2")) > + (sha256 > + (base32 > + "13gg6r84pkvznpd1l11qw1jw9yna40gkgpni256khyx21m785khf")))) > + (build-system gnu-build-system) > + (home-page "http://www.ivarch.com/programs/pv.shtml") > + (synopsis "Pipeline progress indicator") > + (description > + "pv - Pipe Viewer - is a terminal-based tool for monitoring the pro= gress I would put "Pipe Viewer" in parentheses: "pv (Pipe Viewer) is a terminal-based tool for monitoring the progr= ess but I think you may ignore this comment. > +of data through a pipeline. It can be inserted into any normal pipeline of data through a pipeline. It can be inserted into any normal pipeline I realize that you took this description from the home page, but our convention is to use two spaces between sentences. > +between two processes to give a visual indication of how quickly data is > +passing through, how long it has taken, how near to completion it is, an= d an > +estimate of how long it will be until completion.") > + (license artistic2.0))) --=20 Alex