all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add preseq.
Date: Wed, 01 Jul 2015 15:30:18 +0200	[thread overview]
Message-ID: <87r3osronp.fsf@gnu.org> (raw)
In-Reply-To: <idj8ub7kjl1.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Thu, 25 Jun 2015 15:23:38 +0200")

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From 3ffe6847848f6ba107e0757728f1c6a6e7807d56 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 23 Jun 2015 10:54:00 +0200
> Subject: [PATCH] gnu: Add preseq.
>
> * gnu/packages/bioinformatics.scm (preseq): New variable.

[...]

> +              (snippet
> +               ;; Remove bundled samtools.  Leave the headers.
> +               '(for-each delete-file
> +                          (find-files "preseq-master/samtools"
> +                                      "\\.c$")))))

Why leave the headers?  Isn’t it risky to leave headers that may be
different from the Samtools that we’re actually linking against?

Otherwise LGTM.

Thanks,
Ludo’.

  reply	other threads:[~2015-07-01 13:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 11:02 [PATCH] Add preseq Ricardo Wurmus
2015-06-25 13:23 ` Ricardo Wurmus
2015-07-01 13:30   ` Ludovic Courtès [this message]
2015-07-01 13:33     ` Ricardo Wurmus
2015-07-01 15:00       ` Ludovic Courtès
2015-07-07 12:45         ` Ricardo Wurmus
2015-07-08 12:59           ` Ludovic Courtès
2015-07-08 22:37             ` Mark H Weaver
2015-07-09 10:16               ` Ricardo Wurmus
2015-07-09 15:55                 ` Mark H Weaver
2015-07-10  7:10                   ` Ricardo Wurmus
2015-07-01 13:30   ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3osronp.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.